[GitHub] [lucene] msokolov commented on a change in pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
msokolov commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725426021 ## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-08 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r725401031 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -48,6 +48,7 @@ cygwin = platform.system().lower().startswith('cygwin') cygwinWindowsRoot = os.pope

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-08 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r725396122 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -900,42 +701,19 @@ def testDemo(run_java, isSrc, version, jdk): if removeTrailingZeros(actualVers

[GitHub] [lucene] markrmiller edited a comment on pull request #365: GameGenie:1990JMH

2021-10-08 Thread GitBox
markrmiller edited a comment on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-939167876 > > git clone -b JMH --single-branch https://github.com/markrmiller/lucene.git >cd lucene/lucene/jmh > ./jmh.sh FuzzyQuery > > // async-profi

[GitHub] [lucene] markrmiller edited a comment on pull request #365: GameGenie:1990JMH

2021-10-08 Thread GitBox
markrmiller edited a comment on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-937960859 The **index**, **line doc file**, and **tasks file** can be generated via the _lucene-util_ benchmark. The only current task is a **SearchPerf** task that roughly emulat

[GitHub] [lucene] markrmiller edited a comment on pull request #365: GameGenie:1990JMH

2021-10-08 Thread GitBox
markrmiller edited a comment on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-939167876 > > git clone -b JMH --single-branch https://github.com/markrmiller/lucene.git >cd lucene/lucene/jmh > ./jmh.sh FuzzyQuery > -- This is an automa

[GitHub] [lucene] markrmiller commented on pull request #365: GameGenie:1990JMH

2021-10-08 Thread GitBox
markrmiller commented on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-939167876 ` git clone -b JMH --single-branch https://github.com/markrmiller/lucene.git cd lucene/lucene/jmh ./jmh.sh FuzzyQuery ` -- This is an automated message fr

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-08 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r725370169 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -900,42 +701,19 @@ def testDemo(run_java, isSrc, version, jdk): if removeTrailingZeros(actualVers

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-08 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r725350490 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -658,97 +616,41 @@ def verifyUnpacked(java, project, artifact, unpackPath, gitRevision, version, te

[jira] [Commented] (LUCENE-8637) WeightedSpanTermExtractor unnexessarily enforces rewrite for some SpanQueiries

2021-10-08 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426406#comment-17426406 ] Marcus Eagan commented on LUCENE-8637: -- [~gol...@detego-software.de] Can you check

[GitHub] [lucene] uschindler commented on a change in pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
uschindler commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725287741 ## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [lucene] uschindler commented on a change in pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
uschindler commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725287741 ## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [lucene] uschindler commented on a change in pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
uschindler commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725286409 ## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [lucene] dweiss commented on a change in pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
dweiss commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725220341 ## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Resolved] (LUCENE-10136) Lift the restriction on using 'var' variables

2021-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10136. -- Fix Version/s: main (9.0) Resolution: Fixed > Lift the restriction on using 'var' vari

[jira] [Commented] (LUCENE-10136) Lift the restriction on using 'var' variables

2021-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426318#comment-17426318 ] ASF subversion and git services commented on LUCENE-10136: -- Co

[GitHub] [lucene] dweiss merged pull request #368: LUCENE-10136: allow 'var' declarations in source code

2021-10-08 Thread GitBox
dweiss merged pull request #368: URL: https://github.com/apache/lucene/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] msokolov commented on pull request #350: LUCENE-10182: No longer check dvGen.

2021-10-08 Thread GitBox
msokolov commented on pull request #350: URL: https://github.com/apache/lucene/pull/350#issuecomment-938823886 Oh, sorry I am just catching up here. I like this solution. I'm also kind of annoyed that this slipped through before when I added the error message specialization (I think th

[GitHub] [lucene] msokolov commented on a change in pull request #350: LUCENE-10182: No longer check dvGen.

2021-10-08 Thread GitBox
msokolov commented on a change in pull request #350: URL: https://github.com/apache/lucene/pull/350#discussion_r725158069 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -1348,7 +1348,13 @@ private void assertSame(String label, int expected,

[GitHub] [lucene] balmukundblr commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-08 Thread GitBox
balmukundblr commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-938795581 > Thanks for this patch! Can you please also update gradlew.bat? Done required changes in gradlew.bat file. -- This is an automated message from the Apache Git Service

[GitHub] [lucene] balmukundblr commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-08 Thread GitBox
balmukundblr commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-938790568 > Dealing with this in scripts is nightmarish... but if you do want it then you should: > > * provide the defaults (empty string) if the variable is not defined, > *

[GitHub] [lucene] madrob commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-08 Thread GitBox
madrob commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r725033367 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -900,42 +701,19 @@ def testDemo(run_java, isSrc, version, jdk): if removeTrailingZeros(actualVers

[GitHub] [lucene] mikemccand commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-08 Thread GitBox
mikemccand commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r725023003 ## File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java ## @@ -96,12 +110,36 @@ public AutomatonQuery(final Term term, Automaton

[jira] [Updated] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10158: --- Description: While creating the new MMapDirectory using Project Panama in the recent OpenJD

[jira] [Commented] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426191#comment-17426191 ] Uwe Schindler commented on LUCENE-10158: For discussion about this interface se

[GitHub] [lucene] mikemccand commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-08 Thread GitBox
mikemccand commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r725016724 ## File path: lucene/core/src/test/org/apache/lucene/util/automaton/TestNFARunAutomaton.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] mikemccand commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-08 Thread GitBox
mikemccand commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r725015736 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -551,12 +551,22 @@ static RegExp newLeafNode( return new RegExp

[jira] [Updated] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10158: --- Fix Version/s: main (9.0) > Add a new interface Unwrappable to the utils package to ease mi

[jira] [Updated] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10158: --- Summary: Add a new interface Unwrappable to the utils package to ease migration to new MMAP

[jira] [Commented] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426189#comment-17426189 ] Uwe Schindler commented on LUCENE-10158: Here is the pull request: https://gith

[GitHub] [lucene] uschindler opened a new pull request #369: LUCENE-10158: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and its testing

2021-10-08 Thread GitBox
uschindler opened a new pull request #369: URL: https://github.com/apache/lucene/pull/369 See https://issues.apache.org/jira/browse/LUCENE-10158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (LUCENE-10158) Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and testing

2021-10-08 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10158: -- Summary: Add a new interface Unwrappable to the utils package to ease migration to new MMAPDirectory and testing Key: LUCENE-10158 URL: https://issues.apache.org/jira/browse/L

[GitHub] [lucene] mikemccand commented on a change in pull request #368: LUCENE-10136: allow 'var' declarations in source code

2021-10-08 Thread GitBox
mikemccand commented on a change in pull request #368: URL: https://github.com/apache/lucene/pull/368#discussion_r724999261 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -1965,7 +1965,7 @@ public void testCommitWithUserDataOnly() throws E

[GitHub] [lucene] dweiss commented on pull request #368: LUCENE-10136: allow 'var' declarations in source code

2021-10-08 Thread GitBox
dweiss commented on pull request #368: URL: https://github.com/apache/lucene/pull/368#issuecomment-938547464 Lifted one restriction (var use), left this one in though. {code} (~$/\n\s*var\s+.*=.*<>.*/$) : 'Diamond operators should not be used with var' {code} Also, added a si

[jira] [Comment Edited] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-10-08 Thread Stefan Vodita (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426103#comment-17426103 ] Stefan Vodita edited comment on LUCENE-10129 at 10/8/21, 10:33 AM: --

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-10-08 Thread Stefan Vodita (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426103#comment-17426103 ] Stefan Vodita commented on LUCENE-10129: Hello! I am new to Lucene, and this lo

[GitHub] [lucene] stefanvodita opened a new pull request #367: LUCENE-10129: Add RamUsageEstimator.shallowSizeOf() for primitive arrays

2021-10-08 Thread GitBox
stefanvodita opened a new pull request #367: URL: https://github.com/apache/lucene/pull/367 # Description `shallowSizeOf(long[])` would call `shallowSizeOf(Object)`, which is slower, but leads to the same result as `sizeOf(long[])`. The same applies to all primitive type

[jira] [Commented] (LUCENE-5572) JapaneseTokenizer is sensitive to interrupts

2021-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426035#comment-17426035 ] Dawid Weiss commented on LUCENE-5572: - bq. A GUI application running outside our con