dweiss commented on a change in pull request #369: URL: https://github.com/apache/lucene/pull/369#discussion_r725220341
########## File path: lucene/core/src/java/org/apache/lucene/util/Unwrappable.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.util; + +/** + * An object with this interface is a wrapper around another object (e.g., a filter with a + * delegate). The method {@link #unwrap()} can be called to get the wrapped object + * + * @lucene.internal + */ +public interface Unwrappable<T> { Review comment: I feel like we already had this discussion at some point in the past (about terminology and unwrapAll being static vs. a default method)?... Looks good to me. I recall Eclipse used a different pattern - they had type adapters which you could register as a service and then the service took care of adapting one type to another (here it'd unwrap delegates). This has the advantage of not exposing any additional methods on the class - the service facility could require a Function<X,Y> upon registration. Maybe it's overengineering though - this method seems fine to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
