[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-03 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423773#comment-17423773 ] Dawid Weiss commented on LUCENE-10143: -- How would you know when it's flushed thoug

[GitHub] [lucene] mayya-sharipova commented on pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on pull request #315: URL: https://github.com/apache/lucene/pull/315#issuecomment-933034051 @jtibshirani Thanks for another round of review. I've tried to address your comments in the last commits. Please continue to review when you have time. -- This is an aut

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r720914724 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -204,6 +214,45 @@ private FieldEntry readF

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r720879574 ## File path: lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java ## @@ -52,12 +53,21 @@ protected KnnGraphValues() {} */ public

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r720879434 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsFormat.java ## @@ -69,10 +99,12 @@ static final String

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r720879434 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsFormat.java ## @@ -69,10 +99,12 @@ static final String

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-10-03 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r720879315 ## File path: lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java ## @@ -268,103 +281,47 @@ public void testDiversity() throws IOExce

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720871395 ## File path: lucene/core/src/java/org/apache/lucene/store/InputStreamDataInput.java ## @@ -33,6 +33,21 @@ public byte readByte() throws IOException { re

[GitHub] [lucene] jpountz commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
jpountz commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720719926 ## File path: lucene/core/src/java/org/apache/lucene/store/InputStreamDataInput.java ## @@ -33,6 +33,21 @@ public byte readByte() throws IOException {

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423697#comment-17423697 ] Adrien Grand commented on LUCENE-10143: --- I wonder how much overhead RateLimitedIn

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-10-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423684#comment-17423684 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-10-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423683#comment-17423683 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-10-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423682#comment-17423682 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-10-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423681#comment-17423681 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[GitHub] [lucene-solr] dnhatn closed pull request #2588: LUCENE-10126: Fix competitive iterator wrongly skip docs

2021-10-03 Thread GitBox
dnhatn closed pull request #2588: URL: https://github.com/apache/lucene-solr/pull/2588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [lucene-solr] dnhatn opened a new pull request #2588: LUCENE-10126: Fix competitive iterator wrongly skip docs

2021-10-03 Thread GitBox
dnhatn opened a new pull request #2588: URL: https://github.com/apache/lucene-solr/pull/2588 The competitive iterator can wrongly skip a document that is advanced but not collected in the previous scoreRange. -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (LUCENE-10075) NPE on wildcard-based overlapping intervals highlighting

2021-10-03 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423654#comment-17423654 ] Alan Woodward commented on LUCENE-10075: This is a bug in CachingMatchesIterato

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720802169 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720801428 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java ## @@ -319,6 +320,27 @@ public void readBytes(byte[] b, int offset,

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720800554 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java ## @@ -319,6 +320,27 @@ public void readBytes(byte[] b, int offset,

[GitHub] [lucene] uschindler commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
uschindler commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720791546 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java ## @@ -319,6 +320,27 @@ public void readBytes(byte[] b, int off

[GitHub] [lucene] dweiss commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

2021-10-03 Thread GitBox
dweiss commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r720782981 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {