[jira] [Commented] (LUCENE-10018) Remove Fields from TermVector reader related usage

2021-07-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390274#comment-17390274 ] David Smiley commented on LUCENE-10018: --- [~rmuir] what do you think of the goal s

[GitHub] [lucene] gf53520 commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation

2021-07-29 Thread GitBox
gf53520 commented on pull request #231: URL: https://github.com/apache/lucene/pull/231#issuecomment-889587470 > @gf53520 Changes look good to me. Can you also override the new method in FilterMergePolicy? Thanks @dnhatn. I have just overridden the new method in FilterMergePolicy, P

[GitHub] [lucene] gsmiller commented on pull request #159: LUCENE-9945: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-07-29 Thread GitBox
gsmiller commented on pull request #159: URL: https://github.com/apache/lucene/pull/159#issuecomment-88957 I think cleaning up unit tests is great! But I might suggest opening a separate Jira issue to track that work and working on it separately. That way this PR can stay focused on th

[GitHub] [lucene] zhaih commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-07-29 Thread GitBox
zhaih commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r679509373 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/NFARunAutomaton.java ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene-solr] thelabdude opened a new pull request #2538: SOLR-15277: Schema Designer screen for Admin UI and supporting backend API

2021-07-29 Thread GitBox
thelabdude opened a new pull request #2538: URL: https://github.com/apache/lucene-solr/pull/2538 backport of https://github.com/apache/solr/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] dnhatn commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation

2021-07-29 Thread GitBox
dnhatn commented on pull request #231: URL: https://github.com/apache/lucene/pull/231#issuecomment-889383140 @gf53520 Changes look good to me. Can you also override the new method in FilterMergePolicy? -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Feng Gui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390076#comment-17390076 ] Feng Gui commented on LUCENE-10041: --- https://github.com/apache/lucene/pull/231 > Dup

[GitHub] [lucene] gf53520 opened a new pull request #231: Remove TieredMergePolicy's redundant query computation

2021-07-29 Thread GitBox
gf53520 opened a new pull request #231: URL: https://github.com/apache/lucene/pull/231 …DeletesToMerge # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description

[jira] [Updated] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Feng Gui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Gui updated LUCENE-10041: -- Description: In lucene 8.4 (Elasticsearch 7.6.2), all indices are soft-deletes enabled. We found the

[jira] [Assigned] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen reassigned LUCENE-10041: Assignee: Nhat Nguyen > Duplication computation for TieredMergePolicy's numDeletesToMerg

[jira] [Updated] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Feng Gui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Gui updated LUCENE-10041: -- Description: In lucene 8.4 (Elasticsearch 7.6.2), all indices are soft-deletes enabled. We found the

[jira] [Updated] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Feng Gui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Gui updated LUCENE-10041: -- Attachment: IMG21.jpeg Description: In lucene 8.4 (Elasticsearch 7.6.2),all indices is soft-dele

[jira] [Created] (LUCENE-10041) Duplication computation for TieredMergePolicy's numDeletesToMerge

2021-07-29 Thread Feng Gui (Jira)
Feng Gui created LUCENE-10041: - Summary: Duplication computation for TieredMergePolicy's numDeletesToMerge Key: LUCENE-10041 URL: https://issues.apache.org/jira/browse/LUCENE-10041 Project: Lucene - Core

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390061#comment-17390061 ] Greg Miller commented on LUCENE-10033: -- {quote}Another difference is that my patch

[jira] [Comment Edited] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389998#comment-17389998 ] Greg Miller edited comment on LUCENE-10033 at 7/29/21, 6:10 PM: -

[GitHub] [lucene] jpountz edited a comment on pull request #230: LUCENE-7020: Remove TieredMergePolicy#setMaxMergeAtOnceExplicit.

2021-07-29 Thread GitBox
jpountz edited a comment on pull request #230: URL: https://github.com/apache/lucene/pull/230#issuecomment-889333294 And yes, I was targeting this for 9.0. There is no urgency to remove: users can set maxMergeAtOnceExplicit=Integer.MAX_VALUE as a workaround. -- This is an automated messa

[GitHub] [lucene] jpountz commented on pull request #230: LUCENE-7020: Remove TieredMergePolicy#setMaxMergeAtOnceExplicit.

2021-07-29 Thread GitBox
jpountz commented on pull request #230: URL: https://github.com/apache/lucene/pull/230#issuecomment-889333294 And yes, I was targeting this for 8.x. There is no urgency to remove: users can set maxMergeAtOnceExplicit=Integer.MAX_VALUE as a workaround. -- This is an automated message from

[GitHub] [lucene] jpountz commented on pull request #230: LUCENE-7020: Remove TieredMergePolicy#setMaxMergeAtOnceExplicit.

2021-07-29 Thread GitBox
jpountz commented on pull request #230: URL: https://github.com/apache/lucene/pull/230#issuecomment-889332948 +1 to deprecate in 8.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2021-07-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390042#comment-17390042 ] Michael McCandless commented on LUCENE-7020: +1 to remove. My only worry is

[GitHub] [lucene] mikemccand closed pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

2021-07-29 Thread GitBox
mikemccand closed pull request #220: URL: https://github.com/apache/lucene/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] mikemccand commented on pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

2021-07-29 Thread GitBox
mikemccand commented on pull request #220: URL: https://github.com/apache/lucene/pull/220#issuecomment-889320876 OK I just merged this via git command-line, but apparently GitHub hasn't noticed. Thanks @gautamworah96 ! -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390034#comment-17390034 ] ASF subversion and git services commented on LUCENE-9334: - Commi

[GitHub] [lucene-solr] thelabdude merged pull request #2537: SOLR-15566: Clarify ref guide documentation about SQL queries with SELECT * requiring a LIMIT clause

2021-07-29 Thread GitBox
thelabdude merged pull request #2537: URL: https://github.com/apache/lucene-solr/pull/2537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude opened a new pull request #2537: SOLR-15566: Clarify ref guide documentation about SQL queries with SELECT * requiring a LIMIT clause

2021-07-29 Thread GitBox
thelabdude opened a new pull request #2537: URL: https://github.com/apache/lucene-solr/pull/2537 backport of https://github.com/apache/solr/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2021-07-29 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390007#comment-17390007 ] Shawn Heisey commented on LUCENE-7020: -- Removal sounds like a good option to me.  T

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389998#comment-17389998 ] Greg Miller commented on LUCENE-10033: -- I ran some internal benchmarks with this c

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2021-07-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389956#comment-17389956 ] Adrien Grand commented on LUCENE-7020: -- I had a chat with [~mikemccand] and [~rcmui

[GitHub] [lucene] jpountz opened a new pull request #230: LUCENE-7020: Remove TieredMergePolicy#setMaxMergeAtOnceExplicit.

2021-07-29 Thread GitBox
jpountz opened a new pull request #230: URL: https://github.com/apache/lucene/pull/230 TieredMergePolicy no longer bounds the number of segments that can be merged via a forced merge. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Resolved] (LUCENE-10032) Remove leafDocMaps from MergeState

2021-07-29 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen resolved LUCENE-10032. -- Fix Version/s: 8.10 9.0 Resolution: Fixed > Remove leafDocMaps from

[jira] [Commented] (LUCENE-8505) IndexWriter#addIndices should not sort indices if they are not already sorted

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389929#comment-17389929 ] ASF subversion and git services commented on LUCENE-8505: - Commi

[jira] [Commented] (LUCENE-10032) Remove leafDocMaps from MergeState

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389928#comment-17389928 ] ASF subversion and git services commented on LUCENE-10032: -- Co

[GitHub] [lucene-solr] dnhatn merged pull request #2536: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-29 Thread GitBox
dnhatn merged pull request #2536: URL: https://github.com/apache/lucene-solr/pull/2536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389910#comment-17389910 ] Adrien Grand commented on LUCENE-10033: --- bq. Unfortunately I noticed that the sor

[GitHub] [lucene-solr] dnhatn opened a new pull request #2536: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-29 Thread GitBox
dnhatn opened a new pull request #2536: URL: https://github.com/apache/lucene-solr/pull/2536 These maps are no longer useful after LUCENE-8505. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Resolved] (LUCENE-10031) Speedup to SortedDocIDMerger when sorting on low-cardinality fields

2021-07-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10031. --- Fix Version/s: 8.10 Resolution: Fixed > Speedup to SortedDocIDMerger when sorting on

[jira] [Comment Edited] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389881#comment-17389881 ] Greg Miller edited comment on LUCENE-10033 at 7/29/21, 1:00 PM: -

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389881#comment-17389881 ] Greg Miller commented on LUCENE-10033: -- Hmm, wouldn't we expect to see an index si

[jira] [Commented] (LUCENE-10032) Remove leafDocMaps from MergeState

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389869#comment-17389869 ] ASF subversion and git services commented on LUCENE-10032: -- Co

[GitHub] [lucene] dnhatn merged pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-29 Thread GitBox
dnhatn merged pull request #222: URL: https://github.com/apache/lucene/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-8505) IndexWriter#addIndices should not sort indices if they are not already sorted

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389870#comment-17389870 ] ASF subversion and git services commented on LUCENE-8505: - Commi

[GitHub] [lucene] dnhatn commented on pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-29 Thread GitBox
dnhatn commented on pull request #222: URL: https://github.com/apache/lucene/pull/222#issuecomment-889075808 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389864#comment-17389864 ] Michael McCandless commented on LUCENE-10033: - {quote}But the former tend t

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389841#comment-17389841 ] Robert Muir commented on LUCENE-10033: -- {quote} Queries that consume most values l

[jira] [Commented] (LUCENE-10031) Speedup to SortedDocIDMerger when sorting on low-cardinality fields

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389728#comment-17389728 ] ASF subversion and git services commented on LUCENE-10031: -- Co