[GitHub] [lucene-solr] dsmiley commented on pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

dsmiley commented on pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#issuecomment-857351201 I don't know what the point is in reaching into the response type to do an instanceof check. Testing the values are returned and not ordinals is the real important part. A

[GitHub] [lucene-solr] dsmiley merged pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

dsmiley merged pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [lucene-solr] gautamworah96 commented on pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

gautamworah96 commented on pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#issuecomment-857311496 > Once we iterate to a solid PR I am very curious how this helps facets performance -- we can switch luceneutil over to this bulk API to test. Today both `IntTax

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647825585 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java ## @@ -774,6 +763,30 @@ public Long parseAndAddGap(@S

[GitHub] [lucene] uschindler commented on pull request #174: LUCENE-8739: Add ZSTD support.

uschindler commented on pull request #174: URL: https://github.com/apache/lucene/pull/174#issuecomment-857110715 With foreign API you can directly wrap arrays to compress and wrap as MemorySegment and pass to foreign function (native MethodHandle). Jextract parses header file and creates M

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

dsmiley commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647761533 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java ## @@ -774,6 +763,30 @@ public Long parseAndAddGap(@SuppressWa

[GitHub] [lucene] rmuir commented on pull request #174: LUCENE-8739: Add ZSTD support.

rmuir commented on pull request #174: URL: https://github.com/apache/lucene/pull/174#issuecomment-857008732 @jpountz another alternative would be to build against the new JDK foreign api? If we need to call out to some native code, maybe we should look at the best available mechanism. From

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647663449 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647663449 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647660649 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger edited a comment on pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#issuecomment-856900350 > If some of those methods are only used in range faceting, perhaps it doesn't make sense to support range faceting on an enum field any way? Thus it'd be ok

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647659344 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -231,55 +224,60 @@ public IndexInput openInput(String name, IOContext

[GitHub] [lucene] jpountz commented on pull request #174: LUCENE-8739: Add ZSTD support.

jpountz commented on pull request #174: URL: https://github.com/apache/lucene/pull/174#issuecomment-856964392 Right, zstd definitely outperforms zlib on large files, but when I tested with Lucene stored fields, the difference wasn't very significant, which makes me wonder that most of the

[GitHub] [lucene] jpountz closed pull request #174: LUCENE-8739: Add ZSTD support.

jpountz closed pull request #174: URL: https://github.com/apache/lucene/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647656801 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647655671 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647655523 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] jpountz commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

jpountz commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r647654997 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,92 @@ public void testRandom() th

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647648735 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java ## @@ -774,6 +763,30 @@ public Long parseAndAddGap(@S

[GitHub] [lucene] rmuir commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

rmuir commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647598763 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene] msokolov commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

msokolov commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r647429868 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -231,55 +224,60 @@ public IndexInput openInput(String name, IOContext c

[GitHub] [lucene-solr] thomaswoeckinger commented on pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#issuecomment-856900350 > If some of those methods are only used in range faceting, perhaps it doesn't make sense to support range faceting on an enum field any way? Thus it'd be okay to t

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359411#comment-17359411 ] ASF subversion and git services commented on LUCENE-9905: - Commi

[GitHub] [lucene] jtibshirani merged pull request #176: LUCENE-9905: Make sure to use configured vector format when merging

jtibshirani merged pull request #176: URL: https://github.com/apache/lucene/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene] jtibshirani commented on pull request #176: LUCENE-9905: Make sure to use configured vector format when merging

jtibshirani commented on pull request #176: URL: https://github.com/apache/lucene/pull/176#issuecomment-856850849 Thanks for reviewing ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-solr] cpoerschke commented on pull request #2509: Fix 8.9.0 < 8.10.0 comparison in smokeTestRelease.py script.

cpoerschke commented on pull request #2509: URL: https://github.com/apache/lucene-solr/pull/2509#issuecomment-856844229 cherry-picking to `lucene-solr/branch_8x` and `lucene/main` and `solr/main` branches is complete. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-solr] cpoerschke merged pull request #2509: Fix 8.9.0 < 8.10.0 comparison in smokeTestRelease.py script.

cpoerschke merged pull request #2509: URL: https://github.com/apache/lucene-solr/pull/2509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene-solr] cpoerschke commented on pull request #2509: Fix 8.9.0 < 8.10.0 comparison in smokeTestRelease.py script.

cpoerschke commented on pull request #2509: URL: https://github.com/apache/lucene-solr/pull/2509#issuecomment-856829661 > good find not my find, apologies, i could have attributed the find better in pull request from the outset. updated now retrospectively. -- This is an automated

[jira] [Commented] (LUCENE-9653) Investigate usage of incubating jdk.incubator.foreign for MMapDirectory

[ https://issues.apache.org/jira/browse/LUCENE-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359391#comment-17359391 ] Uwe Schindler commented on LUCENE-9653: --- New Pull requests: - JDK 16: https://gith

[GitHub] [lucene-solr] thomaswoeckinger commented on pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#issuecomment-856795094 > If some of those methods are only used in range faceting, perhaps it doesn't make sense to support range faceting on an enum field any way? Thus it'd be okay to t

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647471384 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java ## @@ -774,6 +763,30 @@ public Long parseAndAddGap(@S

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

thomaswoeckinger commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647459338 ## File path: solr/core/src/test/org/apache/solr/schema/EnumFieldTest.java ## @@ -592,6 +592,11 @@ public void testFacetEnumSearch() throws E

[GitHub] [lucene] uschindler commented on pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on pull request #177: URL: https://github.com/apache/lucene/pull/177#issuecomment-856778316 Linux Jenkins tests: https://jenkins.thetaphi.de/job/Lucene-jdk17panama-Linux/ Windows Jenkins tests: https://jenkins.thetaphi.de/job/Lucene-jdk17panama-Windows/ -- This i

[GitHub] [lucene-solr] dsmiley commented on pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

dsmiley commented on pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#issuecomment-856774500 If some of those methods are only used in range faceting, perhaps it doesn't make sense to support range faceting on an enum field any way? Thus it'd be okay to throw as be

[jira] [Commented] (LUCENE-9855) Reconsider names for ANN related format and APIs

[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359333#comment-17359333 ] Tomoko Uchida commented on LUCENE-9855: --- I've not noticed this was reopened. Just

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2508: SOLR-15457: Returning EnumFieldValue in faceting buckets again.

dsmiley commented on a change in pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647383022 ## File path: solr/core/src/test/org/apache/solr/schema/EnumFieldTest.java ## @@ -592,6 +592,11 @@ public void testFacetEnumSearch() throws Exception

[GitHub] [lucene] uschindler commented on pull request #173: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) Panama APIs (>= JDK-16-ea-b32)

uschindler commented on pull request #173: URL: https://github.com/apache/lucene/pull/173#issuecomment-856682232 The JDK 17 version is now here: #177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] uschindler opened a new pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-25)

uschindler opened a new pull request #177: URL: https://github.com/apache/lucene/pull/177 **INFO: This is a followup of #173: It's the same code base, but with API changes from JDK 17 applied** This is just a draft PR for a first insight on memory mapping improvements in JDK 17+.

[GitHub] [lucene] uschindler commented on pull request #173: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) Panama APIs (>= JDK-16-ea-b32)

uschindler commented on pull request #173: URL: https://github.com/apache/lucene/pull/173#issuecomment-856594835 Hi, I am currently working on an Update to Java 17, where some changes occurred (there is a new `ResourceScope` class that replaces `MemorySegment.share()`; the good thing: Y

[GitHub] [lucene-solr] cpoerschke opened a new pull request #2509: Fix 8.9.0 < 8.10.0 comparison in smokeTestRelease.py script.

cpoerschke opened a new pull request #2509: URL: https://github.com/apache/lucene-solr/pull/2509 (Please note this pull request is for `lucene-solr/branch_8_9` branch and after merge the changes would have to be cherry-picked to `lucene-solr/branch_8x` branch and (I'm guessing) also `lucen

[GitHub] [lucene-solr] thomaswoeckinger opened a new pull request #2508: SOLR-15457: Returning EnvmFieldValue in faceting buckets again.

thomaswoeckinger opened a new pull request #2508: URL: https://github.com/apache/lucene-solr/pull/2508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[jira] [Commented] (LUCENE-8118) ArrayIndexOutOfBoundsException in TermsHashPerField.writeByte during indexing

[ https://issues.apache.org/jira/browse/LUCENE-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359100#comment-17359100 ] Nam-Quang Tran commented on LUCENE-8118: Update on my previous post: After some

[GitHub] [lucene] dweiss commented on a change in pull request #175: LUCENE-9990: gradle7 support

dweiss commented on a change in pull request #175: URL: https://github.com/apache/lucene/pull/175#discussion_r647179032 ## File path: gradle/testing/alternative-jdk-support.gradle ## @@ -18,60 +18,60 @@ // This adds support for compiling and testing against a different Java r