gautamworah96 commented on pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#issuecomment-857311496
> Once we iterate to a solid PR I am very curious how this helps facets performance -- we can switch luceneutil over to this bulk API to test. Today both `IntTaxonomyFacets` and `FloatTaxonomyFacets` iteratively call `getPath` on all the top ordinals and then return the `topChildren` `FacetLabels` that the user wanted. With this API change, we could switch over `IntTaxonomyFacets` and `FloatTaxonomyFacets` to use this bulk API. All downstream children `Facets` such as `FastTaxonomyFacetCount` use this base `getTopChildren` function so all users will be able to benefit from this change by default. Surprisingly, Our `luceneutil` benchmark **only** tests the `getTopChildren` API so we should be able to see the performance change with the stock `luceneutil` package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
