jpountz commented on a change in pull request #176:
URL: https://github.com/apache/lucene/pull/176#discussion_r647160213
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java
##
@@ -114,14 +114,7 @@ public void close() throws IOExceptio
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359044#comment-17359044
]
Julie Tibshirani edited comment on LUCENE-9855 at 6/8/21, 5:32 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359044#comment-17359044
]
Julie Tibshirani commented on LUCENE-9855:
--
I noticed recently we still had thi
jtibshirani commented on a change in pull request #176:
URL: https://github.com/apache/lucene/pull/176#discussion_r647045642
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java
##
@@ -114,14 +114,7 @@ public void close() throws IOExce
zacharymorn commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-856394004
Hi @mikemccand, I have addressed the comment above with some additional
changes and posted some updated results. Could you please let me know if they
look ready?
--
This is
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r647068377
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -843,6 +812,258 @@ public Status checkIndex(List onlySegments)
throws I
[
https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359001#comment-17359001
]
Zach Chen commented on LUCENE-9976:
---
No worry [~jpountz], and hope you had a great vac
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647053364
##
File path: gradle/testing/alternative-jdk-support.gradle
##
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647053364
##
File path: gradle/testing/alternative-jdk-support.gradle
##
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647040460
##
File path: gradle/java/javac.gradle
##
@@ -16,6 +16,15 @@
*/
// Configure Java project defaults.
+java {
+ toolchain {
+languageVersion =
jtibshirani commented on a change in pull request #176:
URL: https://github.com/apache/lucene/pull/176#discussion_r647045642
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java
##
@@ -114,14 +114,7 @@ public void close() throws IOExce
jtibshirani opened a new pull request #176:
URL: https://github.com/apache/lucene/pull/176
Before when creating a VectorWriter for merging, we would always load the
default implementation. So if the format was configured with parameters, they
were ignored.
This issue was caught
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647040440
##
File path: gradle/wrapper/gradle-wrapper.jar.version
##
@@ -1 +1 @@
-6.8.3
+7.0.2
Review comment:
I checked https://services.gradle.org/dist
rmuir commented on pull request #172:
URL: https://github.com/apache/lucene/pull/172#issuecomment-856360112
I hit the issue locally just running `./gradlew test`. A second time the
tests pass.
I think it isn't great that simple base-cases like empty are only exposed in
random test f
rmuir commented on pull request #174:
URL: https://github.com/apache/lucene/pull/174#issuecomment-856311545
What is the improvement? Especially interested in performance versus a
"good" zlib: e.g. your comment here:
https://issues.apache.org/jira/browse/LUCENE-8739?focusedCommentId=1732201
gsmiller commented on a change in pull request #159:
URL: https://github.com/apache/lucene/pull/159#discussion_r646946460
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##
@@ -390,18 +398,44 @@ protected boolean scoreSubDocsAtOnce() {
return
msokolov commented on pull request #172:
URL: https://github.com/apache/lucene/pull/172#issuecomment-856259875
Hmm sorry for the force-pushing, I rebased locally and ... git is hard. I'm
not sure what I was thinking before; I actually had a change that did not
special-case the empty case,
gsmiller opened a new pull request #2507:
URL: https://github.com/apache/lucene-solr/pull/2507
This is a backport from `lucene/main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-9905.
--
Resolution: Fixed
> Revise approach to specifying NN algorithm
> -
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358832#comment-17358832
]
ASF subversion and git services commented on LUCENE-9905:
-
Commi
jtibshirani merged pull request #166:
URL: https://github.com/apache/lucene/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
gsmiller opened a new pull request #2506:
URL: https://github.com/apache/lucene-solr/pull/2506
* LUCENE-9962: Allow DrillSideways sub-classes to provide their own "drill
down" facet counting implementation (or null)
* LUCENE-9944: Allow DrillSideways users to pass a CollectorManager with
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358789#comment-17358789
]
Haoyu Zhai commented on LUCENE-9983:
[~broustant] in the adversarial test case, I ad
msokolov commented on a change in pull request #172:
URL: https://github.com/apache/lucene/pull/172#discussion_r646834733
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -104,9 +104,12 @@ private void mergeVectors(FieldInfo mergeFieldInfo, fi
balmukundblr commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r646815233
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java
##
@@ -100,21 +100,24 @@ public void close()
sejal-pawar commented on a change in pull request #159:
URL: https://github.com/apache/lucene/pull/159#discussion_r646809569
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##
@@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() {
/**
[
https://issues.apache.org/jira/browse/LUCENE-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358726#comment-17358726
]
Adrien Grand commented on LUCENE-9993:
--
IndexWriter wants field infos in order to c
Adrien Grand created LUCENE-9994:
Summary: Can IndexingChain better protect against large documents?
Key: LUCENE-9994
URL: https://issues.apache.org/jira/browse/LUCENE-9994
Project: Lucene - Core
Mohit Godwani created LUCENE-9993:
-
Summary: IndexWriter Initialisation dependent on .fnm files
Key: LUCENE-9993
URL: https://issues.apache.org/jira/browse/LUCENE-9993
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358650#comment-17358650
]
Michael McCandless commented on LUCENE-9983:
[~zhai7631], also realize that
[
https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-8143.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Remove SpanBoostQuery
> ---
[
https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358648#comment-17358648
]
ASF subversion and git services commented on LUCENE-8143:
-
Commi
romseygeek merged pull request #155:
URL: https://github.com/apache/lucene/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
balmukundblr commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r646613630
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java
##
@@ -340,12 +340,17 @@ private int doParallelTasks
balmukundblr commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r646611128
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java
##
@@ -340,12 +340,17 @@ private int doParallelTasks
balmukundblr commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r646609916
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java
##
@@ -100,21 +100,24 @@ public void close()
dweiss commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r646602463
##
File path: gradle/wrapper/gradle-wrapper.jar.version
##
@@ -1 +1 @@
-6.8.3
+7.0.2
Review comment:
You'll also need to update the hash of the wrappe
dweiss opened a new pull request #175:
URL: https://github.com/apache/lucene/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
uschindler commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646596993
##
File path:
lucene/test-framework/src/java/org/apache/lucene/mockfile/FilterPath.java
##
@@ -261,10 +267,7 @@ public boolean equals(Object obj) {
*
dweiss commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646570141
##
File path:
lucene/test-framework/src/java/org/apache/lucene/mockfile/FilterPath.java
##
@@ -261,10 +267,7 @@ public boolean equals(Object obj) {
* @re
dweiss commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646570141
##
File path:
lucene/test-framework/src/java/org/apache/lucene/mockfile/FilterPath.java
##
@@ -261,10 +267,7 @@ public boolean equals(Object obj) {
* @re
jpountz commented on a change in pull request #172:
URL: https://github.com/apache/lucene/pull/172#discussion_r646567016
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -104,9 +104,12 @@ private void mergeVectors(FieldInfo mergeFieldInfo, fin
uschindler commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-855903431
On the Windown build I have seen this error on Jenkins:
```
1> 2.857s 1.5s:idle P0 [ set repls] top: set replicasIDs=[1]
tcpPorts=[55991]
1> 2.888s 1.5s:
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358574#comment-17358574
]
Adrien Grand commented on LUCENE-8739:
--
I opened a PR that uses the exact same appr
jpountz opened a new pull request #174:
URL: https://github.com/apache/lucene/pull/174
This is a new stored fields format that leverages ZSTD via JNA.
JNA doesn't have a NOTICE file on their repository, so I copied the bottom
of the README that seems to cover what the NOTICE file usu
uschindler commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-855892370
I invite everybody to attend this talk:
https://2021.berlinbuzzwords.de/session/future-lucenes-mmapdirectory-why-use-it-and-whats-coming-java-16-and-later
--
This is an automa
uschindler commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646550354
##
File path:
lucene/test-framework/src/java/org/apache/lucene/mockfile/FilterPath.java
##
@@ -261,10 +267,7 @@ public boolean equals(Object obj) {
*
uschindler commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646547557
##
File path:
lucene/test-framework/src/java/org/apache/lucene/mockfile/FilterPath.java
##
@@ -261,10 +267,7 @@ public boolean equals(Object obj) {
*
uschindler commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646547379
##
File path: lucene/core/src/java/org/apache/lucene/util/Unwrapable.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
dweiss commented on a change in pull request #173:
URL: https://github.com/apache/lucene/pull/173#discussion_r646540797
##
File path: lucene/core/src/java/org/apache/lucene/util/Unwrapable.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
msokolov commented on a change in pull request #172:
URL: https://github.com/apache/lucene/pull/172#discussion_r646532102
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -104,9 +104,12 @@ private void mergeVectors(FieldInfo mergeFieldInfo, fi
uschindler commented on pull request #2176:
URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-855874294
I will close this and would like to move discussion over to
https://github.com/apache/lucene/pull/173
--
This is an automated message from the Apache Git Service.
To re
uschindler closed pull request #2176:
URL: https://github.com/apache/lucene-solr/pull/2176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
msokolov commented on a change in pull request #172:
URL: https://github.com/apache/lucene/pull/172#discussion_r646529427
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -104,9 +104,12 @@ private void mergeVectors(FieldInfo mergeFieldInfo, fi
uschindler commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-855872206
I moved this old pull request from
https://github.com/apache/lucene-solr/pull/2176 to the Lucene repository:
- Removed the changes in Solr
- Updated to Little Endian (see #
uschindler opened a new pull request #173:
URL: https://github.com/apache/lucene/pull/173
**INFO: This is a clone/update of
https://github.com/apache/lucene-solr/pull/2176** _(for more detailed
discussion see this old PR from the Lucene/Solr combined repository)_
This is just a draf
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358418#comment-17358418
]
Bruno Roustant commented on LUCENE-9983:
[~zhai7631] do you have some stats abou
[
https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358414#comment-17358414
]
Adrien Grand commented on LUCENE-9976:
--
You are right [~zacharymorn]! Sorry for not
jpountz commented on a change in pull request #172:
URL: https://github.com/apache/lucene/pull/172#discussion_r646330897
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -104,9 +104,12 @@ private void mergeVectors(FieldInfo mergeFieldInfo, fin
59 matches
Mail list logo
