[GitHub] [lucene] nitirajrathore commented on a change in pull request #83: LUCENE-9798 : Fix looping bug and made Full Knn calculation parallelizable

2021-04-19 Thread GitBox
nitirajrathore commented on a change in pull request #83: URL: https://github.com/apache/lucene/pull/83#discussion_r616391655 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/FullKnn.java ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] iverase opened a new pull request #97: LUCENE-9907: Move PackedInts#getReaderNoHeader() to backwards codec

2021-04-19 Thread GitBox
iverase opened a new pull request #97: URL: https://github.com/apache/lucene/pull/97 The method PackedInts#getReaderNoHeader() is only used from codecs in backwards-codec, therefore we can move the actual method to that package. In order to do that we create read only versions of Pac

[jira] [Updated] (LUCENE-9907) Remove dependency on PackedInts#getReader() in all current codecs

2021-04-19 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-9907: - Summary: Remove dependency on PackedInts#getReader() in all current codecs (was: Remove depende

[GitHub] [lucene-solr] noblepaul opened a new pull request #2481: SOLR-15337 Avoid XPath in solrconfig.xml parsing

2021-04-19 Thread GitBox
noblepaul opened a new pull request #2481: URL: https://github.com/apache/lucene-solr/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[jira] [Created] (LUCENE-9934) MuseDev on Lucene?

2021-04-19 Thread Thomas DuBuisson (Jira)
Thomas DuBuisson created LUCENE-9934: Summary: MuseDev on Lucene? Key: LUCENE-9934 URL: https://issues.apache.org/jira/browse/LUCENE-9934 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-19 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325327#comment-17325327 ] Michael Sokolov commented on LUCENE-9905: - I think it could be difficult to brea

[GitHub] [lucene-solr] madrob edited a comment on pull request #2411: SOLR-13696 Simplify routed alias tests to avoid flakiness, improve debugging

2021-04-19 Thread GitBox
madrob edited a comment on pull request #2411: URL: https://github.com/apache/lucene-solr/pull/2411#issuecomment-820528027 > it didn't seem reasonable to be trying to set up authentication just for a test. I think this would be the correct approach. Are there other tests you can bor

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-19 Thread Sejal Pawar (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325213#comment-17325213 ] Sejal Pawar commented on LUCENE-9905: - Since its refactoring and touches a few class

[GitHub] [lucene-solr] dsmiley commented on pull request #1142: SOLR-14166: fq cache=false should use TwoPhaseIterator

2021-04-19 Thread GitBox
dsmiley commented on pull request #1142: URL: https://github.com/apache/lucene-solr/pull/1142#issuecomment-822637203 Moved to the new Solr repo https://github.com/apache/solr/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [lucene-solr] dsmiley closed pull request #1142: SOLR-14166: fq cache=false should use TwoPhaseIterator

2021-04-19 Thread GitBox
dsmiley closed pull request #1142: URL: https://github.com/apache/lucene-solr/pull/1142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-19 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r616005264 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDPointValues.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-19 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r615952313 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDPointValues.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-19 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r615952313 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDPointValues.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-19 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r615917265 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDPointValues.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] jpountz commented on pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-04-19 Thread GitBox
jpountz commented on pull request #91: URL: https://github.com/apache/lucene/pull/91#issuecomment-822522155 Wow, this is a neat idea! I wonder if we could find a less intrusive way to apply this change, e.g. could we avoid adding info about whether to sort by doc ID to BKDConfig? For insta

[GitHub] [lucene] jpountz commented on a change in pull request #90: LUCENE-9353: revise format documentation of Lucene90BlockTreeTermsWriter

2021-04-19 Thread GitBox
jpountz commented on a change in pull request #90: URL: https://github.com/apache/lucene/pull/90#discussion_r615854333 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/Lucene90BlockTreeTermsWriter.java ## @@ -140,24 +135,48 @@ * * Header is

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-04-19 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325030#comment-17325030 ] Michael McCandless commented on LUCENE-9694: [~zhai7631] also fixed our {{lu

[jira] [Commented] (LUCENE-9907) Remove dependency on PackedInts in all current codecs

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325012#comment-17325012 ] ASF subversion and git services commented on LUCENE-9907: - Commi

[GitHub] [lucene] iverase merged pull request #96: LUCENE-9907: Remove unused method PackedInts.Mutable#save

2021-04-19 Thread GitBox
iverase merged pull request #96: URL: https://github.com/apache/lucene/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [lucene] iverase opened a new pull request #96: LUCENE-9907: Remove unused method PackedInts.Mutable#save

2021-04-19 Thread GitBox
iverase opened a new pull request #96: URL: https://github.com/apache/lucene/pull/96 The method in PackedInts.Mutable#save is never used. Let 's remove it. The PR removes as well the method PackedInts.Mutable#getFormat() which seems to be only used by the method above. This changes

[jira] [Commented] (LUCENE-9907) Remove dependency on PackedInts in all current codecs

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324979#comment-17324979 ] ASF subversion and git services commented on LUCENE-9907: - Commi

[GitHub] [lucene] iverase merged pull request #94: LUCENE-9907: Remove unused methods in PackedInts

2021-04-19 Thread GitBox
iverase merged pull request #94: URL: https://github.com/apache/lucene/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [lucene] iverase commented on a change in pull request #94: LUCENE-9907: Remove unused methods in PackedInts

2021-04-19 Thread GitBox
iverase commented on a change in pull request #94: URL: https://github.com/apache/lucene/pull/94#discussion_r615791876 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java ## @@ -506,13 +504,13 @@ public void clear() { } /** - * Save

[GitHub] [lucene] jpountz commented on a change in pull request #94: LUCENE-9907: Remove unused methods in PackedInts

2021-04-19 Thread GitBox
jpountz commented on a change in pull request #94: URL: https://github.com/apache/lucene/pull/94#discussion_r615777238 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java ## @@ -506,13 +504,13 @@ public void clear() { } /** - * Save

[jira] [Resolved] (LUCENE-9933) Add non-file properties to wrapped regenerate checksums

2021-04-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9933. - Fix Version/s: main (9.0) Resolution: Fixed > Add non-file properties to wrapped regenera

[jira] [Resolved] (LUCENE-9926) remove last-modified timestamp from ASCIITLD.jflex

2021-04-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9926. - Fix Version/s: main (9.0) Resolution: Fixed > remove last-modified timestamp from ASCIITL

[jira] [Commented] (LUCENE-9933) Add non-file properties to wrapped regenerate checksums

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324958#comment-17324958 ] ASF subversion and git services commented on LUCENE-9933: - Commi

[GitHub] [lucene] dweiss merged pull request #95: LUCENE-9933: Add non-file properties to wrapped regenerate checksums

2021-04-19 Thread GitBox
dweiss merged pull request #95: URL: https://github.com/apache/lucene/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [lucene] dweiss opened a new pull request #95: LUCENE-9933: Add non-file properties to wrapped regenerate checksums

2021-04-19 Thread GitBox
dweiss opened a new pull request #95: URL: https://github.com/apache/lucene/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (LUCENE-9933) Add non-file properties to wrapped regenerate checksums

2021-04-19 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9933: --- Summary: Add non-file properties to wrapped regenerate checksums Key: LUCENE-9933 URL: https://issues.apache.org/jira/browse/LUCENE-9933 Project: Lucene - Core

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-04-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324904#comment-17324904 ] Adrien Grand commented on LUCENE-8739: -- Hi [~wicked1099], force-merging wouldn't ch

[jira] [Assigned] (LUCENE-9926) remove last-modified timestamp from ASCIITLD.jflex

2021-04-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-9926: --- Assignee: Dawid Weiss > remove last-modified timestamp from ASCIITLD.jflex > --

[GitHub] [lucene] iverase opened a new pull request #94: LUCENE-9907: Remove unused methods in PackedInts

2021-04-19 Thread GitBox
iverase opened a new pull request #94: URL: https://github.com/apache/lucene/pull/94 PackedInts provides two ways to reader/write data, one using a header and writing the necessary metadata and a second option where there is not header or metadata and is up to the user to write such inform

[jira] [Commented] (LUCENE-9907) Remove dependency on PackedInts in all current codecs

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324799#comment-17324799 ] ASF subversion and git services commented on LUCENE-9907: - Commi

[GitHub] [lucene] iverase merged pull request #93: LUCENE-9907: Remove unused BlockPackedReader

2021-04-19 Thread GitBox
iverase merged pull request #93: URL: https://github.com/apache/lucene/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont