iverase commented on a change in pull request #94:
URL: https://github.com/apache/lucene/pull/94#discussion_r615791876
##########
File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java
##########
@@ -506,13 +504,13 @@ public void clear() {
}
/**
- * Save this mutable into <code>out</code>. Instantiating a reader from
the generated data will
- * return a reader with the same number of bits per value.
+ * Save this mutable into <code>out</code>. This method does not write any
metadata to the
+ * stream, meaning that it is your responsibility to store it somewhere
else in order to be able
+ * to recover data from the stream later on.
*/
public void save(DataOutput out) throws IOException {
Review comment:
Yes, I will do it in a follow up PR. The issue is that removing this
method affects `Packed64SingleBlock` which is a generated file and therefore we
need to do stuff with the generation stuff to make precommit happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
