[jira] [Created] (LUCENE-9824) Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-04 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9824: Summary: Hunspell suggestions: speed up ngram score calculation for each dictionary entry Key: LUCENE-9824 URL: https://issues.apache.org/jira/browse/LUCENE-9824 Pro

[jira] [Resolved] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15185. - Fix Version/s: master (9.0) Resolution: Fixed > Improve "hash" QParser > -

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295761#comment-17295761 ] ASF subversion and git services commented on SOLR-15185: Commit d

[GitHub] [lucene-solr] dsmiley merged pull request #1524: SOLR-15185: Rewrite Hash query

2021-03-04 Thread GitBox
dsmiley merged pull request #1524: URL: https://github.com/apache/lucene-solr/pull/1524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14660) Migrating HDFS into a package

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295758#comment-17295758 ] David Smiley commented on SOLR-14660: - When the build.gradle is created for this cont

[GitHub] [lucene-solr] zacharymorn commented on pull request #2342: LUCENE-9406: Add IndexWriterEventListener to track events in IndexWriter

2021-03-04 Thread GitBox
zacharymorn commented on pull request #2342: URL: https://github.com/apache/lucene-solr/pull/2342#issuecomment-791146478 No problem, and thanks for the review feedback as well Michael! This is an automated message from the Ap

[jira] [Commented] (SOLR-15217) rename shardsWhitelist and use it more broadly

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295720#comment-17295720 ] David Smiley commented on SOLR-15217: - Maybe use it as an alternative for "allowSolrU

[jira] [Created] (SOLR-15217) rename shardsWhitelist and use it more broadly

2021-03-04 Thread David Smiley (Jira)
David Smiley created SOLR-15217: --- Summary: rename shardsWhitelist and use it more broadly Key: SOLR-15217 URL: https://issues.apache.org/jira/browse/SOLR-15217 Project: Solr Issue Type: Improve

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2021-03-04 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295703#comment-17295703 ] Mark Robert Miller commented on SOLR-14788: --- So with all the issues with my des

[jira] [Commented] (LUCENE-9823) SynonymQuery rewrite can change field boost calculation

2021-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295653#comment-17295653 ] Robert Muir commented on LUCENE-9823: - +1 sounds like this rewrite is unsafe. > Sy

[jira] [Resolved] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9822. - Fix Version/s: master (9.0) Resolution: Fixed Thanks [~gsmiller] ! > Assert that ForUtil

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295647#comment-17295647 ] ASF subversion and git services commented on LUCENE-9822: - Commi

[jira] [Created] (LUCENE-9823) SynonymQuery rewrite can change field boost calculation

2021-03-04 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9823: Summary: SynonymQuery rewrite can change field boost calculation Key: LUCENE-9823 URL: https://issues.apache.org/jira/browse/LUCENE-9823 Project: Lucene - Core

[GitHub] [lucene-solr] tflobbe commented on pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI

2021-03-04 Thread GitBox
tflobbe commented on pull request #2456: URL: https://github.com/apache/lucene-solr/pull/2456#issuecomment-791027598 @deanpearce, do you want to add an entry to CHANGES.txt in the 8.9 section? This is an automated message fro

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295633#comment-17295633 ] Robert Muir commented on LUCENE-9754: - This tokenizer splits on scripts because it l

[jira] [Updated] (SOLR-15216) Invalid JS Object Key data.followers.currentData

2021-03-04 Thread Dean Pearce (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dean Pearce updated SOLR-15216: --- Affects Version/s: 8.8 8.8.1 > Invalid JS Object Key data.followers.currentDat

[jira] [Commented] (SOLR-15216) Invalid JS Object Key data.followers.currentData

2021-03-04 Thread Dean Pearce (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295628#comment-17295628 ] Dean Pearce commented on SOLR-15216: Opened a PR on GitHub with the minimum viable pa

[GitHub] [lucene-solr] deanpearce opened a new pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI

2021-03-04 Thread GitBox
deanpearce opened a new pull request #2456: URL: https://github.com/apache/lucene-solr/pull/2456 # Description Minor bug in the Admin UI Angular code introduced when switching to followers terminology, the underlying API for 8.x still refers to them as slave. In master 9.x branc

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-03-04 Thread Trey Jones (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295622#comment-17295622 ] Trey Jones commented on LUCENE-9754: I appreciate that this is frustrating, and I’m

[jira] [Created] (SOLR-15216) Invalid JS Object Key data.followers.currentData

2021-03-04 Thread Dean Pearce (Jira)
Dean Pearce created SOLR-15216: -- Summary: Invalid JS Object Key data.followers.currentData Key: SOLR-15216 URL: https://issues.apache.org/jira/browse/SOLR-15216 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-2852) SolrJ doesn't need woodstox jar

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295620#comment-17295620 ] David Smiley commented on SOLR-2852: Time to do this for 9.0 in at least SolrJ? > Sol

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295619#comment-17295619 ] ASF subversion and git services commented on LUCENE-9687: - Commi

[GitHub] [lucene-solr] rmuir merged pull request #2451: LUCENE-9687: Hunspell suggestions: reduce work in the findSimilarDictionaryEntries loop

2021-03-04 Thread GitBox
rmuir merged pull request #2451: URL: https://github.com/apache/lucene-solr/pull/2451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-04 Thread David Smiley (Jira)
David Smiley created SOLR-15215: --- Summary: SolrJ: Remove needless Netty dependency Key: SOLR-15215 URL: https://issues.apache.org/jira/browse/SOLR-15215 Project: Solr Issue Type: Improvement

[jira] [Updated] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-03-04 Thread Trey Jones (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Jones updated LUCENE-9754: --- Description: The tokenization of strings like _14th_ with the ICU tokenizer is affected by the char

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2021-03-04 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295595#comment-17295595 ] Mark Robert Miller commented on SOLR-14788: --- Ok, the Mark conquers severe ADD i

[jira] [Commented] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295591#comment-17295591 ] Thomas Wöckinger commented on SOLR-15213: - So, you want to save the RTG query by

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295585#comment-17295585 ] Robert Muir commented on LUCENE-9754: - I explained here what happens in the first co

[GitHub] [lucene-solr] dsmiley opened a new pull request #2455: Make SolrInputField name optional

2021-03-04 Thread GitBox
dsmiley opened a new pull request #2455: URL: https://github.com/apache/lucene-solr/pull/2455 Prevents other bugs by failing fast Very minor change. This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295568#comment-17295568 ] Dawid Weiss commented on SOLR-14759: Made documentation task work for Solr. It still

[jira] [Updated] (SOLR-14759) Separate the Lucene and Solr builds

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14759: --- Description: While still in same git repo, separate the builds, so Lucene and Solr can be built inde

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295564#comment-17295564 ] Joel Bernstein commented on SOLR-15185: --- The *parallel* Streaming Expression is wha

[GitHub] [lucene-solr] magibney commented on pull request #2449: SOLR-15045: Execute local leader commit in parallel with distributed commits in DistributedZkUpdateProcessor

2021-03-04 Thread GitBox
magibney commented on pull request #2449: URL: https://github.com/apache/lucene-solr/pull/2449#issuecomment-790865983 fwiw, I think the gradle precommit is failing on a nocommit comment marking a question about why TOLEADER distrib commit errors aren't propagated back to the client ... not

[jira] [Updated] (SOLR-15214) Provision an optional client configurable ZK port

2021-03-04 Thread Rohan Ganpatye (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Ganpatye updated SOLR-15214: -- Description: Expose an optional parameter that defines the port to start the ZK server on. Thi

[jira] [Created] (SOLR-15214) Provision an optional client configurable ZK port

2021-03-04 Thread Rohan Ganpatye (Jira)
Rohan Ganpatye created SOLR-15214: - Summary: Provision an optional client configurable ZK port Key: SOLR-15214 URL: https://issues.apache.org/jira/browse/SOLR-15214 Project: Solr Issue Type:

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2454: Test docker change, just to see if the docker github action works

2021-03-04 Thread GitBox
HoustonPutman opened a new pull request #2454: URL: https://github.com/apache/lucene-solr/pull/2454 Ignore this. Just testing the github action. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene-solr] balmukundblr commented on a change in pull request #2345: Benchmark custom

2021-03-04 Thread GitBox
balmukundblr commented on a change in pull request #2345: URL: https://github.com/apache/lucene-solr/pull/2345#discussion_r587723043 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java ## @@ -102,19 +104,43 @@ public void

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-03-04 Thread Trey Jones (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295504#comment-17295504 ] Trey Jones commented on LUCENE-9754: Any chance there is a update/reply coming? I kn

[GitHub] [lucene-solr] balmukundblr commented on a change in pull request #2345: Benchmark custom

2021-03-04 Thread GitBox
balmukundblr commented on a change in pull request #2345: URL: https://github.com/apache/lucene-solr/pull/2345#discussion_r587707919 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java ## @@ -146,4 +172,11 @@ public synchr

[GitHub] [lucene-solr] balmukundblr commented on a change in pull request #2345: Benchmark custom

2021-03-04 Thread GitBox
balmukundblr commented on a change in pull request #2345: URL: https://github.com/apache/lucene-solr/pull/2345#discussion_r587707735 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java ## @@ -102,19 +104,43 @@ public void

[jira] [Resolved] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15191. - Resolution: Fixed > Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing

[GitHub] [lucene-solr] balmukundblr commented on a change in pull request #2345: Benchmark custom

2021-03-04 Thread GitBox
balmukundblr commented on a change in pull request #2345: URL: https://github.com/apache/lucene-solr/pull/2345#discussion_r587706698 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java ## @@ -102,19 +104,43 @@ public void

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295492#comment-17295492 ] Greg Miller commented on LUCENE-9822: - Yeah, interesting. Looking at the code, we're

[GitHub] [lucene-solr] dsmiley commented on pull request #2438: SOLR-14928: add exponential backoff for distributed cluster state updates

2021-03-04 Thread GitBox
dsmiley commented on pull request #2438: URL: https://github.com/apache/lucene-solr/pull/2438#issuecomment-790820910 I review what I commit locally in my IDE tooling. I think IntelliJ does a nice job of this. This is an aut

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295490#comment-17295490 ] David Smiley commented on SOLR-15185: - Okay. Given that most users of this are indir

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295480#comment-17295480 ] Adrien Grand commented on LUCENE-9822: -- I think that the number 3 came from me look

[GitHub] [lucene-solr] sigram opened a new pull request #2453: SOLR-15210: ParallelStream should execute hashing & filtering directly in ExportWriter

2021-03-04 Thread GitBox
sigram opened a new pull request #2453: URL: https://github.com/apache/lucene-solr/pull/2453 See Jira for details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295448#comment-17295448 ] Joel Bernstein commented on SOLR-15185: --- I don't think we need to bother unless you

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295407#comment-17295407 ] David Smiley commented on SOLR-15185: - [~jbernste] can you please recommend CHANGES.t

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295404#comment-17295404 ] Michael McCandless commented on LUCENE-9822: +1, no unit test needed for one

[jira] [Commented] (LUCENE-3320) Explore Proximity Scoring

2021-03-04 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295393#comment-17295393 ] Tomoko Uchida commented on LUCENE-3320: --- Thanks [~mikemccand] for the pointer! I

[jira] [Updated] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Ashbourne updated SOLR-15213: --- Description: Solr has "add", "set", "add-distinct" which work but all have their limitations

[jira] [Comment Edited] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Endika Posadas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295388#comment-17295388 ] Endika Posadas edited comment on SOLR-15213 at 3/4/21, 4:24 PM: ---

[jira] [Comment Edited] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Endika Posadas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295388#comment-17295388 ] Endika Posadas edited comment on SOLR-15213 at 3/4/21, 4:23 PM: ---

[jira] [Commented] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Endika Posadas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295388#comment-17295388 ] Endika Posadas commented on SOLR-15213: --- The problem with directly updating the chi

[jira] [Commented] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295383#comment-17295383 ] James Ashbourne commented on SOLR-15213: [~thomas.woeckinger] you're right '_root

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295367#comment-17295367 ] Robert Muir commented on LUCENE-9822: - Looks good. The single byte assumption remind

[jira] [Comment Edited] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295297#comment-17295297 ] Greg Miller edited comment on LUCENE-9822 at 3/4/21, 3:40 PM:

[jira] [Comment Edited] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295297#comment-17295297 ] Greg Miller edited comment on LUCENE-9822 at 3/4/21, 3:39 PM:

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295358#comment-17295358 ] Bruno Roustant commented on SOLR-15038: --- I reverted this specific line in both mast

[jira] [Updated] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-9822: Attachment: LUCENE-9822.patch > Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295354#comment-17295354 ] ASF subversion and git services commented on SOLR-15038: Commit e

[jira] [Comment Edited] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295323#comment-17295323 ] Thomas Wöckinger edited comment on SOLR-15213 at 3/4/21, 3:04 PM: -

[jira] [Commented] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295323#comment-17295323 ] Thomas Wöckinger commented on SOLR-15213: - You simply update only the child docum

[jira] [Commented] (SOLR-13071) Add JWT Auth support in bin/solr

2021-03-04 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295322#comment-17295322 ] David Eric Pugh commented on SOLR-13071: I've heard of some CLI's that actually p

[jira] [Updated] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Ashbourne updated SOLR-15213: --- Attachment: SOLR-15213.patch > Add support for "merge" atomic update operation for child docu

[jira] [Updated] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Ashbourne updated SOLR-15213: --- Attachment: (was: solr-merge.patch) > Add support for "merge" atomic update operation for

[jira] [Commented] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295297#comment-17295297 ] Greg Miller commented on LUCENE-9822: - I think this is just a one-liner in the PForU

[jira] [Updated] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Ashbourne updated SOLR-15213: --- Description: Solr has "add", "set", "add-distinct" which work but all have their limitations

[jira] [Created] (LUCENE-9822) Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

2021-03-04 Thread Greg Miller (Jira)
Greg Miller created LUCENE-9822: --- Summary: Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil Key: LUCENE-9822 URL: https://issues.apache.org/jira/browse/LUCENE-9822 Project: Luc

[jira] [Updated] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Ashbourne updated SOLR-15213: --- Attachment: solr-merge.patch > Add support for "merge" atomic update operation for child docu

[jira] [Created] (SOLR-15213) Add support for "merge" atomic update operation for child documents

2021-03-04 Thread James Ashbourne (Jira)
James Ashbourne created SOLR-15213: -- Summary: Add support for "merge" atomic update operation for child documents Key: SOLR-15213 URL: https://issues.apache.org/jira/browse/SOLR-15213 Project: Solr

[jira] [Commented] (LUCENE-9406) Make it simpler to track IndexWriter's events

2021-03-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295278#comment-17295278 ] Michael McCandless commented on LUCENE-9406: Should we maybe backport this t

[GitHub] [lucene-solr] mikemccand commented on pull request #2342: LUCENE-9406: Add IndexWriterEventListener to track events in IndexWriter

2021-03-04 Thread GitBox
mikemccand commented on pull request #2342: URL: https://github.com/apache/lucene-solr/pull/2342#issuecomment-790609431 Woops, sorry for the belated response, and thank you @zacharymorn for creating this and @dweiss for merging -- it looks great! We can now add other events to track incre

[GitHub] [lucene-solr] pawel-bugalski-dynatrace commented on a change in pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
pawel-bugalski-dynatrace commented on a change in pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#discussion_r587450225 ## File path: lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java ## @@ -31,18 +31,21 @@ * to the id is encapsulated insi

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
uschindler edited a comment on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790589517 Hi, I agree with Mike. I like the equals() method to be thread safe. That was my original proposal. Generally: BytesRefHash is my favourite class if you need

[GitHub] [lucene-solr] uschindler commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
uschindler commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790589517 Hi, I agree with Mike. I like the equals() method to be thread safe. That was my original proposal. Generally: BytesRefHash is my favourite class if you need a Set.

[GitHub] [lucene-solr] mikemccand commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
mikemccand commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790583058 +1 for changing `equals` to not require allocation, enabling us to remove the thread-unsafe shared `BytesRef scratch1`! This makes `find` thread-safe (as long as no othe

[GitHub] [lucene-solr] iverase commented on pull request #2452: LUCENE-9580: Don't introduce collinear edges when splitting polygon

2021-03-04 Thread GitBox
iverase commented on pull request #2452: URL: https://github.com/apache/lucene-solr/pull/2452#issuecomment-790571887 @nknize would you mind having a look? This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] iverase opened a new pull request #2452: LUCENE-9580: Don't introduce collinear edges when splitting polygon

2021-03-04 Thread GitBox
iverase opened a new pull request #2452: URL: https://github.com/apache/lucene-solr/pull/2452 I had a look into this failing polygon and it seems the issue comes in the logic the splits the polygon for further processing. It might happen that the new edge introduced is collinear with edges

[GitHub] [lucene-solr] donnerpeter commented on pull request #2451: LUCENE-9687: Hunspell suggestions: reduce work in the findSimilarDictionaryEntries loop

2021-03-04 Thread GitBox
donnerpeter commented on pull request #2451: URL: https://github.com/apache/lucene-solr/pull/2451#issuecomment-790570709 Sorry, I couldn't create a separate JIRA issue for this change due to some "XSRF Security Token Missing" error in JIRA -

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2451: LUCENE-9687: Hunspell suggestions: reduce work in the findSimilarDictionaryEntries loop

2021-03-04 Thread GitBox
donnerpeter opened a new pull request #2451: URL: https://github.com/apache/lucene-solr/pull/2451 # Description The loop is called a lot of times, and some allocations and method calls can be spared # Solution Extract some code outside the loop # Test

[GitHub] [lucene-solr] rmuir commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
rmuir commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790554086 Just to emphasize it even more, this class is marked `@lucene.internal`. The class shouldn't even be exposed to the outside in the public API to start with, so let's please no

[GitHub] [lucene-solr] rmuir commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
rmuir commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790551382 I still don't like the unmodifiable-interface. Sorry, I disagree with exposing thread-safe methods officially in the API for class that should only be used by one thread, just

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295207#comment-17295207 ] Dawid Weiss commented on SOLR-15038: Hi Bruno. No, I've no idea... I think the goal w

[jira] [Comment Edited] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295203#comment-17295203 ] Bruno Roustant edited comment on SOLR-15038 at 3/4/21, 10:37 AM: --

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295203#comment-17295203 ] Bruno Roustant commented on SOLR-15038: --- Ouch, yes I'll revert that. I played with

[GitHub] [lucene-solr] pawel-bugalski-dynatrace commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-04 Thread GitBox
pawel-bugalski-dynatrace commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-790467163 @rmuir @madrob what do you think about current state of this PR? Any more comments? What else needs to be done to merge it? ---

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295083#comment-17295083 ] Dawid Weiss commented on SOLR-15038: This change introduced write-access to sources:

[jira] [Updated] (SOLR-14759) Separate the Lucene and Solr builds

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14759: --- Description: While still in same git repo, separate the builds, so Lucene and Solr can be built inde

[jira] [Updated] (SOLR-14759) Separate the Lucene and Solr builds

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14759: --- Description: While still in same git repo, separate the builds, so Lucene and Solr can be built inde

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2021-03-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295076#comment-17295076 ] Dawid Weiss commented on SOLR-14759: Current status will be tracked at the main issue

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2448: SOLR-14759: a few initial changes so that Lucene can be built independently while Solr code is still in place.

2021-03-04 Thread GitBox
dweiss commented on a change in pull request #2448: URL: https://github.com/apache/lucene-solr/pull/2448#discussion_r587241698 ## File path: gradle/documentation/documentation.gradle ## @@ -20,34 +20,41 @@ configure(rootProject) { def refguideUrlVersion = project.baseVersio