[ 
https://issues.apache.org/jira/browse/LUCENE-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295297#comment-17295297
 ] 

Greg Miller edited comment on LUCENE-9822 at 3/4/21, 3:39 PM:
--------------------------------------------------------------

I think this is just a one-liner in the PForUtil ctor. Patch uploaded.


was (Author: gsmiller):
I think this is just a one-liner in the PForUtil ctor. I'll attach a patch 
shortly.

> Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-9822
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9822
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/codecs
>    Affects Versions: master (9.0)
>            Reporter: Greg Miller
>            Priority: Trivial
>         Attachments: LUCENE-9822.patch
>
>
> PForUtil assumes that ForUtil.BLOCK_SIZE can be encoded in a single byte when 
> generating "patch offsets". If this assumption doesn't hold, PForUtil will 
> silently encode incorrect positions. While the BLOCK_SIZE isn't particularly 
> configurable, it would be nice to assert this assumption early in PForUtil in 
> the even that the BLOCK_SIZE changes in some future codec version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to