[GitHub] [lucene-solr] zhaih commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r565026524 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -736,49 +736,92 @@ private void doAddSortedFi

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: WIP: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-26 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r564970251 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-26 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272507#comment-17272507 ] Julie Tibshirani commented on LUCENE-9616: -- Would we be okay 'formalizing' this

[GitHub] [lucene-solr] mikemccand commented on pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
mikemccand commented on pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#issuecomment-767910776 > This is a good idea, it took some digging to understand what the process/ strategy was. I'll plan to add some docs. Thanks @jtibshirani! ---

[jira] [Updated] (SOLR-14330) Return docs with null value in expand for field when collapse has nullPolicy=collapse

2021-01-26 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14330: -- Attachment: SOLR-14330.patch Status: Open (was: Open) Updated patch to include

[jira] [Commented] (SOLR-14216) Exclude HealthCheck from authentication

2021-01-26 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272456#comment-17272456 ] Anshum Gupta commented on SOLR-14216: - After having thought more about this, and real

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2021-01-26 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270442#comment-17270442 ] Isabelle Giguere edited comment on SOLR-14886 at 1/26/21, 9:04 PM:

[jira] [Commented] (SOLR-15089) Allow backup/restoration to Amazon's S3 blobstore

2021-01-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272412#comment-17272412 ] Jason Gerlowski commented on SOLR-15089: Yeah, it'll be awesome to get in. In te

[jira] [Comment Edited] (SOLR-15089) Allow backup/restoration to Amazon's S3 blobstore

2021-01-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272412#comment-17272412 ] Jason Gerlowski edited comment on SOLR-15089 at 1/26/21, 8:51 PM: -

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2250: SOLR-13608: Incremental backup file format

2021-01-26 Thread GitBox
muse-dev[bot] commented on a change in pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250#discussion_r564804612 ## File path: solr/core/src/java/org/apache/solr/core/backup/ShardBackupMetadata.java ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Softw

[jira] [Updated] (SOLR-15110) Get the date/time functions working in Solr SQL

2021-01-26 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15110: -- Description: Currently the following SQL query throws errors in Solr SQL: {code} SELECT WEEK(s

[jira] [Created] (SOLR-15110) Get the date/time functions working in Solr SQL

2021-01-26 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-15110: - Summary: Get the date/time functions working in Solr SQL Key: SOLR-15110 URL: https://issues.apache.org/jira/browse/SOLR-15110 Project: Solr Issue Type: Im

[jira] [Assigned] (SOLR-15109) Optimize shard splitByPrefix logic to reduce number of splits required

2021-01-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-15109: --- Component/s: SolrCloud Assignee: David Smiley Summary: Optimize shard splitByP

[jira] [Created] (SOLR-15109) Optimize splitByPrefix logic to reduce number of splits required

2021-01-26 Thread Megan Carey (Jira)
Megan Carey created SOLR-15109: -- Summary: Optimize splitByPrefix logic to reduce number of splits required Key: SOLR-15109 URL: https://issues.apache.org/jira/browse/SOLR-15109 Project: Solr Is

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-01-26 Thread GitBox
dsmiley commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r564755969 ## File path: solr/core/src/test/org/apache/solr/handler/admin/AdminHandlersProxyTest.java ## @@ -41,7 +46,9 @@ public class AdminHandlersProxyTest

[jira] [Commented] (SOLR-13608) Incremental backup for Solr

2021-01-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272341#comment-17272341 ] Jason Gerlowski commented on SOLR-13608: I've uploaded a [PR|https://github.com/a

[GitHub] [lucene-solr] gerlowskija closed pull request #763: SOLR-13608: Incremental backup for Solr

2021-01-26 Thread GitBox
gerlowskija closed pull request #763: URL: https://github.com/apache/lucene-solr/pull/763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] gerlowskija commented on pull request #763: SOLR-13608: Incremental backup for Solr

2021-01-26 Thread GitBox
gerlowskija commented on pull request #763: URL: https://github.com/apache/lucene-solr/pull/763#issuecomment-767748439 This PR has fallen out of date, especially with some of the review feedback drawn out during the SIP-12 discussion process. I'm going to close this in favor of moving for

[GitHub] [lucene-solr] gerlowskija opened a new pull request #2250: SOLR-13608: Incremental backup file format

2021-01-26 Thread GitBox
gerlowskija opened a new pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250 # Description This PR introduces a new way for Solr to do backups (with a new underlying file structure). This new "incremental" backup process improves over the existing backup me

[jira] [Commented] (SOLR-15075) Remove the Docker Gradle plugin dependency and solr/docker/package module

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272322#comment-17272322 ] ASF subversion and git services commented on SOLR-15075: Commit 7

[GitHub] [lucene-solr] shaie commented on a change in pull request #2247: WIP: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-26 Thread GitBox
shaie commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r564721526 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public FacetLabel

[jira] [Commented] (SOLR-14700) CloudSolrClient cannot be used without setting an explicit streamContext

2021-01-26 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272306#comment-17272306 ] Joel Bernstein commented on SOLR-14700: --- I just wanted to comment on this. At thi

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272303#comment-17272303 ] ASF subversion and git services commented on LUCENE-9322: - Commi

[GitHub] [lucene-solr] jtibshirani merged pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
jtibshirani merged pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] jtibshirani commented on pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
jtibshirani commented on pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#issuecomment-767730507 > I feel like we need some simple "best practices" documentation somewhere on how to bring new Codec/XXXFormats into existence, where/when to move the old ones etc.

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
jtibshirani commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564726130 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/TestLucene60FieldInfosFormat.java ## @@ -14,17 +14,15 @@

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564725198 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564724657 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564723593 ## File path: lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexRearranger.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] megancarey closed pull request #2091: Jira/solr 14778

2021-01-26 Thread GitBox
megancarey closed pull request #2091: URL: https://github.com/apache/lucene-solr/pull/2091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564718926 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564717618 ## File path: lucene/CHANGES.txt ## @@ -11,6 +11,8 @@ New Features * LUCENE-9004: Approximate nearest vector search via NSW graphs +* LUCENE-9694:

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-26 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272291#comment-17272291 ] Haoyu Zhai commented on LUCENE-9694: Oh I didn't include that since I want to keep i

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #202: Update helm docs, and add link to new artifactHub.

2021-01-26 Thread GitBox
HoustonPutman opened a new pull request #202: URL: https://github.com/apache/lucene-solr-operator/pull/202 A part of #183 . This is a stable artifactHub location, and will not change whenever the repo moves. The artifactHub will also contain the docs for released Helm chart im

[GitHub] [lucene-solr] mikemccand commented on pull request #2097: LUCENE-9537

2021-01-26 Thread GitBox
mikemccand commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-767646296 > I have added an entry in CHANGES.txt under API changes. Thank you! I ran top-level `./gradlew test` with this change but hit this Solr test failure, caused

[jira] [Resolved] (SOLR-15075) Remove the Docker Gradle plugin dependency and solr/docker/package module

2021-01-26 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15075. --- Fix Version/s: master (9.0) Assignee: Houston Putman Resolution: Fixed > Remo

[GitHub] [lucene-solr-operator] HoustonPutman edited a comment on pull request #200: Apachify the solr-operator helm chart

2021-01-26 Thread GitBox
HoustonPutman edited a comment on pull request #200: URL: https://github.com/apache/lucene-solr-operator/pull/200#issuecomment-767626466 @vladiceanu , there is a new entry in artifactHub for the Solr Operator (which is verified and official) https://artifacthub.io/packages/helm/apache-sol

[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #200: Apachify the solr-operator helm chart

2021-01-26 Thread GitBox
HoustonPutman commented on pull request #200: URL: https://github.com/apache/lucene-solr-operator/pull/200#issuecomment-767626466 @vladiceanu , there is a new entry in artifactHub for the Solr Operator (which is verified and official) https://artifacthub.io/packages/helm/apache-solr/solr-

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2197: SOLR-15075: Solr docker gradle improvements

2021-01-26 Thread GitBox
HoustonPutman commented on a change in pull request #2197: URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r564598544 ## File path: solr/docker/build.gradle ## @@ -18,106 +18,192 @@ import com.google.common.base.Preconditions import com.google.common.base.Stri

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2197: SOLR-15075: Solr docker gradle improvements

2021-01-26 Thread GitBox
HoustonPutman commented on a change in pull request #2197: URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r564598544 ## File path: solr/docker/build.gradle ## @@ -18,106 +18,192 @@ import com.google.common.base.Preconditions import com.google.common.base.Stri

[jira] [Commented] (SOLR-15075) Remove the Docker Gradle plugin dependency and solr/docker/package module

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272162#comment-17272162 ] ASF subversion and git services commented on SOLR-15075: Commit 2

[GitHub] [lucene-solr] HoustonPutman merged pull request #2197: SOLR-15075: Solr docker gradle improvements

2021-01-26 Thread GitBox
HoustonPutman merged pull request #2197: URL: https://github.com/apache/lucene-solr/pull/2197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (SOLR-15068) RefGuide documentation for replica placement plugins

2021-01-26 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15068: Fix Version/s: master (9.0) > RefGuide documentation for replica placement plugins > --

[jira] [Commented] (SOLR-15055) Re-implement 'withCollection'

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272156#comment-17272156 ] ASF subversion and git services commented on SOLR-15055: Commit 6

[GitHub] [lucene-solr] sigram closed pull request #2199: SOLR-15055 (Take 2) Re-implement 'withCollection'

2021-01-26 Thread GitBox
sigram closed pull request #2199: URL: https://github.com/apache/lucene-solr/pull/2199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (SOLR-15055) Re-implement 'withCollection'

2021-01-26 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15055. - Fix Version/s: master (9.0) Resolution: Fixed > Re-implement 'withCollection' > --

[jira] [Commented] (LUCENE-9670) gradle precommit sometimes fails with "IOException: stream closed" from javadoc in nightly benchmarks

2021-01-26 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272133#comment-17272133 ] Michael McCandless commented on LUCENE-9670: {quote}All test settings can be

[jira] [Commented] (LUCENE-9696) RegExp with group references

2021-01-26 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272129#comment-17272129 ] Michael McCandless commented on LUCENE-9696: Thanks [~gus]!  We could separa

[GitHub] [lucene-solr] mikemccand commented on pull request #2240: LUCENE-9575 Provide a producer for PatternTypingRule in TestRandomChains

2021-01-26 Thread GitBox
mikemccand commented on pull request #2240: URL: https://github.com/apache/lucene-solr/pull/2240#issuecomment-767579194 Phew, OK thanks for the explanation @gus-asf! And thanks for fixing the failing seed so quickly :) This

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
mikemccand commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564552680 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ pri

[GitHub] [lucene-solr] iverase commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
iverase commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564545408 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ privat

[GitHub] [lucene-solr] iverase commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
iverase commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564545408 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ privat

[jira] [Commented] (SOLR-15055) Re-implement 'withCollection'

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272118#comment-17272118 ] ASF subversion and git services commented on SOLR-15055: Commit 6

[jira] [Updated] (SOLR-15055) Re-implement 'withCollection'

2021-01-26 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15055: Summary: Re-implement 'withCollection' (was: Re-implement 'withCollection' and 'maxShardsP

[jira] [Updated] (SOLR-15055) Re-implement 'withCollection'

2021-01-26 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15055: Description: Solr 8x replica placement provided two settings that are very useful in certai

[GitHub] [lucene-solr] gus-asf commented on pull request #2240: LUCENE-9575 Provide a producer for PatternTypingRule in TestRandomChains

2021-01-26 Thread GitBox
gus-asf commented on pull request #2240: URL: https://github.com/apache/lucene-solr/pull/2240#issuecomment-767565359 While the build (github action) was running for this PR, @jimczi applied a quick fix directly. Though github would have happily merged this PR that would have left two produ

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
mikemccand commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564519920 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/TestLucene60FieldInfosFormat.java ## @@ -14,17 +14,15 @@

[GitHub] [lucene-solr] mikemccand commented on pull request #2240: LUCENE-9575 Provide a producer for PatternTypingRule in TestRandomChains

2021-01-26 Thread GitBox
mikemccand commented on pull request #2240: URL: https://github.com/apache/lucene-solr/pull/2240#issuecomment-767549037 > need to remake to account for quickfix. What does that mean? This is an automated message from t

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2247: WIP: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-26 Thread GitBox
mikemccand commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r564505813 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -314,7 +316,6 @@ public int getO

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-26 Thread GitBox
mikemccand commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r564484147 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-767522530 @bruno-roustant I've updated the patch according to your comments, thanks a lot:) This is an automated mes

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2249: LUCENE-9700: Hunspell: support words with trailing dots

2021-01-26 Thread GitBox
donnerpeter opened a new pull request #2249: URL: https://github.com/apache/lucene-solr/pull/2249 # Description Hunspell/C++ has some special treatment for abbreviations # Solution Mimic the same behavior: remove all trailing dots and stem the word without a

[jira] [Created] (LUCENE-9700) Hunspell: support words with trailing dots

2021-01-26 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9700: Summary: Hunspell: support words with trailing dots Key: LUCENE-9700 URL: https://issues.apache.org/jira/browse/LUCENE-9700 Project: Lucene - Core Issue Type

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2248: LUCENE-9699: Support German-like compound words

2021-01-26 Thread GitBox
donnerpeter opened a new pull request #2248: URL: https://github.com/apache/lucene-solr/pull/2248 # Description German compounds are complicated and need to be supported by Hunspell. # Solution * Supported affix file options like COMPOUNDBEGIN, COMPOUNDMIDDLE

[jira] [Created] (LUCENE-9699) Support German-like compound words

2021-01-26 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9699: Summary: Support German-like compound words Key: LUCENE-9699 URL: https://issues.apache.org/jira/browse/LUCENE-9699 Project: Lucene - Core Issue Type: Sub-ta

[jira] [Resolved] (LUCENE-9698) Hunspell: reuse char[] when possible when stripping affix

2021-01-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9698. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: reuse char[] when possible when

[jira] [Commented] (LUCENE-9698) Hunspell: reuse char[] when possible when stripping affix

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272063#comment-17272063 ] ASF subversion and git services commented on LUCENE-9698: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #2243: LUCENE-9698: Hunspell: reuse char[] when possible when stripping affix

2021-01-26 Thread GitBox
dweiss merged pull request #2243: URL: https://github.com/apache/lucene-solr/pull/2243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] iverase commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

2021-01-26 Thread GitBox
iverase commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564450316 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ privat

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2243: LUCENE-9698: Hunspell: reuse char[] when possible when stripping affix

2021-01-26 Thread GitBox
donnerpeter commented on a change in pull request #2243: URL: https://github.com/apache/lucene-solr/pull/2243#discussion_r564429159 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -403,7 +408,12 @@ private CharsRef newStem(c

[GitHub] [lucene-solr] sigram commented on a change in pull request #2199: SOLR-15055 (Take 2) Re-implement 'withCollection'

2021-01-26 Thread GitBox
sigram commented on a change in pull request #2199: URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r564426476 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -467,7 +569,7 @@ private void makePlace

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2199: SOLR-15055 (Take 2) Re-implement 'withCollection'

2021-01-26 Thread GitBox
murblanc commented on a change in pull request #2199: URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r564413143 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -238,11 +258,93 @@ public PlacementPl

[GitHub] [lucene-solr] sigram commented on a change in pull request #2199: SOLR-15055 (Take 2) Re-implement 'withCollection'

2021-01-26 Thread GitBox
sigram commented on a change in pull request #2199: URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r564405099 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -238,11 +258,93 @@ public PlacementPlan

[jira] [Commented] (SOLR-14251) Shard Split on HDFS

2021-01-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271984#comment-17271984 ] Gézapeti commented on SOLR-14251: - [~mdrob] what do you think about this workaround? > S

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2243: LUCENE-9698: Hunspell: reuse char[] when possible when stripping affix

2021-01-26 Thread GitBox
dweiss commented on a change in pull request #2243: URL: https://github.com/apache/lucene-solr/pull/2243#discussion_r564331661 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -403,7 +408,12 @@ private CharsRef newStem(char[]

[jira] [Commented] (LUCENE-9697) Hunspell Stemmer: use the same FST.BytesReader on all recursion levels

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271967#comment-17271967 ] ASF subversion and git services commented on LUCENE-9697: - Commi

[jira] [Resolved] (LUCENE-9697) Hunspell Stemmer: use the same FST.BytesReader on all recursion levels

2021-01-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9697. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell Stemmer: use the same FST.BytesR

[GitHub] [lucene-solr] dweiss merged pull request #2242: LUCENE-9697: Hunspell Stemmer: use the same FST.BytesReader on all recursion levels

2021-01-26 Thread GitBox
dweiss merged pull request #2242: URL: https://github.com/apache/lucene-solr/pull/2242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9693) Hunspell: check that all flags are > 0 and fit char

2021-01-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9693. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: check that all flags are > 0 an

[jira] [Commented] (LUCENE-9693) Hunspell: check that all flags are > 0 and fit char

2021-01-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271965#comment-17271965 ] ASF subversion and git services commented on LUCENE-9693: - Commi

[jira] [Updated] (LUCENE-9687) Hunspell support improvements

2021-01-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9687: Fix Version/s: master (9.0) > Hunspell support improvements > - > >

[GitHub] [lucene-solr] dweiss merged pull request #2238: LUCENE-9693: Hunspell: check that all flags are > 0 and fit char range

2021-01-26 Thread GitBox
dweiss merged pull request #2238: URL: https://github.com/apache/lucene-solr/pull/2238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss closed pull request #2238: LUCENE-9693: Hunspell: check that all flags are > 0 and fit char range

2021-01-26 Thread GitBox
dweiss closed pull request #2238: URL: https://github.com/apache/lucene-solr/pull/2238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271961#comment-17271961 ] Dawid Weiss commented on LUCENE-9694: - But this "index map" is not part of the pull

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r564319900 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r564318463 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java ## @@ -280,12 +275,25 @@ private SortedSetEntry

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r564317038 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r564311781 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -962,6 +1078,21 @@ public SortedDocValues

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-26 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r564272513 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi