[jira] [Updated] (SOLR-15048) collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector

2021-01-04 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15048: -- Attachment: SOLR-15048.patch Status: Open (was: Open) Patch with a lot of dedu

[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

2021-01-04 Thread Elbek Kamoliddinov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258638#comment-17258638 ] Elbek Kamoliddinov commented on LUCENE-9640: Thanks Mike. {{QueryCache}} see

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2021-01-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258633#comment-17258633 ] Jason Gerlowski commented on SOLR-15051: bq. In Solr we have a "BackupRepository"

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754304561 This would also explain slowdowns on *short* posting-list iterations, as readLELongs() with smaller number of longs is not working well. My plan would be to

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754304561 This would also explain slowdowns on *short* posting-list iterations, as readLELongs() with smaller number of longs is not working well. My plan would be to do an i

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754302399 > No, the floats are read using readBytes() into a ByteBuffer and then converted using a derived FloatBuffer. So I think your intuition about readBytes() is correct?

[GitHub] [lucene-solr] msokolov commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
msokolov commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754300727 > Just to clarify: In your code, you are reading the floats with a series of readInt() from the indexinput, converting them to float? No, the floats are read using `r

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754299385 Hi @msokolov, thanks for the speed test - I wanted to wait for the specialists to do it. As said before, we should report slowness (or improvements) to the Hot

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754299385 Hi @msokolov, thanks for the speed test - I wanted to wait for the specialists to do it. As said before, we should report slowness (or improvements) to the Hot

[GitHub] [lucene-solr] msokolov commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
msokolov commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754299548 I ran benchmarks one more time, including vector tasks: ``` TaskQPS baseline StdDevQPS candidate StdDev Pct diff p-val

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754299385 Hi @msokolov, thanks for the speed test - I wanted to wait for the specialists to do it. As said before, we should report slowness (or improvements) to the Hotpsot/Op

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-04 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r551633302 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ## @@ -1365,6 +1382,32 @@ public void refreshAndWatch() {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-04 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r551631340 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ## @@ -1365,6 +1382,32 @@ public void refreshAndWatch() {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-04 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r551625950 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -292,7 +346,9 @@ public boolean isReadOnly() { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-04 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r551623735 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -253,6 +297,16 @@ public void forEachReplica(BiConsumer cons

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-04 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r551623207 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -165,6 +205,8 @@ public static Object verifyProp(Map props,

[jira] [Comment Edited] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2021-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254118#comment-17254118 ] Thomas Wöckinger edited comment on SOLR-14923 at 1/4/21, 10:28 PM:

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258532#comment-17258532 ] Erick Erickson commented on LUCENE-9570: I don't know what's happening with my c

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2153: LUCENE-9570: A non-mergable PR with reformatted code.

2021-01-04 Thread GitBox
muse-dev[bot] commented on a change in pull request #2153: URL: https://github.com/apache/lucene-solr/pull/2153#discussion_r551547661 ## File path: lucene/suggest/src/java/org/apache/lucene/search/suggest/fst/FSTCompletionLookup.java ## @@ -305,20 +298,25 @@ public synchronize

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2021-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258466#comment-17258466 ] Kevin Risden commented on SOLR-15051: - {quote}"Hadoop filesystem interface" is an ide

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Commented] (SOLR-9864) SolrQuery.getCopy() doesn't copy sortClauses

2021-01-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258443#comment-17258443 ] Jason Gerlowski commented on SOLR-9864: --- bq. if there is any chance of this getting

[jira] [Assigned] (SOLR-9864) SolrQuery.getCopy() doesn't copy sortClauses

2021-01-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-9864: - Assignee: Jason Gerlowski > SolrQuery.getCopy() doesn't copy sortClauses > --

[jira] [Comment Edited] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258436#comment-17258436 ] Dawid Weiss edited comment on LUCENE-9570 at 1/4/21, 7:19 PM:

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258436#comment-17258436 ] Dawid Weiss commented on LUCENE-9570: - ECJ bug discovered. This javadoc: {code} * Y

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Created] (LUCENE-9657) Unified Highlighter throws too_complex_to_determinize_exception with >288 filter terms

2021-01-04 Thread Isaac Doub (Jira)
Isaac Doub created LUCENE-9657: -- Summary: Unified Highlighter throws too_complex_to_determinize_exception with >288 filter terms Key: LUCENE-9657 URL: https://issues.apache.org/jira/browse/LUCENE-9657 Pr

[GitHub] [lucene-solr] msokolov edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
msokolov edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754153605 I ran some vector search performance tests even though this isn't probably the most representative test, but since I have been running these for other reasons lately

[GitHub] [lucene-solr] msokolov commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
msokolov commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754153605 I ran some vector search performance tests even though this isn't probably the most representative test, but since I have been running these for other reasons lately and I'

[GitHub] [lucene-solr] msokolov edited a comment on pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-04 Thread GitBox
msokolov edited a comment on pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-754152942 > IMHO, as this is little endian, we should name the new method like the long one. Fair enough; I'll post an update soon. ---

[GitHub] [lucene-solr] msokolov commented on pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-04 Thread GitBox
msokolov commented on pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-754152942 > IMHO, as this is little endian, we should name the new method like the long one. Fair enough; I'll post an update soon. --

[jira] [Updated] (SOLR-15061) Fix NPE in SearchHandler when shards.info

2021-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15061: Priority: Minor (was: Major) > Fix NPE in SearchHandler when shards.info > ---

[jira] [Created] (SOLR-15067) Child doc transformer should use the perSegFilter cache

2021-01-04 Thread David Smiley (Jira)
David Smiley created SOLR-15067: --- Summary: Child doc transformer should use the perSegFilter cache Key: SOLR-15067 URL: https://issues.apache.org/jira/browse/SOLR-15067 Project: Solr Issue Type

[jira] [Assigned] (LUCENE-9655) Add code regeneration for generateEmojiTokenizationTest.pl

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-9655: --- Assignee: Dawid Weiss > Add code regeneration for generateEmojiTokenizationTest.pl > --

[jira] [Created] (LUCENE-9656) Add code regeneration for generateJavaUnicodeWordBreakTest.pl

2021-01-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9656: --- Summary: Add code regeneration for generateJavaUnicodeWordBreakTest.pl Key: LUCENE-9656 URL: https://issues.apache.org/jira/browse/LUCENE-9656 Project: Lucene - Core

[jira] [Created] (LUCENE-9655) Add code regeneration for generateEmojiTokenizationTest.pl

2021-01-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9655: --- Summary: Add code regeneration for generateEmojiTokenizationTest.pl Key: LUCENE-9655 URL: https://issues.apache.org/jira/browse/LUCENE-9655 Project: Lucene - Core

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258377#comment-17258377 ] Erick Erickson commented on LUCENE-9570: Missed the commit message for grouping:

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Commented] (SOLR-15055) Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258370#comment-17258370 ] Andrzej Bialecki commented on SOLR-15055: - Additional notes on how {{withCollecti

[jira] [Assigned] (SOLR-14977) Container plugins need a way to be configured

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-14977: --- Assignee: Andrzej Bialecki > Container plugins need a way to be configured > ---

[jira] [Resolved] (SOLR-14977) Container plugins need a way to be configured

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14977. - Resolution: Fixed > Container plugins need a way to be configured > -

[jira] [Updated] (SOLR-14977) Container plugins need a way to be configured

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14977: Fix Version/s: master (9.0) > Container plugins need a way to be configured > -

[jira] [Resolved] (SOLR-15004) Unit tests for the replica placement API

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15004. - Resolution: Fixed > Unit tests for the replica placement API > --

[jira] [Updated] (SOLR-15004) Unit tests for the replica placement API

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15004: Fix Version/s: master (9.0) > Unit tests for the replica placement API > --

[jira] [Updated] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15019: Fix Version/s: master (9.0) > Replica placement API needs a way to fetch existing replica m

[jira] [Resolved] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15019. - Resolution: Fixed > Replica placement API needs a way to fetch existing replica metrics >

[jira] [Assigned] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2021-01-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-15019: --- Assignee: Andrzej Bialecki > Replica placement API needs a way to fetch existing rep

[jira] [Commented] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2021-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258313#comment-17258313 ] ASF subversion and git services commented on SOLR-15019: Commit 2

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2168: SOLR-15061: Fix NPE in SearchHandler when shards.info

2021-01-04 Thread GitBox
bruno-roustant commented on a change in pull request #2168: URL: https://github.com/apache/lucene-solr/pull/2168#discussion_r551404606 ## File path: solr/CHANGES.txt ## @@ -273,6 +273,8 @@ Bug Fixes * SOLR-15031: Fix preventing null being wrapped in a QueryValueSource subQuer

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2021-01-04 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258224#comment-17258224 ] David Eric Pugh commented on SOLR-14923: I got bit recently in upgrading to newer

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2168: SOLR-15061: Fix NPE in SearchHandler when shards.info

2021-01-04 Thread GitBox
dsmiley commented on a change in pull request #2168: URL: https://github.com/apache/lucene-solr/pull/2168#discussion_r551332470 ## File path: solr/CHANGES.txt ## @@ -273,6 +273,8 @@ Bug Fixes * SOLR-15031: Fix preventing null being wrapped in a QueryValueSource subQuery. Such

[jira] [Commented] (SOLR-14265) Move collections admin API to v2 completely

2021-01-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258214#comment-17258214 ] Jason Gerlowski commented on SOLR-14265: bq. The only thing I have is a doc from

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Commented] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2021-01-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258142#comment-17258142 ] Bruno Roustant commented on LUCENE-9646: I see that ClassicSimilarity constructo

[GitHub] [lucene-solr] uschindler commented on pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-04 Thread GitBox
uschindler commented on pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-753904835 IMHO, as this is little endian, we should name the new method like the long one. After we have changed everything to little endian we may change nsming, but as of now

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551208675 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review commen

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551208675 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review commen

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551202560 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551198238 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551197902 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551196614 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551196614 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551195154 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review commen

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551194238 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551193422 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551193215 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review comment:

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
uschindler commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551191931 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review commen

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Resolved] (LUCENE-9642) TestXYShapeEncoding.testRandomPolygonEncoding failure

2021-01-04 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9642. -- Fix Version/s: 8.8 Assignee: Ignacio Vera Resolution: Fixed > TestXYShapeEncod

[jira] [Commented] (LUCENE-9642) TestXYShapeEncoding.testRandomPolygonEncoding failure

2021-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258069#comment-17258069 ] ASF subversion and git services commented on LUCENE-9642: - Commi

[jira] [Commented] (LUCENE-9642) TestXYShapeEncoding.testRandomPolygonEncoding failure

2021-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258067#comment-17258067 ] ASF subversion and git services commented on LUCENE-9642: - Commi

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551179881 ## File path: gradle/defaults-java.gradle ## @@ -60,3 +60,14 @@ allprojects { } } } + +configure(project(":lucene:core")) { Review comment:

[GitHub] [lucene-solr] iverase merged pull request #2154: LUCENE-9642: Rotate triangle points before checking triangle orientation

2021-01-04 Thread GitBox
iverase merged pull request #2154: URL: https://github.com/apache/lucene-solr/pull/2154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-04 Thread GitBox
dweiss commented on a change in pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r551179303 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] dweiss commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2021-01-04 Thread GitBox
dweiss commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-753838406 Thanks @zacharymorn ! This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Created] (SOLR-15066) DocBasedVersionConstraintsProcessor should only fetch the fields it needs from RTG

2021-01-04 Thread David Smiley (Jira)
David Smiley created SOLR-15066: --- Summary: DocBasedVersionConstraintsProcessor should only fetch the fields it needs from RTG Key: SOLR-15066 URL: https://issues.apache.org/jira/browse/SOLR-15066 Projec

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2021-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258050#comment-17258050 ] David Smiley commented on SOLR-14923: - I've been *obsessed* with this issue over the