[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255838#comment-17255838
]
Dawid Weiss commented on LUCENE-9650:
-
Sure. Remember you can still compile/test wit
tflobbe commented on pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-751963271
For `TestSolr4Spatial2`, I think you just need to add [this
line](https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/search/TestSolr4Spatial
noblepaul opened a new pull request #2172:
URL: https://github.com/apache/lucene-solr/pull/2172
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
tflobbe commented on a change in pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#discussion_r549576007
##
File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-caching.xml
##
@@ -21,19 +21,16 @@
Review comment:
Could
[
https://issues.apache.org/jira/browse/SOLR-15062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-15062:
--
Description:
{{GET
http://localhost:8983/api/cluster/zk/ls/collections/gettingstarted/state.json}}
{c
Noble Paul created SOLR-15062:
-
Summary: /api/cluster/zk/ls should give the stat of the current
node
Key: SOLR-15062
URL: https://issues.apache.org/jira/browse/SOLR-15062
Project: Solr
Issue Typ
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-751925231
Hi @uschindler, I will have some time in the next few days. Do you mind me
taking a look at what's left here and potentially pushing some changes? Don't
want to get in t
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545859
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -271,6 +280,19 @@ public boolean matches() throws IOException {
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545837
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -130,10 +130,19 @@ private static long scaleMinScore(float minSc
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545575
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -130,10 +130,19 @@ private static long scaleMinScore(float minSc
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545541
##
File path:
lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java
##
@@ -195,10 +201,13 @@ private Scorer opt(Collection op
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549541668
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -179,17 +181,19 @@ void runLeaderProcess(boolean w
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549539576
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
##
@@ -70,16 +75,24 @@
* cluster and it's state should be discarde
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549522964
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
##
@@ -70,16 +75,24 @@
* cluster and it's state should be discard
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549519765
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -256,6 +263,12 @@ private static DocCollection collectionFro
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549516577
##
File path: solr/core/src/java/org/apache/solr/cloud/overseer/SliceMutator.java
##
@@ -132,7 +160,7 @@ public ZkWriteCommand setShardLeader(Clust
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549506465
##
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##
@@ -107,7 +111,21 @@ public ZkWriteCommand modifyCollect
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549506465
##
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##
@@ -107,7 +111,21 @@ public ZkWriteCommand modifyCollect
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9650.
---
Fix Version/s: master (9.0)
Assignee: Dawid Weiss
Resolution: Fixed
Thanks f
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255736#comment-17255736
]
Uwe Schindler commented on LUCENE-9650:
---
Hi,
I tried it locally and it worked fine
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255735#comment-17255735
]
ASF subversion and git services commented on LUCENE-9650:
-
Commi
uschindler merged pull request #2171:
URL: https://github.com/apache/lucene-solr/pull/2171
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler commented on pull request #2171:
URL: https://github.com/apache/lucene-solr/pull/2171#issuecomment-751881688
Hi, this works fine for me locally:
```
> gradlew compileJava -Druntime.java.home=/path/to/jdk-16
To honour the JVM settings for this build a new JVM will be forke
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549503500
##
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##
@@ -1609,12 +1611,41 @@ public void publish(final CoreDescriptor cd, fi
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549502516
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -179,17 +181,19 @@ void runLeaderProcess(boolean
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255722#comment-17255722
]
Dawid Weiss commented on LUCENE-9650:
-
Maybe you're right. I filed a PR. Please merg
dweiss opened a new pull request #2171:
URL: https://github.com/apache/lucene-solr/pull/2171
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255710#comment-17255710
]
ASF subversion and git services commented on SOLR-14608:
Commit 4
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549331687
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,587 @@
+/*
+ * Licensed to the Apache Software F
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549329497
##
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##
@@ -73,6 +79,29 @@ public void teardown() {
System.clearPr
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255542#comment-17255542
]
Uwe Schindler commented on LUCENE-9650:
---
As said, if an update helps, it would be
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255535#comment-17255535
]
Dawid Weiss commented on LUCENE-9650:
-
An update of errorprone would be the simplest
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255532#comment-17255532
]
ASF subversion and git services commented on LUCENE-9570:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255531#comment-17255531
]
ASF subversion and git services commented on LUCENE-9570:
-
Commi
Uwe Schindler created LUCENE-9650:
-
Summary: Errorprone on master/gradle no longer works with JDK-16
Key: LUCENE-9650
URL: https://issues.apache.org/jira/browse/LUCENE-9650
Project: Lucene - Core
Dawid Weiss created LUCENE-9649:
---
Summary: GenerateJflexTLDMacros regeneration missing
Key: LUCENE-9649
URL: https://issues.apache.org/jira/browse/LUCENE-9649
Project: Lucene - Core
Issue Type:
39 matches
Mail list logo
