megancarey commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549516577
########## File path: solr/core/src/java/org/apache/solr/cloud/overseer/SliceMutator.java ########## @@ -132,7 +160,7 @@ public ZkWriteCommand setShardLeader(ClusterState clusterState, ZkNodeProps mess if (replica == oldLeader && !coreURL.equals(leaderUrl)) { replica = new ReplicaMutator(cloudManager).unsetLeader(replica); } else if (coreURL.equals(leaderUrl)) { - replica = new ReplicaMutator(cloudManager).setLeader(replica); + newLeader= replica = new ReplicaMutator(cloudManager).setLeader(replica); Review comment: Supernit: `newLeader =` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org