[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-10-23 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220001#comment-17220001 ] John Gallagher commented on SOLR-14413: --- [~bvd] the issue was with an assumption th

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-10-23 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: SOLR-14413-jg-update3.patch > allow timeAllowed and cursorMark parameters > ---

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-10-23 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: Screen Shot 2020-10-23 at 10.09.11 PM.png > allow timeAllowed and cursorMark parame

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-10-23 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: Screen Shot 2020-10-23 at 10.08.26 PM.png > allow timeAllowed and cursorMark parame

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219994#comment-17219994 ] Mark Robert Miller commented on SOLR-14354: --- It’s likely a decent improvement,

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-10-23 Thread GitBox
muse-dev[bot] commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r511202225 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java ## @@ -165,42 +191,88 @@ public VectorValues get

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219975#comment-17219975 ] Varun Thacker commented on SOLR-14354: -- Whenever we've taken flamegraphs (  [https:/

[jira] [Updated] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-14354: - Attachment: image-2020-10-23-16-45-20-034.png > HttpShardHandler send requests in async > ---

[jira] [Updated] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-14354: - Attachment: image-2020-10-23-16-45-37-628.png > HttpShardHandler send requests in async > ---

[jira] [Updated] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-14354: - Attachment: image-2020-10-23-16-45-21-789.png > HttpShardHandler send requests in async > ---

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219964#comment-17219964 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14067: -- Here is anot

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219962#comment-17219962 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14067: -- bq. Tomas Ed

[GitHub] [lucene-solr] madrob commented on pull request #2004: SOLR-14942: Reduce leader election time on node shutdown

2020-10-23 Thread GitBox
madrob commented on pull request #2004: URL: https://github.com/apache/lucene-solr/pull/2004#issuecomment-715622888 Please add a CHANGES entry, and credit @CaoManhDat as well, if this work was based on initial work done by him. -

[GitHub] [lucene-solr] msokolov opened a new pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-10-23 Thread GitBox
msokolov opened a new pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022 Phew this has been a long time coming, but I think it is in good shape now. We started with a scratchy prototype about a year ago, then @mocobeta got it on a better footing by adding a new codec

[jira] [Commented] (LUCENE-9582) Rename VectorValues.ScoreFunction to SearchStrategy

2020-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219948#comment-17219948 ] ASF subversion and git services commented on LUCENE-9582: - Commi

[GitHub] [lucene-solr] msokolov merged pull request #2018: LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy

2020-10-23 Thread GitBox
msokolov merged pull request #2018: URL: https://github.com/apache/lucene-solr/pull/2018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] msokolov commented on pull request #2018: LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy

2020-10-23 Thread GitBox
msokolov commented on pull request #2018: URL: https://github.com/apache/lucene-solr/pull/2018#issuecomment-715591773 thanks for the review! I'll fix when merging This is an automated message from the Apache Git Service. To r

[GitHub] [lucene-solr] dsmiley commented on pull request #1993: .gitignore clean up

2020-10-23 Thread GitBox
dsmiley commented on pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715572444 Finally; I think it's ready. Much simpler file than before and more organized. Outdated items from the 8x branch are gone. I'll merge Monday unless I get an approving re

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-10-23 Thread Yevhen Tienkaiev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219927#comment-17219927 ] Yevhen Tienkaiev commented on SOLR-14413: - Hello, is there any status on this? Th

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219926#comment-17219926 ] David Smiley commented on SOLR-14067: - BTW, RE XSLT, it'd clearly be another issue. I

[jira] [Commented] (SOLR-14844) Upgrade Jetty to 9.4.32.v20200930

2020-10-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219908#comment-17219908 ] Erick Erickson commented on SOLR-14844: --- I'll take a look today sometime, it can be

[jira] [Commented] (SOLR-14844) Upgrade Jetty to 9.4.32.v20200930

2020-10-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219892#comment-17219892 ] Samuel García Martínez commented on SOLR-14844: --- branch_8x pull request: ht

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2018: LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy

2020-10-23 Thread GitBox
jtibshirani commented on a change in pull request #2018: URL: https://github.com/apache/lucene-solr/pull/2018#discussion_r511087483 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/IntervalQuery.java ## @@ -99,7 +99,7 @@ public IntervalQuery(String fie

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-23 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219869#comment-17219869 ] David Eric Pugh commented on SOLR-14067: [~tflobbe]do you have an example of wher

[jira] [Comment Edited] (SOLR-14939) JSON facets: range faceting to support cache=false parameter

2020-10-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219868#comment-17219868 ] Joel Bernstein edited comment on SOLR-14939 at 10/23/20, 6:44 PM: -

[jira] [Commented] (SOLR-14939) JSON facets: range faceting to support cache=false parameter

2020-10-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219868#comment-17219868 ] Joel Bernstein commented on SOLR-14939: --- Interesting, I would not have suspected th

[GitHub] [lucene-solr] epugh commented on pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-23 Thread GitBox
epugh commented on pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-715500720 Okay, this PR is kind of "ready". I've migrated the content out of the Cwiki page, and into the ref guide. One thing I want to highlight is that I'd like to be able to eas

[GitHub] [lucene-solr] samuelgmartinez opened a new pull request #2021: SOLR-14844: upgrade jetty to 9.4.32.v20200930

2020-10-23 Thread GitBox
samuelgmartinez opened a new pull request #2021: URL: https://github.com/apache/lucene-solr/pull/2021 # Description Upgrades Jetty to 9.4.32.v20200930 as described in JIRA ticket. # Solution After upgrading the compression related tests started to fail, so so

[GitHub] [lucene-solr] msokolov commented on pull request #1993: .gitignore clean up

2020-10-23 Thread GitBox
msokolov commented on pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715478148 > @msokolov you added .#* -- what comment should I use in this file to explain what this is? It's more cruft emacs sometimes leaves behind _ I think in this case it's an

[jira] [Commented] (LUCENE-9581) Clarify discardCompoundToken behavior in the JapaneseTokenizer

2020-10-23 Thread Kazuaki Hiraga (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219808#comment-17219808 ] Kazuaki Hiraga commented on LUCENE-9581: Thank you for your input, [~jimczi].  M

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

2020-10-23 Thread GitBox
HoustonPutman commented on a change in pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510997092 ## File path: help/docker.txt ## @@ -0,0 +1,53 @@ +Docker Images for Solr +== + +Solr docker images are built using Palantir

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

2020-10-23 Thread GitBox
HoustonPutman commented on a change in pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510995608 ## File path: .github/workflows/docker-test.yml ## @@ -17,6 +17,10 @@ jobs: runs-on: ubuntu-latest +env: + DOCKER_SOLR_IMAGE_R

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

2020-10-23 Thread GitBox
HoustonPutman commented on a change in pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510994999 ## File path: solr/docker/tests/cases/version/test.sh ## @@ -1,45 +0,0 @@ -#!/bin/bash Review comment: Yeah, this is something that migh

[GitHub] [lucene-solr] madrob commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

2020-10-23 Thread GitBox
madrob commented on a change in pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510986901 ## File path: .github/workflows/docker-test.yml ## @@ -17,6 +17,10 @@ jobs: runs-on: ubuntu-latest +env: + DOCKER_SOLR_IMAGE_REPO: gi

[jira] [Updated] (LUCENE-9583) How should we expose VectorValues.RandomAccess?

2020-10-23 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-9583: Description: In the newly-added {{VectorValues}} API, we have a {{RandomAccess}} sub-inte

[jira] [Created] (LUCENE-9583) How should we expose VectorValues.RandomAccess?

2020-10-23 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9583: --- Summary: How should we expose VectorValues.RandomAccess? Key: LUCENE-9583 URL: https://issues.apache.org/jira/browse/LUCENE-9583 Project: Lucene - Core

[GitHub] [lucene-solr] epugh commented on pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-23 Thread GitBox
epugh commented on pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-715416443 I'm getting there, and I wanted to specifically mention that @chatman other PR was critical for me following the chain of changes required to move this to /contrib. Thanks @

[jira] [Commented] (SOLR-14942) Reduce leader election time on node shutdown

2020-10-23 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219733#comment-17219733 ] Shalin Shekhar Mangar commented on SOLR-14942: -- Thanks Hoss. I have updated

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2018: LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy

2020-10-23 Thread GitBox
msokolov commented on a change in pull request #2018: URL: https://github.com/apache/lucene-solr/pull/2018#discussion_r510895391 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510868759 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510870382 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510870382 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510869235 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510868759 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510864013 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [lucene-solr] shalinmangar commented on pull request #2004: SOLR-14942: Reduce leader election time on node shutdown

2020-10-23 Thread GitBox
shalinmangar commented on pull request #2004: URL: https://github.com/apache/lucene-solr/pull/2004#issuecomment-715322784 @madrob would you like to make a final pass at this PR? I wish to merge to master and back port to 8x today. --

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-23 Thread GitBox
gus-asf commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r510861146 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley closed pull request #1109: More pervasive use of PackageLoader / PluginInfo

2020-10-23 Thread GitBox
dsmiley closed pull request #1109: URL: https://github.com/apache/lucene-solr/pull/1109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-10-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219649#comment-17219649 ] David Smiley commented on SOLR-14354: - FYI I did last night and +1'ed it. BUILD SUCCE

[GitHub] [lucene-solr] dsmiley commented on pull request #1993: .gitignore clean up

2020-10-23 Thread GitBox
dsmiley commented on pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715309491 @msokolov you added `.#*` -- what comment should I use in this file to explain what this is? This is an aut

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-10-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219642#comment-17219642 ] Jan Høydahl commented on SOLR-13973: I'm aware of that design doc, and my comment was

[jira] [Commented] (SOLR-14944) solr metrics should remove "spins" references

2020-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219615#comment-17219615 ] ASF subversion and git services commented on SOLR-14944: Commit b

[jira] [Commented] (SOLR-14944) solr metrics should remove "spins" references

2020-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219616#comment-17219616 ] ASF subversion and git services commented on SOLR-14944: Commit 9