madrob commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510986901
##########
File path: .github/workflows/docker-test.yml
##########
@@ -17,6 +17,10 @@ jobs:
runs-on: ubuntu-latest
+ env:
+ DOCKER_SOLR_IMAGE_REPO: github-pr/solr
Review comment:
Does this mean we will publish all of our PR docker images somewhere?
##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin,
https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all
accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+ Default: "apache/solr"
+ EnvVar: DOCKER_SOLR_IMAGE_REPO
+ Gradle Property: -Pdocker.solr.imageRepo
Review comment:
Should this be solr.docker instead of docker.solr?
##########
File path: solr/docker/tests/cases/version/test.sh
##########
@@ -1,45 +0,0 @@
-#!/bin/bash
Review comment:
Deleted because we can set the tag and version to be anything now?
##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin,
https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all
accepted via both Environment Variables and Gradle Properties.
Review comment:
s/it's/its
##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin,
https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all
accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+ Default: "apache/solr"
+ EnvVar: DOCKER_SOLR_IMAGE_REPO
+ Gradle Property: -Pdocker.solr.imageRepo
+
+Docker Image Tag:
+ Default: the Solr version, e.g. "9.0.0-SNAPSHOT"
+ EnvVar: DOCKER_SOLR_IMAGE_TAG
+ Gradle Property: -Pdocker.solr.imageTag
+
+Docker Image Name: (Use this to explicitly set a whole image name. If given,
the image repo and image version options above are ignored.)
+ Default: {image_repo}/{image_tag} (both options provided above, with
defaults)
+ EnvVar: DOCKER_SOLR_IMAGE_NAME
+ Gradle Property: -Pdocker.solr.imageName
+
+Building
+--------
+
+In order to build the Solr Docker image, run:
+
+gradlew docker
+
+The docker build task (`gradlew docker`) accepts the following inputs, in
addition to the common inputs listed above:
Review comment:
This is displayed as plain text, not markdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
