dsmiley commented on pull request #1582:
URL: https://github.com/apache/lucene-solr/pull/1582#issuecomment-645122868
Yes; tests pass. I re-acquainted myself with these specific changes now and
they all make sense to me.
Thi
dsmiley commented on pull request #1514:
URL: https://github.com/apache/lucene-solr/pull/1514#issuecomment-645120762
Last minute request: also please change solrUrlWhitelist to avoid this
"whitelist" word (think current events) to, I propose "allowSolrUrls". There's
a discussion going on
noblepaul opened a new pull request #1586:
URL: https://github.com/apache/lucene-solr/pull/1586
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Noble Paul created SOLR-14576:
-
Summary: HttpCacheHeaderUti.etagCoreCache should not use a
SolrCore as key
Key: SOLR-14576
URL: https://issues.apache.org/jira/browse/SOLR-14576
Project: Solr
Iss
msokolov commented on a change in pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441170320
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4289,7 +4287,7 @@ private synchronized void
mergeFinish(MergePoli
msfroh commented on a change in pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441148085
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -399,6 +427,23 @@ public String segString(Directory dir) {
}
dsmiley commented on a change in pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441140226
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -399,6 +427,23 @@ public String segString(Directory dir) {
}
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137925#comment-17137925
]
Alex Klibisz commented on LUCENE-9378:
--
[~mgibney]
> quick clarification regardin
[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137920#comment-17137920
]
Haoyu Zhai commented on LUCENE-8574:
I've attached a unit test showing a case that c
[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haoyu Zhai updated LUCENE-8574:
---
Attachment: unit_test.patch
> ExpressionFunctionValues should cache per-hit value
>
s1monw commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r441125936
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -399,8 +423,19 @@ public String segString(Directory dir) {
}
s1monw commented on pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#issuecomment-644997637
@msfroh I opened https://github.com/apache/lucene-solr/pull/1585 to make it
easier to do this.
This is an a
s1monw commented on pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585#issuecomment-644992788
@mikemccand @msokolov @msfroh I prepared some of my changes so we can pull
them in and incorporate them into the overall change.
s1monw opened a new pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585
This change adds infrastructure to allow straight forward waiting
on one or more merges or an entire merge specification. This is
a basis for LUCENE-8962.
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137909#comment-17137909
]
Varun Thacker commented on LUCENE-9322:
---
I've taken only VectorField parts from yo
vthacker opened a new pull request #1584:
URL: https://github.com/apache/lucene-solr/pull/1584
https://issues.apache.org/jira/projects/LUCENE-ABCD
# Description
Add VectorField
# Tests
Please describe the tests you've developed or run to confirm this patch
imple
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137820#comment-17137820
]
Michael Gibney commented on LUCENE-9378:
[~alexklibisz], quick clarification reg
[
https://issues.apache.org/jira/browse/SOLR-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137793#comment-17137793
]
Jim Anderson commented on SOLR-14553:
-
My apologies for the misplace email. I realize
[
https://issues.apache.org/jira/browse/SOLR-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14573.
---
Fix Version/s: 8.6
Resolution: Fixed
> Fix or suppress warnings in solrj/src/test
> --
[
https://issues.apache.org/jira/browse/SOLR-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137783#comment-17137783
]
David Smiley commented on SOLR-8274:
I'm an OpenTracing noob too but what drives me is
[
https://issues.apache.org/jira/browse/SOLR-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137643#comment-17137643
]
ASF subversion and git services commented on SOLR-14573:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137675#comment-17137675
]
ASF subversion and git services commented on SOLR-14573:
Commit c
msfroh commented on pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#issuecomment-644899966
This approach makes sense to me.
I like how much simpler the addition of MergeSpecification.await() makes
things, versus the CountDownLatch hackery of the previous app
dsmiley commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r441014049
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,14 @@ Many of the other useful compon
jpountz commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r440900284
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -489,6 +497,19 @@ public RegExp(String s) throws IllegalArgument
[
https://issues.apache.org/jira/browse/SOLR-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-14553.
Resolution: Invalid
> I get a stack trace when running Solrj when calling the query method
[
https://issues.apache.org/jira/browse/SOLR-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136816#comment-17136816
]
Jason Gerlowski commented on SOLR-14553:
Hey Jim, sorry you're having troubles.
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136805#comment-17136805
]
Varun Thacker commented on LUCENE-9322:
---
Hello [~jtibshirani] ! Thanks for tacklin
epugh commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440992193
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,14 @@ Many of the other useful componen
gerlowskija commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440983349
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,15 @@ Many of the other useful co
dsmiley commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440982370
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,14 @@ Many of the other useful compon
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136783#comment-17136783
]
Bruno Roustant edited comment on LUCENE-9379 at 6/16/20, 4:25 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136783#comment-17136783
]
Bruno Roustant commented on LUCENE-9379:
So I plan to implement an EncryptingDir
[
https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136761#comment-17136761
]
Gus Heck commented on SOLR-13749:
-
8.6 is now [being
scheduled|https://mail-archives.apa
[
https://issues.apache.org/jira/browse/LUCENE-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9353.
--
Fix Version/s: 8.6
Resolution: Fixed
> Move metadata of the terms dictionary to its own
[
https://issues.apache.org/jira/browse/LUCENE-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136678#comment-17136678
]
ASF subversion and git services commented on LUCENE-9353:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136677#comment-17136677
]
Jason Gerlowski edited comment on SOLR-8274 at 6/16/20, 2:04 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136677#comment-17136677
]
Jason Gerlowski commented on SOLR-8274:
---
I looked a bit at the OpenTracing docs in t
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136668#comment-17136668
]
Alex Klibisz commented on LUCENE-9378:
--
[~jpountz] Sure, I'll explain below:
My pl
[
https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136667#comment-17136667
]
Jason Gerlowski commented on SOLR-14566:
Huh, didn't know about that. And yeah,
[
https://issues.apache.org/jira/browse/LUCENE-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136644#comment-17136644
]
ASF subversion and git services commented on LUCENE-9353:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136643#comment-17136643
]
ASF subversion and git services commented on LUCENE-9353:
-
Commi
jpountz merged pull request #1473:
URL: https://github.com/apache/lucene-solr/pull/1473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136630#comment-17136630
]
ASF subversion and git services commented on SOLR-14558:
Commit 7
s1monw merged pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136616#comment-17136616
]
Michael McCandless commented on LUCENE-9405:
Thanks [~simonw]!
> IndexWrite
mikemccand commented on pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573#issuecomment-644734269
> thanks @mikemccand - I will run tests again and push.
++
This is an automated message from the A
s1monw commented on pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573#issuecomment-644732898
thanks @mikemccand - I will run tests again and push.
This is an automated message from the Apache Git Servic
mikemccand commented on pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573#issuecomment-644731914
I tested indexing throughput on `luceneutil` with `wikimediumall`, single
thread for indexing `SerialMergeScheduler`:
```
[mike@beast3 facet]$ grep "GB/hour" /l/
[
https://issues.apache.org/jira/browse/SOLR-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136599#comment-17136599
]
ASF subversion and git services commented on SOLR-14558:
Commit a
gerlowskija merged pull request #1570:
URL: https://github.com/apache/lucene-solr/pull/1570
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136591#comment-17136591
]
Lucene/Solr QA commented on SOLR-14571:
---
| (/) *{color:green}+1 overall{color}* |
\
epugh commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440778391
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,15 @@ Many of the other useful componen
epugh commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440777282
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,15 @@ Many of the other useful componen
gerlowskija commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r44077
##
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##
@@ -169,3 +169,15 @@ Many of the other useful co
[
https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9404.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> simplify checksum calculation of ByteBuff
[
https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136524#comment-17136524
]
ASF subversion and git services commented on LUCENE-9404:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136513#comment-17136513
]
Marius Grama edited comment on LUCENE-9407 at 6/16/20, 10:26 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136516#comment-17136516
]
ASF subversion and git services commented on LUCENE-9403:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9403.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> tune BufferedChecksum.DEFAULT_BUFFERSIZE
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136513#comment-17136513
]
Marius Grama edited comment on LUCENE-9407 at 6/16/20, 10:25 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136513#comment-17136513
]
Marius Grama commented on LUCENE-9407:
--
> the instanceof happening here in the ela
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136507#comment-17136507
]
Robert Muir commented on LUCENE-9407:
-
-1: the instanceof happening here in the elas
[
https://issues.apache.org/jira/browse/LUCENE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9396.
--
Fix Version/s: 8.6
Resolution: Fixed
> Improve truncation detection for points
> --
[
https://issues.apache.org/jira/browse/LUCENE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136504#comment-17136504
]
ASF subversion and git services commented on LUCENE-9396:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136496#comment-17136496
]
ASF subversion and git services commented on LUCENE-9396:
-
Commi
jpountz merged pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jpountz commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-644651408
I implemented your suggestion.
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Grama updated LUCENE-9407:
-
Description:
h2. Problem description
A few years ago the geospatial queries classes have be
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Grama updated LUCENE-9407:
-
Description:
h2. Problem description
A few years ago the geospatial queries classes have be
mariusneo opened a new pull request #1583:
URL: https://github.com/apache/lucene-solr/pull/1583
LUCENE-9407: change the visibility of the LatLonXQuery classes to public in
order to allow using them outside of the org.apache.lucene.document package
# Description
A few years
[
https://issues.apache.org/jira/browse/LUCENE-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Grama updated LUCENE-9407:
-
Description:
h2. Problem description
A few years ago the geospatial queries classes have be
Marius Grama created LUCENE-9407:
Summary: Change the visibility of LatLonXQuery classes to public
Key: LUCENE-9407
URL: https://issues.apache.org/jira/browse/LUCENE-9407
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136454#comment-17136454
]
Adrien Grand commented on LUCENE-9378:
--
[~alexklibisz] Can you give more details ab
jpountz commented on a change in pull request #1351:
URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r440675787
##
File path:
lucene/core/src/java/org/apache/lucene/search/FilteringNumericComparator.java
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwa
jimczi commented on a change in pull request #1577:
URL: https://github.com/apache/lucene-solr/pull/1577#discussion_r440654020
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseTokenizer.java
##
@@ -1917,4 +1917,15 @@ private static boolean
[
https://issues.apache.org/jira/browse/LUCENE-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9400.
--
Fix Version/s: 8.6
Assignee: Ignacio Vera
Resolution: Fixed
> Tessellator migh
jpountz commented on a change in pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567#discussion_r440628129
##
File path: lucene/core/src/test/org/apache/lucene/search/MultiCollectorTest.java
##
@@ -163,4 +163,115 @@ public void testCacheScoresIfNecessary()
[
https://issues.apache.org/jira/browse/LUCENE-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136373#comment-17136373
]
ASF subversion and git services commented on LUCENE-9400:
-
Commi
iverase merged pull request #1562:
URL: https://github.com/apache/lucene-solr/pull/1562
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136372#comment-17136372
]
ASF subversion and git services commented on LUCENE-9400:
-
Commi
81 matches
Mail list logo
