gerlowskija commented on a change in pull request #1581:
URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r440755557
##########
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##########
@@ -169,3 +169,15 @@ Many of the other useful components are described in
sections of this Guide for
* `TermVectorComponent`, described in the section
<<the-term-vector-component.adoc#the-term-vector-component,The Term Vector
Component>>.
* `QueryElevationComponent`, described in the section
<<the-query-elevation-component.adoc#the-query-elevation-component,The Query
Elevation Component>>.
* `TermsComponent`, described in the section
<<the-terms-component.adoc#the-terms-component,The Terms Component>>.
+
+Other components that ship with Solr include:
Review comment:
I'm surprised you put these components in a separate table, rather than
appending them to the existing list right above here. Any particular reason
you kept this list separate from the list above?
##########
File path:
solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc
##########
@@ -169,3 +169,15 @@ Many of the other useful components are described in
sections of this Guide for
* `TermVectorComponent`, described in the section
<<the-term-vector-component.adoc#the-term-vector-component,The Term Vector
Component>>.
* `QueryElevationComponent`, described in the section
<<the-query-elevation-component.adoc#the-query-elevation-component,The Query
Elevation Component>>.
* `TermsComponent`, described in the section
<<the-terms-component.adoc#the-terms-component,The Terms Component>>.
+
+Other components that ship with Solr include:
+
+[cols="20,40,40",options="header"]
+|===
+|Component Name |Class Name |More Information
+|phrases |`solr.PhrasesIdentificationComponent` | Learn more in the
{solr-javadocs}org/apache/solr/handler/component/PhrasesIdentificationComponent.html[PhrasesIdentificationComponent]
java class.
Review comment:
I understand the desire to avoid duplication here with the Javadoc
content, but it might still be nice to have a 1 sentence description, so
readers don't have to click through just to figure out whether they're
interested.
That said, even without that, this PR raises the visibility of these
components which is a Good Thing. So I'm happy either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
