[jira] [Commented] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135495#comment-17135495 ] Dawid Weiss commented on LUCENE-9404: - Could be, I can't remember. Let's just switch

[jira] [Commented] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135473#comment-17135473 ] Uwe Schindler commented on LUCENE-9404: --- [~dweiss]: The Java 9 version is complete

[jira] [Commented] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135457#comment-17135457 ] Dawid Weiss commented on LUCENE-9404: - I remember clearly this had to do with update

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-14 Thread GitBox
dsmiley commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439936737 ## File path: solr/core/src/test-files/solr/solr-50-all.xml ## @@ -24,6 +24,7 @@ testConfigSetsHandler testManagementPath testSharedLib + /t

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-14 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439884150 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -338,6 +339,19 @@ public CoreContainer(NodeConfig config, CoresLocator

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-14 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439883240 ## File path: solr/core/src/test-files/solr/solr-50-all.xml ## @@ -24,6 +24,7 @@ testConfigSetsHandler testManagementPath testSharedLib + /tm

[jira] [Commented] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135303#comment-17135303 ] Robert Muir commented on LUCENE-9404: - I thought about this when looking at benchmar

[jira] [Updated] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9404: Attachment: LUCENE-9404.patch > simplify checksum calculation of ByteBuffersIndexOutput >

[jira] [Created] (LUCENE-9404) simplify checksum calculation of ByteBuffersIndexOutput

2020-06-14 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9404: --- Summary: simplify checksum calculation of ByteBuffersIndexOutput Key: LUCENE-9404 URL: https://issues.apache.org/jira/browse/LUCENE-9404 Project: Lucene - Core

[GitHub] [lucene-solr] dsmiley commented on pull request #1514: SOLR-13749: Change cross-collection join query syntax to {!join method=crossCollection ...}

2020-06-14 Thread GitBox
dsmiley commented on pull request #1514: URL: https://github.com/apache/lucene-solr/pull/1514#issuecomment-643826837 @danmfox Still missing Ref Guide changes to account for the refactor This is an automated message from the A

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: solr_conf.zip > HTTP 401 when searching on alias in secured Solr >

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: security.json > HTTP 401 when searching on alias in secured Solr >

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: SOLR-14569.patch > HTTP 401 when searching on alias in secured Solr > -

[jira] [Created] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-14 Thread Isabelle Giguere (Jira)
Isabelle Giguere created SOLR-14569: --- Summary: HTTP 401 when searching on alias in secured Solr Key: SOLR-14569 URL: https://issues.apache.org/jira/browse/SOLR-14569 Project: Solr Issue Typ

[jira] [Resolved] (SOLR-14479) Fix or suppress warnings in solr/analysis

2020-06-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14479. --- Resolution: Fixed Taken care of this in other JIRAs > Fix or suppress warnings in solr/analy

[jira] [Resolved] (SOLR-14556) Fix or suppress warnings in solrj/cloud/autoscaling

2020-06-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14556. --- Fix Version/s: 8.6 Resolution: Fixed They said it couldn't be done! > Fix or suppress

[jira] [Commented] (SOLR-14556) Fix or suppress warnings in solrj/cloud/autoscaling

2020-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135278#comment-17135278 ] ASF subversion and git services commented on SOLR-14556: Commit c

[jira] [Commented] (SOLR-14556) Fix or suppress warnings in solrj/cloud/autoscaling

2020-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135277#comment-17135277 ] ASF subversion and git services commented on SOLR-14556: Commit 8

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-14 Thread GitBox
dsmiley commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439789761 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -338,6 +339,19 @@ public CoreContainer(NodeConfig config, CoresLocator

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
dweiss commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439858046 ## File path: lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java ## @@ -19,203 +19,207 @@ import java.io.IOException; -import org

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
dweiss commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439857921 ## File path: lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java ## @@ -19,203 +19,207 @@ import java.io.IOException; -import org

[jira] [Commented] (LUCENE-9403) tune BufferedChecksum.DEFAULT_BUFFERSIZE

2020-06-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135263#comment-17135263 ] Michael McCandless commented on LUCENE-9403: +1 looks compelling! > tune Bu

[jira] [Commented] (SOLR-14566) Record "NOW" on "coordinator" log messages

2020-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135245#comment-17135245 ] Robert Muir commented on SOLR-14566: {quote} An alternative approach would be to crea

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135231#comment-17135231 ] Erick Erickson commented on SOLR-14541: --- This branch has the hashCode commented out

[jira] [Updated] (LUCENE-9403) tune BufferedChecksum.DEFAULT_BUFFERSIZE

2020-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9403: Attachment: LUCENE-9403.patch > tune BufferedChecksum.DEFAULT_BUFFERSIZE > ---

[jira] [Created] (LUCENE-9403) tune BufferedChecksum.DEFAULT_BUFFERSIZE

2020-06-14 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9403: --- Summary: tune BufferedChecksum.DEFAULT_BUFFERSIZE Key: LUCENE-9403 URL: https://issues.apache.org/jira/browse/LUCENE-9403 Project: Lucene - Core Issue Type: Im

[jira] [Resolved] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14567. --- Fix Version/s: 8.6 Resolution: Fixed > Fix or suppress remaining warnings in solrj > -

[jira] [Commented] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135134#comment-17135134 ] ASF subversion and git services commented on SOLR-14567: Commit 4

[jira] [Commented] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135133#comment-17135133 ] ASF subversion and git services commented on SOLR-14567: Commit c

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439805381 ## File path: lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriterPerField.java ## @@ -56,12 +56,6 @@ public FreqProxTermsWriterPerField(F

[GitHub] [lucene-solr] s1monw commented on pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#issuecomment-643735813 > I think we should run indexing throughput benchmark to make sure there's no real impact here. I'll do that. +1 thanks @mikemccand -

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439804390 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java ## @@ -222,7 +234,7 @@ void writeProx(TermVectorsPostingsA

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439804443 ## File path: lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java ## @@ -19,203 +19,207 @@ import java.io.IOException; -import org

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439804315 ## File path: lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriterPerField.java ## @@ -56,12 +56,6 @@ public FreqProxTermsWriterPerField(F

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1573: Cleanup TermsHashPerField

2020-06-14 Thread GitBox
s1monw commented on a change in pull request #1573: URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439803910 ## File path: lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriterPerField.java ## @@ -207,8 +202,6 @@ public void newPostingsArray() {