[jira] [Commented] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true

2020-06-02 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124573#comment-17124573 ] Lucene/Solr QA commented on SOLR-14520: --- | (/) *{color:green}+1 overall{color}* | \

[GitHub] [lucene-solr] dsmiley closed pull request #1531: SOLR-11334: Split some field lists better

2020-06-02 Thread GitBox
dsmiley closed pull request #1531: URL: https://github.com/apache/lucene-solr/pull/1531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "

2020-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-11334: Fix Version/s: 8.6 Assignee: David Smiley Resolution: Fixed Status: Resol

[jira] [Commented] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124551#comment-17124551 ] ASF subversion and git services commented on SOLR-11334: Commit c

[jira] [Commented] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124549#comment-17124549 ] ASF subversion and git services commented on SOLR-11334: Commit 2

[GitHub] [lucene-solr] dsmiley merged pull request #1546: SOLR: Use absolute paths for server paths.

2020-06-02 Thread GitBox
dsmiley merged pull request #1546: URL: https://github.com/apache/lucene-solr/pull/1546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true

2020-06-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14520: -- Status: Patch Available (was: Open) > json.facets: allBucket:true can cause server err

[jira] [Updated] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true

2020-06-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14520: -- Attachment: SOLR-14520.patch Status: Open (was: Open) bq. Perhaps the key to

[jira] [Commented] (SOLR-14524) Harden MultiThreadedOCPTest

2020-06-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124330#comment-17124330 ] Erick Erickson commented on SOLR-14524: --- [~mdrob] Do you want to commit this or sha

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)

2020-06-02 Thread GitBox
dsmiley commented on a change in pull request #1550: URL: https://github.com/apache/lucene-solr/pull/1550#discussion_r434119837 ## File path: lucene/benchmark/build.gradle ## @@ -15,27 +15,138 @@ * limitations under the License. */ - -apply plugin: 'java-library' +apply p

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-06-02 Thread GitBox
dsmiley commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r434081511 ## File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java ## @@ -52,35 +56,53 @@ private static final Logger log = LoggerFacto

[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124123#comment-17124123 ] Erick Erickson commented on SOLR-14533: --- Cool, I'll take a look this evening. No b

[jira] [Commented] (SOLR-14467) inconsistent server errors combining relatedness() with allBuckets:true

2020-06-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124035#comment-17124035 ] Chris M. Hostetter commented on SOLR-14467: --- _(I thought i posted this comment

[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123865#comment-17123865 ] Andras Salamon commented on SOLR-14533: --- It was a local patch, I was just about to

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123863#comment-17123863 ] Jan Høydahl commented on SOLR-14531: I bet Noble is laying out traps for me :)  > Re

[jira] [Updated] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14533: -- Attachment: SOLR-14533.patch > Fix or suppress warnings in solr/handler/admin > ---

[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123854#comment-17123854 ] Erick Erickson commented on SOLR-14533: --- Just barely, thanks for catching this so q

[GitHub] [lucene-solr] joel-bernstein closed pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first

2020-06-02 Thread GitBox
joel-bernstein closed pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene-solr] joel-bernstein commented on pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first

2020-06-02 Thread GitBox
joel-bernstein commented on pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551#issuecomment-637570708 This was for an internal hackathon. Closing, sorry for the noise. This is an automated message from t

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123849#comment-17123849 ] Ishan Chattopadhyaya commented on SOLR-14531: - bq. ?? means that I don't even

[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123834#comment-17123834 ] Andras Salamon commented on SOLR-14533: --- Have you started the work on this [~ericke

[jira] [Created] (SOLR-14533) Fix or suppress warnings in solr/handler/admin

2020-06-02 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14533: - Summary: Fix or suppress warnings in solr/handler/admin Key: SOLR-14533 URL: https://issues.apache.org/jira/browse/SOLR-14533 Project: Solr Issue Type: Sub

[jira] [Commented] (SOLR-9679) Exception when removing zk node /security.json

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123828#comment-17123828 ] Jan Høydahl commented on SOLR-9679: --- Will commit this soon > Exception when removing zk

[GitHub] [lucene-solr] joel-bernstein opened a new pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first

2020-06-02 Thread GitBox
joel-bernstein opened a new pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the ap

[jira] [Resolved] (SOLR-14526) fix or suppress warnings in apache/solr/core

2020-06-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14526. --- Fix Version/s: 8.6 Resolution: Fixed > fix or suppress warnings in apache/solr/core >

[jira] [Commented] (SOLR-14526) fix or suppress warnings in apache/solr/core

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123779#comment-17123779 ] ASF subversion and git services commented on SOLR-14526: Commit 1

[jira] [Commented] (SOLR-14526) fix or suppress warnings in apache/solr/core

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123777#comment-17123777 ] ASF subversion and git services commented on SOLR-14526: Commit d

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123776#comment-17123776 ] Jan Høydahl commented on SOLR-14531: {quote}Why this cryptic comment? If you're worri

[jira] [Resolved] (SOLR-14527) The 8.5.1 release can't be verified using PGP

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14527. Resolution: Implemented I checked in a new version of README.html to the release mirror * Links to

[GitHub] [lucene-solr] jpountz commented on pull request #1543: LUCENE-9378: Disable compression on binary values whose length is less than 32.

2020-06-02 Thread GitBox
jpountz commented on pull request #1543: URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-637517914 Here are updated results where the baseline is master with Mark's commit that enabled compression of binary doc values is reverted, and the patch is this pull request. The b

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123729#comment-17123729 ] Noble Paul commented on SOLR-14531: --- indeed Erick the gradle build is really poetry. Lo

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123721#comment-17123721 ] Erick Erickson commented on SOLR-14531: --- "gw check -x test" is faster on master Sh

[jira] [Resolved] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-14531. --- Fix Version/s: 8.6 Resolution: Fixed > Refactor out internode requests from HttpShardHandler >

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123713#comment-17123713 ] Ishan Chattopadhyaya commented on SOLR-14531: - bq. ?? Why this cryptic commen

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123712#comment-17123712 ] Jan Høydahl commented on SOLR-14531: Thanks for adding the description. I assume this

[GitHub] [lucene-solr] jpountz commented on pull request #1541: RegExp - add case insensitive matching option

2020-06-02 Thread GitBox
jpountz commented on pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#issuecomment-637503848 @markharwood Java's case-insensitivity flag is indeed a bit mask flag passed to the constructor, but my comment was more about the fact that the current flags on RegExp are

[jira] [Commented] (LUCENE-9383) Port benchmark module Ant build to Gradle

2020-06-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123703#comment-17123703 ] Dawid Weiss commented on LUCENE-9383: - I've added a few quick comments, David. Hope

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123702#comment-17123702 ] Noble Paul commented on SOLR-14531: --- I just moved an anonymous inner class used in {{Ht

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)

2020-06-02 Thread GitBox
dweiss commented on a change in pull request #1550: URL: https://github.com/apache/lucene-solr/pull/1550#discussion_r433824063 ## File path: lucene/benchmark/build.gradle ## @@ -15,27 +15,138 @@ * limitations under the License. */ - -apply plugin: 'java-library' +apply pl

[jira] [Updated] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14531: -- Description: We need to improve the readability of {{HttpShardHandler}} by cutting it into smaller piec

[GitHub] [lucene-solr] dweiss commented on pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)

2020-06-02 Thread GitBox
dweiss commented on pull request #1550: URL: https://github.com/apache/lucene-solr/pull/1550#issuecomment-637493362 > I switched from "java-library" type of Gradle plugin/module to more plainly "java" because this module isn't a library (isn't something depended on by anything), it's close

[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler

2020-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123690#comment-17123690 ] Jan Høydahl commented on SOLR-14531: ?? > Refactor out internode requests from HttpS

[jira] [Resolved] (LUCENE-9382) Lucene's gradle version can't cope with Java 14

2020-06-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9382. - Fix Version/s: master (9.0) Resolution: Fixed > Lucene's gradle version can't cope with J

[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123681#comment-17123681 ] ASF subversion and git services commented on LUCENE-9382: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #1549: LUCENE-9382: update gradle to 6.4.1.

2020-06-02 Thread GitBox
dweiss merged pull request #1549: URL: https://github.com/apache/lucene-solr/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14

2020-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123680#comment-17123680 ] ASF subversion and git services commented on LUCENE-9382: - Commi

[jira] [Commented] (SOLR-14527) The 8.5.1 release can't be verified using PGP

2020-06-02 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123671#comment-17123671 ] Ignacio Vera commented on SOLR-14527: - Thanks [~janhoy] > The 8.5.1 release can't be

[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14

2020-06-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123653#comment-17123653 ] Dawid Weiss commented on LUCENE-9382: - {quote}bq. Am I correct that this change make

[jira] [Commented] (SOLR-14532) Add iml file to gitignore

2020-06-02 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123469#comment-17123469 ] Andras Salamon commented on SOLR-14532: --- Gitignore only ignored {{parent.iml}} prob

[jira] [Created] (SOLR-14532) Add iml file to gitignore

2020-06-02 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-14532: - Summary: Add iml file to gitignore Key: SOLR-14532 URL: https://issues.apache.org/jira/browse/SOLR-14532 Project: Solr Issue Type: Bug Security Level

[jira] [Updated] (SOLR-14532) Add iml file to gitignore

2020-06-02 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14532: -- Attachment: SOLR-14532.patch > Add iml file to gitignore > - > >