[ 
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123713#comment-17123713
 ] 

Ishan Chattopadhyaya commented on SOLR-14531:
---------------------------------------------

bq. ??
Why this cryptic comment? If you're worried why a PR wasn't raised for this, 
then please explicitly say so.

IMO, such trivial changes shouldn't need a PR. This is literally moving a class 
from a file to another one. However, if there are more such changes needed for 
this large class, we should club them together and commit in one go (with a PR).

[~noble.paul], next time please run {{ant precommit}} before every push.

> Refactor out internode requests from HttpShardHandler
> -----------------------------------------------------
>
>                 Key: SOLR-14531
>                 URL: https://issues.apache.org/jira/browse/SOLR-14531
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into 
> smaller piecesĀ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to