[GitHub] [lucene-solr] arysin commented on issue #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin commented on issue #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353#issuecomment-599153969 Looks like needs a bit more work This is an automated

[GitHub] [lucene-solr] arysin closed pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin closed pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] arysin opened a new pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin opened a new pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353 # Description Please provide a short description of the changes you're making with this pull request. # Solut

[jira] [Created] (LUCENE-9279) Update dictionary version for Ukrainian analyzer to 4.9.0

2020-03-14 Thread Andriy Rysin (Jira)
Andriy Rysin created LUCENE-9279: Summary: Update dictionary version for Ukrainian analyzer to 4.9.0 Key: LUCENE-9279 URL: https://issues.apache.org/jira/browse/LUCENE-9279 Project: Lucene - Core

[jira] [Commented] (SOLR-14012) Different data type for unique aggregation and countDistinct

2020-03-14 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059484#comment-17059484 ] Lucene/Solr QA commented on SOLR-14012: --- | (/) *{color:green}+1 overall{color}* | \

[jira] [Updated] (SOLR-14296) Update netty to 4.1.47

2020-03-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14296: -- Summary: Update netty to 4.1.47 (was: Update netty to 4.1.46) > Update netty to 4.1.47 > -

[jira] [Comment Edited] (SOLR-14296) Update netty to 4.1.47

2020-03-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059414#comment-17059414 ] Erick Erickson edited comment on SOLR-14296 at 3/14/20, 5:22 PM: --

[jira] [Commented] (SOLR-14296) Update netty to 4.1.46

2020-03-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059414#comment-17059414 ] Erick Erickson commented on SOLR-14296: --- I found some weirdness between the Gradle

[jira] [Commented] (LUCENE-9077) Gradle build

2020-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059397#comment-17059397 ] David Smiley commented on LUCENE-9077: -- Please send announcements directly to the d

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392594785 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589684 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -318,8 +301,10 @@ priv

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589649 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -249,34 +247,19 @@ pub

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589684 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -318,8 +301,10 @@ priv

[jira] [Comment Edited] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059295#comment-17059295 ] Tomoko Uchida edited comment on LUCENE-9278 at 3/14/20, 1:46 PM: -

[jira] [Assigned] (SOLR-8306) Enhance ExpandComponent to allow expand.hits=0

2020-03-14 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-8306: -- Assignee: Munendra S N > Enhance ExpandComponent to allow expand.hits=0 > -

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059318#comment-17059318 ] Dawid Weiss commented on LUCENE-9278: - For what it's worth, the VM for gradle can be

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059316#comment-17059316 ] Dawid Weiss commented on LUCENE-9278: - You can separate compilation/ test execution

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059312#comment-17059312 ] Robert Muir commented on LUCENE-9278: - {quote} I'm not sure whether this can go in b

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059296#comment-17059296 ] Dawid Weiss commented on LUCENE-9278: - I'm for moving docs under project/* but pleas

[jira] [Comment Edited] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059295#comment-17059295 ] Tomoko Uchida edited comment on LUCENE-9278 at 3/14/20, 10:12 AM:

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059295#comment-17059295 ] Tomoko Uchida commented on LUCENE-9278: --- Currently the {{renderJavadoc}} task shar

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392571884 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ config

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392571898 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // ge

[GitHub] [lucene-solr] micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#issuecomment-599032031 > No auto-boxing concerns for Boolean :-) thanks for the reassurance :) - do you mean the performance

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059274#comment-17059274 ] Dawid Weiss commented on LUCENE-9278: - Looks good to me, Tomoko. I'm not sure whethe

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392569098 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesour

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392569092 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesour

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568830 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // gene

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568764 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ configur

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568691 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // gene

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392562835 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ config

[jira] [Commented] (LUCENE-9077) Gradle build

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059255#comment-17059255 ] Tomoko Uchida commented on LUCENE-9077: --- [ANN] Dawid Weiss and I are planning to

[jira] [Comment Edited] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059206#comment-17059206 ] Tomoko Uchida edited comment on LUCENE-9278 at 3/14/20, 7:05 AM: -

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059206#comment-17059206 ] Tomoko Uchida commented on LUCENE-9278: --- Hi [~dweiss], could you take a look at th

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059205#comment-17059205 ] Tomoko Uchida commented on LUCENE-9278: --- The whole javadoc folder structure will b