[GitHub] [lucene-solr] rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r363067259 ## File path: solr/solr-ref-guide/src/securing-solr.adoc ## @@ -97,4 +97,4 @@ It is also

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r363067244 ## File path: solr/bin/solr.in.sh ## @@ -229,4 +229,4 @@ # Runtime properties are passe

[jira] [Commented] (SOLR-11369) Zookeeper credentials are showed up on the Solr Admin GUI

2020-01-04 Thread sophie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008221#comment-17008221 ] sophie commented on SOLR-11369: --- any long-term fix now ? Other than just simple hide? Has i

[jira] [Commented] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008190#comment-17008190 ] Erick Erickson commented on SOLR-14159: --- I just attached the failure I've seen with

[jira] [Updated] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14159: -- Attachment: FailWaitingForCollection_WithHossFix > Fix errors in TestCloudConsistency > ---

[jira] [Commented] (SOLR-13486) race condition between leader's "replay on startup" and non-leader's "recover from leader" can leave replicas out of sync (TestTlogReplayVsRecovery)

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008184#comment-17008184 ] Erick Erickson commented on SOLR-13486: --- [~dweiss] It is committed to master, the f

[jira] [Commented] (SOLR-13486) race condition between leader's "replay on startup" and non-leader's "recover from leader" can leave replicas out of sync (TestTlogReplayVsRecovery)

2020-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008134#comment-17008134 ] Dawid Weiss commented on SOLR-13486: I can't claim I understand what's going on in th

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
MarcusSorealheis commented on issue #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#issuecomment-570808557 @erikhatcher I'm concerned about overhead. Are you aware of a good place or methodology to understand the overhe

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
MarcusSorealheis commented on issue #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#issuecomment-570805545 That’s correct. I still have more to test in the massive test suite. I just got sleepy. On Sat, Jan 4,

[jira] [Commented] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008087#comment-17008087 ] Erick Erickson commented on SOLR-14159: --- And here's the patch I used (WithHossFix.p

[jira] [Updated] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14159: -- Attachment: WithHossFix.patch > Fix errors in TestCloudConsistency > --

[jira] [Comment Edited] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008082#comment-17008082 ] Erick Erickson edited comment on SOLR-14159 at 1/4/20 4:36 PM:

[jira] [Commented] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008082#comment-17008082 ] Erick Erickson commented on SOLR-14159: --- Not sure I can call this "lucky", but here

[jira] [Updated] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14159: -- Attachment: FailWithHossFix > Fix errors in TestCloudConsistency >

[GitHub] [lucene-solr] dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests

2020-01-04 Thread GitBox
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570798426 Yes, it works. Low level jvm messages or debugging security, network, etc, screw it up badly though. But tests work. --

[GitHub] [lucene-solr] uschindler commented on issue #1138: LUCENE-9077 Print repro line for failed tests

2020-01-04 Thread GitBox
uschindler commented on issue #1138: LUCENE-9077 Print repro line for failed tests URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570798071 By the way: is security manager working correctly in Gradle? Because the elasticsearch issue mentions that security manager is not

[GitHub] [lucene-solr] dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests

2020-01-04 Thread GitBox
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570797460 Hi Mike. I looked at gradle's internal APIs again and I don't think we'll be able to dodge having a custom test output listener. I would

[jira] [Commented] (SOLR-14159) Fix errors in TestCloudConsistency

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008057#comment-17008057 ] Erick Erickson commented on SOLR-14159: --- [~hossman] Many thanks for your effort her

[jira] [Commented] (SOLR-5480) Make MoreLikeThisHandler distributable

2020-01-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008040#comment-17008040 ] Erick Erickson commented on SOLR-5480: -- [~noble.paul] [~anshum] [~hossman] How does t

[GitHub] [lucene-solr] erikhatcher commented on issue #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
erikhatcher commented on issue #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#issuecomment-570771899 The lines changed are comment lines, so no effective change made here yet.

[jira] [Commented] (SOLR-14147) enable security manager by default

2020-01-04 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007964#comment-17007964 ] Marcus Eagan commented on SOLR-14147: - I created a PR and made the simple changes. I

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1141: SOLR-14147 change the Security manager to default to true.

2020-01-04 Thread GitBox
MarcusSorealheis opened a new pull request #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141 # Description Change the Security Manager to default to true. # Solution Changed the boolean val

[jira] [Updated] (SOLR-14158) package manager to read keys from packagestore and not ZK

2020-01-04 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14158: -- Description: The security of the package system relies on securing ZK. It's much easier for users to s

[jira] [Comment Edited] (SOLR-13649) BasicAuth's 'blockUnknown' param should default to true

2020-01-04 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897554#comment-16897554 ] Marcus Eagan edited comment on SOLR-13649 at 1/4/20 9:02 AM: -

[jira] [Resolved] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2020-01-04 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-8867. -- Fix Version/s: 8.2 Assignee: Ignacio Vera Resolution: Fixed Thanks [~sokolov],

[jira] [Commented] (LUCENE-9077) Gradle build

2020-01-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007943#comment-17007943 ] Dawid Weiss commented on LUCENE-9077: - Thanks Mike. The test runner is indeed quite