rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r363067244
########## File path: solr/bin/solr.in.sh ########## @@ -229,4 +229,4 @@ # Runtime properties are passed to the security policy file (server/etc/security.policy) # You can also tweak via standard JDK files such as ~/.java.policy, see https://s.apache.org/java8policy # This is experimental! It may not work at all with Hadoop/HDFS features. -#SOLR_SECURITY_MANAGER_ENABLED=false +SOLR_SECURITY_MANAGER_ENABLED=true Review comment: We shouldn't put uncommented values in these files. After all, it says at the very top of the file: > The default shipped state of this file is completely commented. Instead, lets fix the actual defaults for the scripts. It just means if the environment variable is not set, we want to set it to `true`. Here is an example that does that for a different change, but demonstrates the idea: https://issues.apache.org/jira/secure/attachment/12989428/SOLR-14142.patch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
