Re: [PR] Support changelog scan for table with delete files [iceberg]

pvary commented on PR #10935: URL: https://github.com/apache/iceberg/pull/10935#issuecomment-2294754336 @wypoon, @manuzhang: I'm interested in providing Flink streaming CDC reads. That would require a working changelog scan planning in Iceberg core. So I would be happy to help with my revie

Re: [I] Docs: Add clear indicators for required fields in Spark syntax on CREATE TABLE. [iceberg]

danielhumanmod commented on issue #9545: URL: https://github.com/apache/iceberg/issues/9545#issuecomment-2294754821 Hi team, may I take a look on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

liurenjie1024 commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720743099 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] Ensure that RestCatalog passes user config to FileIO [iceberg-rust]

liurenjie1024 commented on code in PR #476: URL: https://github.com/apache/iceberg-rust/pull/476#discussion_r1720746207 ## crates/catalog/rest/src/catalog.rs: ## @@ -504,8 +504,15 @@ impl Catalog for RestCatalog { .query::(request) .await?; +l

Re: [PR] chore: add clean job in Makefile [iceberg-rust]

liurenjie1024 merged PR #561: URL: https://github.com/apache/iceberg-rust/pull/561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [I] Add `clean` job in Makefile. [iceberg-rust]

liurenjie1024 closed issue #560: Add `clean` job in Makefile. URL: https://github.com/apache/iceberg-rust/issues/560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] feat: SQL Catalog - namespaces [iceberg-rust]

callum-ryan commented on code in PR #534: URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720764034 ## crates/catalog/sql/src/catalog.rs: ## @@ -167,43 +177,335 @@ impl SqlCatalog { .await .map_err(from_sqlx_error) } + +/// Ex

Re: [PR] feat: SQL Catalog - namespaces [iceberg-rust]

callum-ryan commented on code in PR #534: URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720764099 ## crates/catalog/sql/src/catalog.rs: ## @@ -167,43 +177,335 @@ impl SqlCatalog { .await .map_err(from_sqlx_error) } + +/// Ex

Re: [PR] feat: SQL Catalog - namespaces [iceberg-rust]

callum-ryan commented on code in PR #534: URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720765041 ## crates/catalog/sql/src/catalog.rs: ## @@ -167,43 +177,335 @@ impl SqlCatalog { .await .map_err(from_sqlx_error) } + +/// Ex

Re: [I] add support for DuckDB views as a valid data format [iceberg-python]

djouallah closed issue #407: add support for DuckDB views as a valid data format URL: https://github.com/apache/iceberg-python/issues/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] make to_duckdb accept multiple tables [iceberg-python]

djouallah closed issue #408: make to_duckdb accept multiple tables URL: https://github.com/apache/iceberg-python/issues/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Snowflke can't read tables generated by pyicberg ? [iceberg-python]

djouallah closed issue #723: Snowflke can't read tables generated by pyicberg ? URL: https://github.com/apache/iceberg-python/issues/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Flink: deprecate ReaderFunction to a new Reader interface that can also return output type info [iceberg]

stevenzwu commented on PR #10944: URL: https://github.com/apache/iceberg/pull/10944#issuecomment-2294927333 close this one in favor of the converter model from https://github.com/apache/iceberg/pull/10956 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Flink: deprecate ReaderFunction to a new Reader interface that can also return output type info [iceberg]

stevenzwu closed pull request #10944: Flink: deprecate ReaderFunction to a new Reader interface that can also return output type info URL: https://github.com/apache/iceberg/pull/10944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]

rfung777 commented on PR #996: URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2294949048 I had an attempt of adding the Windows integration tests. Would you help review again please? Thanks. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Support changelog scan for table with delete files [iceberg]

wypoon commented on PR #10935: URL: https://github.com/apache/iceberg/pull/10935#issuecomment-2294958003 @pvary thank you for your interest and for the Flink scenarios, which is very helpful as I am unfamiliar with Flink. Regarding https://github.com/apache/iceberg/pull/9888, please r

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720845074 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720845166 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720845074 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720848705 ## crates/iceberg/src/io/object_cache.rs: ## Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Table Scan Performance Tests [iceberg-rust]

sdd commented on code in PR #497: URL: https://github.com/apache/iceberg-rust/pull/497#discussion_r1720849073 ## justfile: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distrib

Re: [PR] doc: Add statement for contributors to avoid force push. [iceberg]

stevenzwu commented on code in PR #10939: URL: https://github.com/apache/iceberg/pull/10939#discussion_r1720849209 ## site/docs/contribute.md: ## @@ -44,6 +44,7 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * It's helpful to include a pref

Re: [PR] Flink: infer source parallelism for FLIP-27 source in batch execution mode [iceberg]

stevenzwu commented on code in PR #10832: URL: https://github.com/apache/iceberg/pull/10832#discussion_r1720850331 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceBounded.java: ## @@ -130,11 +128,8 @@ protected List run( sourceBuilder.pro

Re: [PR] Flink: infer source parallelism for FLIP-27 source in batch execution mode [iceberg]

stevenzwu commented on code in PR #10832: URL: https://github.com/apache/iceberg/pull/10832#discussion_r1720850444 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -545,5 +579,66 @@ public IcebergSource build() { table,

Re: [PR] Flink: infer source parallelism for FLIP-27 source in batch execution mode [iceberg]

stevenzwu commented on code in PR #10832: URL: https://github.com/apache/iceberg/pull/10832#discussion_r1720850526 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -464,6 +519,15 @@ public Builder watermarkColumnTimeUnit(TimeUnit time

Re: [PR] Flink: infer source parallelism for FLIP-27 source in batch execution mode [iceberg]

stevenzwu commented on code in PR #10832: URL: https://github.com/apache/iceberg/pull/10832#discussion_r1720850542 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -503,28 +569,10 @@ public IcebergSource build() { new Ord

Re: [PR] [WIP] AWS: Add partition info to Glue [iceberg]

github-actions[bot] closed pull request #4775: [WIP] AWS: Add partition info to Glue URL: https://github.com/apache/iceberg/pull/4775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [WIP] AWS: Add partition info to Glue [iceberg]

github-actions[bot] commented on PR #4775: URL: https://github.com/apache/iceberg/pull/4775#issuecomment-2295037827 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Recover the schema by reading previous metadata files [iceberg]

github-actions[bot] commented on PR #4809: URL: https://github.com/apache/iceberg/pull/4809#issuecomment-2295037834 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Recover the schema by reading previous metadata files [iceberg]

github-actions[bot] closed pull request #4809: Core: Recover the schema by reading previous metadata files URL: https://github.com/apache/iceberg/pull/4809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support file filtering based on schema [iceberg]

github-actions[bot] commented on PR #4842: URL: https://github.com/apache/iceberg/pull/4842#issuecomment-2295037837 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] [CORE] Support file filtering based on schema [iceberg]

github-actions[bot] closed pull request #4842: [CORE] Support file filtering based on schema URL: https://github.com/apache/iceberg/pull/4842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Infra: add AWS CI workflow configuration [iceberg]

github-actions[bot] closed pull request #4855: Infra: add AWS CI workflow configuration URL: https://github.com/apache/iceberg/pull/4855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Infra: add AWS CI workflow configuration [iceberg]

github-actions[bot] commented on PR #4855: URL: https://github.com/apache/iceberg/pull/4855#issuecomment-2295037840 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] API, Core: Add schema_id to ContentFile [iceberg]

github-actions[bot] closed pull request #4898: API, Core: Add schema_id to ContentFile URL: https://github.com/apache/iceberg/pull/4898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] API, Core: Add schema_id to ContentFile [iceberg]

github-actions[bot] commented on PR #4898: URL: https://github.com/apache/iceberg/pull/4898#issuecomment-2295037844 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] [Core]Add EncryptionManagerFactory to configure encryption via catalog properties and table metadata. [iceberg]

github-actions[bot] commented on PR #5539: URL: https://github.com/apache/iceberg/pull/5539#issuecomment-2295037897 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] [AWS]AWS KMS client [iceberg]

github-actions[bot] commented on PR #5549: URL: https://github.com/apache/iceberg/pull/5549#issuecomment-2295037900 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Spark - Add Missing Override for fileFormat function in JMH WriterBenchmark Suite [iceberg]

github-actions[bot] commented on PR #5550: URL: https://github.com/apache/iceberg/pull/5550#issuecomment-2295037901 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Spark: Write on a snapshot branch ref [iceberg]

github-actions[bot] commented on PR #5585: URL: https://github.com/apache/iceberg/pull/5585#issuecomment-2295037913 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Support to write a custom partition transforms in iceberg [iceberg]

github-actions[bot] commented on issue #5606: URL: https://github.com/apache/iceberg/issues/5606#issuecomment-2295037920 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Use DefaultAWSCredentialsProviderChain for AWS credentials [iceberg]

github-actions[bot] commented on issue #5608: URL: https://github.com/apache/iceberg/issues/5608#issuecomment-2295037927 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Delete the data when UPDATE_BEFORE [iceberg]

github-actions[bot] commented on PR #5619: URL: https://github.com/apache/iceberg/pull/5619#issuecomment-2295037932 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] [Question] Flink SQL read upsert data from iceberg [iceberg]

github-actions[bot] closed issue #5623: [Question] Flink SQL read upsert data from iceberg URL: https://github.com/apache/iceberg/issues/5623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Question] Flink SQL read upsert data from iceberg [iceberg]

github-actions[bot] commented on issue #5623: URL: https://github.com/apache/iceberg/issues/5623#issuecomment-2295037936 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Structured Streaming writes to iceberg table with non-identity partition spec breaks with spark extensions enabled [iceberg]

github-actions[bot] closed issue #5625: Structured Streaming writes to iceberg table with non-identity partition spec breaks with spark extensions enabled URL: https://github.com/apache/iceberg/issues/5625 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Structured Streaming writes to iceberg table with non-identity partition spec breaks with spark extensions enabled [iceberg]

github-actions[bot] commented on issue #5625: URL: https://github.com/apache/iceberg/issues/5625#issuecomment-2295037940 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Error projecting nested structs from manifests table [iceberg]

github-actions[bot] commented on issue #5649: URL: https://github.com/apache/iceberg/issues/5649#issuecomment-2295037953 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Bind overwrite filters [iceberg]

github-actions[bot] commented on PR #5638: URL: https://github.com/apache/iceberg/pull/5638#issuecomment-2295037947 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Issue #5625 - Added testcase to test Structured Streaming writes with… [iceberg]

github-actions[bot] commented on PR #5660: URL: https://github.com/apache/iceberg/pull/5660#issuecomment-2295037959 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Iceberg Beam Sink [iceberg]

github-actions[bot] commented on PR #5668: URL: https://github.com/apache/iceberg/pull/5668#issuecomment-2295037966 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Fix rewrite targetSize [iceberg]

github-actions[bot] commented on PR #5685: URL: https://github.com/apache/iceberg/pull/5685#issuecomment-2295037972 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Spark: Check for hive support when using SparkSessionCatalog [iceberg]

github-actions[bot] commented on PR #5693: URL: https://github.com/apache/iceberg/pull/5693#issuecomment-2295037977 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Support non-optional union types and column projection in complex union for Avro [iceberg]

github-actions[bot] commented on PR #5704: URL: https://github.com/apache/iceberg/pull/5704#issuecomment-2295037988 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Distributed writes in the same iceberg transaction [iceberg-python]

github-actions[bot] commented on issue #357: URL: https://github.com/apache/iceberg-python/issues/357#issuecomment-2295038577 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] Consolidate FileIO [iceberg-python]

github-actions[bot] commented on issue #310: URL: https://github.com/apache/iceberg-python/issues/310#issuecomment-2295038585 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] Consolidate FileIO [iceberg-python]

github-actions[bot] closed issue #310: Consolidate FileIO URL: https://github.com/apache/iceberg-python/issues/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] Distributed writes in the same iceberg transaction [iceberg-python]

github-actions[bot] closed issue #357: Distributed writes in the same iceberg transaction URL: https://github.com/apache/iceberg-python/issues/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

stevenzwu commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1708076227 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java: ## @@ -0,0 +1,811 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

liurenjie1024 commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720891166 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

stevenzwu commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1720888195 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[PR] Build: Bump junit from 5.10.1 to 5.11.0 [iceberg]

dependabot[bot] opened a new pull request, #10958: URL: https://github.com/apache/iceberg/pull/10958 Bumps `junit` from 5.10.1 to 5.11.0. Updates `org.junit.jupiter:junit-jupiter` from 5.10.1 to 5.11.0 Release notes Sourced from https://github.com/junit-team/junit5/releases";>org

Re: [PR] Build: Bump junit from 5.10.1 to 5.10.3 [iceberg]

dependabot[bot] closed pull request #10609: Build: Bump junit from 5.10.1 to 5.10.3 URL: https://github.com/apache/iceberg/pull/10609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Build: Bump junit from 5.10.1 to 5.10.3 [iceberg]

dependabot[bot] commented on PR #10609: URL: https://github.com/apache/iceberg/pull/10609#issuecomment-2295109202 Superseded by #10958. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Build: Bump org.springframework:spring-web from 5.3.37 to 5.3.39 [iceberg]

dependabot[bot] opened a new pull request, #10959: URL: https://github.com/apache/iceberg/pull/10959 Bumps [org.springframework:spring-web](https://github.com/spring-projects/spring-framework) from 5.3.37 to 5.3.39. Release notes Sourced from https://github.com/spring-projects/spr

[PR] Build: Bump guava from 33.2.1-jre to 33.3.0-jre [iceberg]

dependabot[bot] opened a new pull request, #10960: URL: https://github.com/apache/iceberg/pull/10960 Bumps `guava` from 33.2.1-jre to 33.3.0-jre. Updates `com.google.guava:guava` from 33.2.1-jre to 33.3.0-jre Release notes Sourced from https://github.com/google/guava/releases";>c

[PR] Build: Bump software.amazon.awssdk:bom from 2.27.2 to 2.27.7 [iceberg]

dependabot[bot] opened a new pull request, #10961: URL: https://github.com/apache/iceberg/pull/10961 Bumps software.amazon.awssdk:bom from 2.27.2 to 2.27.7. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

Re: [PR] Object Cache: caches parsed Manifests and ManifestLists for performance [iceberg-rust]

liurenjie1024 commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1720892585 ## crates/iceberg/src/io/object_cache.rs: ## @@ -0,0 +1,396 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [I] Specify in lower/upper bounds in data_file struct are exact [iceberg]

singhpk234 commented on issue #10930: URL: https://github.com/apache/iceberg/issues/10930#issuecomment-2295114217 > which would specify if bounds are exact for a particular data file. This would allow to reliably perform aggregation pushdown to Iceberg by engines. By default lower_bounds an

Re: [PR] Flink: deprecate ReaderFunction with a new Converter interface to simplify user experience [iceberg]

pvary commented on code in PR #10956: URL: https://github.com/apache/iceberg/pull/10956#discussion_r1720898632 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/reader/RowDataConverter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Flink: deprecate ReaderFunction with a new Converter interface to simplify user experience [iceberg]

pvary commented on code in PR #10956: URL: https://github.com/apache/iceberg/pull/10956#discussion_r1720898887 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/reader/ConverterReaderFunction.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Support changelog scan for table with delete files [iceberg]

pvary commented on PR #10935: URL: https://github.com/apache/iceberg/pull/10935#issuecomment-2295126370 > For the positional delete case, I do not believe deleting the same position in the same data file again can happen I agree, that this should be the case. My only concern is, that