Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-09 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087423 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -83,4 +90,26 @@ public void testAutoCreateTable

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-09 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087812 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -47,7 +54,7 @@ public class IcebergWriterFactor

Re: [PR] fix (manifest-list): added serde aliases to support both forms conventions [iceberg-rust]

2024-05-09 Thread via GitHub
a-agmon commented on PR #365: URL: https://github.com/apache/iceberg-rust/pull/365#issuecomment-2102212707 > I'm okay with this, but before the next release, we need to get field-ID resolution in place. That's a very important part of Iceberg. In this case, we stumbled into a naming differe

Re: [PR] fix (manifest-list): added serde aliases to support both forms conventions [iceberg-rust]

2024-05-09 Thread via GitHub
zeodtr commented on PR #365: URL: https://github.com/apache/iceberg-rust/pull/365#issuecomment-2102243287 @a-agmon I think the PR is simple and clear. BTW, it would be nice to change the field names of the `ManifestFileV2` struct to the 'correct' ones (for example, `pub added_data_files_c

Re: [I] I found duplicate records when i was repeatedly exporting records from CDC Stream into iceberg partitioned table [iceberg]

2024-05-09 Thread via GitHub
mlbzssk commented on issue #6153: URL: https://github.com/apache/iceberg/issues/6153#issuecomment-2102333009 > +I['bob', 1, 20221109] > -U['bob', 1, 20221109] > +U['bob', 1, 20221110] > Think you @luoyuxia for your replay. I just confirmed that the problem is caused by

Re: [PR] A new implementation of an Iceberg Sink [WIP] that will be used with upcoming Flink Compaction jobs [iceberg]

2024-05-09 Thread via GitHub
pvary commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1595258499 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkAggregator.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] A new implementation of an Iceberg Sink [WIP] that will be used with upcoming Flink Compaction jobs [iceberg]

2024-05-09 Thread via GitHub
pvary commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1595263210 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkAggregator.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-05-09 Thread via GitHub
ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2102416207 cc: @RussellSpitzer, @szehon-ho : Can you please take a look? I need reviews and I want to take it forward. previous discussions can be found at https://github.com/apache/iceber

Re: [PR] fix (manifest-list): added serde aliases to support both forms conventions [iceberg-rust]

2024-05-09 Thread via GitHub
Fokko commented on PR #365: URL: https://github.com/apache/iceberg-rust/pull/365#issuecomment-2102592152 > BTW, it would be nice to change the field names of the ManifestFileV2 struct to the 'correct' ones (for example, pub added_data_files_count to pub added_files_count but it would requir

Re: [PR] fix (manifest-list): added serde aliases to support both forms conventions [iceberg-rust]

2024-05-09 Thread via GitHub
Fokko merged PR #365: URL: https://github.com/apache/iceberg-rust/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [I] Compatibility issues with `org.apache.iceberg:iceberg-spark-runtime-3.5_2.13:1.5.0` [iceberg-rust]

2024-05-09 Thread via GitHub
Fokko closed issue #338: Compatibility issues with `org.apache.iceberg:iceberg-spark-runtime-3.5_2.13:1.5.0` URL: https://github.com/apache/iceberg-rust/issues/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Update site to 1.5.2 docs [iceberg]

2024-05-09 Thread via GitHub
nastra merged PR #10291: URL: https://github.com/apache/iceberg/pull/10291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] #10275 - fix NullPointerException [iceberg]

2024-05-09 Thread via GitHub
nastra commented on PR #10284: URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2102639635 I think it would be good to add a test that reproduces the issue you described in `TestParquetVectorizedReads` -- This is an automated message from the Apache Git Service. To respond t

Re: [I] `iceberg-spark-runtime-3.3_2.12-1.5.1` seems to be compiled with a mismatched scala version [iceberg]

2024-05-09 Thread via GitHub
nastra closed issue #10251: `iceberg-spark-runtime-3.3_2.12-1.5.1` seems to be compiled with a mismatched scala version URL: https://github.com/apache/iceberg/issues/10251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] `iceberg-spark-runtime-3.3_2.12-1.5.1` seems to be compiled with a mismatched scala version [iceberg]

2024-05-09 Thread via GitHub
nastra commented on issue #10251: URL: https://github.com/apache/iceberg/issues/10251#issuecomment-2102650885 I'll go ahead and close this, since this was fixed by releasing Iceberg 1.5.2 with the correctly compiled artifacts. -- This is an automated message from the Apache Git Service. T

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.25.40 to 2.25.45 [iceberg]

2024-05-09 Thread via GitHub
nastra merged PR #10266: URL: https://github.com/apache/iceberg/pull/10266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Support special chars in S3URI [iceberg]

2024-05-09 Thread via GitHub
dimas-b commented on PR #10283: URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2102663607 Encoding special chars in partition path elements sounds like a good idea, but I'm not sure it is that simple However, the problem is not specific to what Iceberg code puts The ba

Re: [PR] Update mkdocs.yml - Fixes Apache Doris documentation link [iceberg]

2024-05-09 Thread via GitHub
nastra commented on code in PR #10263: URL: https://github.com/apache/iceberg/pull/10263#discussion_r1595459892 ## docs/mkdocs.yml: ## @@ -60,7 +60,7 @@ nav: - Amazon EMR: https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-use-cluster.html - Snowflake: https:

Re: [PR] feat: support append data file and add e2e test [iceberg-rust]

2024-05-09 Thread via GitHub
ZENOTME commented on code in PR #349: URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1595472104 ## crates/e2e_test/tests/append_data_file_test.rs: ## @@ -0,0 +1,212 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[PR] build(deps): bump golang.org/x/net from 0.18.0 to 0.23.0 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] opened a new pull request, #73: URL: https://github.com/apache/iceberg-go/pull/73 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.18.0 to 0.23.0. Commits https://github.com/golang/net/commit/c48da131589f122489348be5dfbcb6457640046f";>c48da13 http

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.26.3 to 1.26.6 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #57: URL: https://github.com/apache/iceberg-go/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.19.0 [iceberg-go]

2024-05-09 Thread via GitHub
nastra commented on PR #56: URL: https://github.com/apache/iceberg-go/pull/56#issuecomment-2102845954 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.19.0 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] closed pull request #56: build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.19.0 URL: https://github.com/apache/iceberg-go/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.21.1 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] opened a new pull request, #74: URL: https://github.com/apache/iceberg-go/pull/74 Bumps [github.com/hamba/avro/v2](https://github.com/hamba/avro) from 2.16.0 to 2.21.1. Release notes Sourced from https://github.com/hamba/avro/releases";>github.com/hamba/avro/v2's r

Re: [PR] build(deps): bump github.com/google/uuid from 1.3.1 to 1.6.0 [iceberg-go]

2024-05-09 Thread via GitHub
nastra commented on PR #55: URL: https://github.com/apache/iceberg-go/pull/55#issuecomment-2102848064 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.19.0 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] commented on PR #56: URL: https://github.com/apache/iceberg-go/pull/56#issuecomment-2102847421 Superseded by #74. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] build(deps): bump github.com/google/uuid from 1.3.1 to 1.6.0 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #55: URL: https://github.com/apache/iceberg-go/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] build(deps): bump github.com/wolfeidau/s3iofs from 1.5.0 to 1.5.2 [iceberg-go]

2024-05-09 Thread via GitHub
nastra commented on PR #53: URL: https://github.com/apache/iceberg-go/pull/53#issuecomment-2102856128 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.14 to 1.16.16 [iceberg-go]

2024-05-09 Thread via GitHub
nastra commented on PR #54: URL: https://github.com/apache/iceberg-go/pull/54#issuecomment-2102856439 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump golang.org/x/net from 0.18.0 to 0.23.0 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #73: URL: https://github.com/apache/iceberg-go/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] build(deps): bump github.com/hamba/avro/v2 from 2.16.0 to 2.21.1 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #74: URL: https://github.com/apache/iceberg-go/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.16 to 1.17.12 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] opened a new pull request, #75: URL: https://github.com/apache/iceberg-go/pull/75 Bumps [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) from 1.16.16 to 1.17.12. Commits https://github.com/aws/aws-sdk-go-v2/commit/e7dfd72430a5095

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.14 to 1.16.16 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] closed pull request #54: build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.14 to 1.16.16 URL: https://github.com/apache/iceberg-go/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.14 to 1.16.16 [iceberg-go]

2024-05-09 Thread via GitHub
dependabot[bot] commented on PR #54: URL: https://github.com/apache/iceberg-go/pull/54#issuecomment-2102861151 Superseded by #75. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.16 to 1.17.12 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #75: URL: https://github.com/apache/iceberg-go/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] build(deps): bump github.com/wolfeidau/s3iofs from 1.5.0 to 1.5.2 [iceberg-go]

2024-05-09 Thread via GitHub
nastra merged PR #53: URL: https://github.com/apache/iceberg-go/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[PR] AWS: Change S3FileIO to use SHA1 based checksums [iceberg]

2024-05-09 Thread via GitHub
muddyfish opened a new pull request, #10293: URL: https://github.com/apache/iceberg/pull/10293 ## Issue Using [S3 Express](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-express-one-zone.html) for Iceberg was previously failing multipart upload integration tests as well as

Re: [PR] Test, write subset of schema [iceberg-python]

2024-05-09 Thread via GitHub
HonahX merged PR #704: URL: https://github.com/apache/iceberg-python/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Compare `Schema` and `StructType` fields irrespective of ordering [iceberg-python]

2024-05-09 Thread via GitHub
kevinjqliu commented on code in PR #700: URL: https://github.com/apache/iceberg-python/pull/700#discussion_r1595691060 ## tests/integration/test_rest_schema.py: ## @@ -1730,19 +1730,17 @@ def test_move_nested_field_after_first(catalog: Catalog) -> None: with tbl.update_sch

Re: [PR] A new implementation of an Iceberg Sink [WIP] that will be used with upcoming Flink Compaction jobs [iceberg]

2024-05-09 Thread via GitHub
rodmeneses commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1595721315 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/committer/TestSinkV2Committer.java: ## @@ -0,0 +1,808 @@ +/* + * Licensed to the Apache Software F

[I] Running MERGE INTO with more than one condition fails if number of columns is > 321 [iceberg]

2024-05-09 Thread via GitHub
andreaschiappacasse opened a new issue, #10294: URL: https://github.com/apache/iceberg/issues/10294 ### Apache Iceberg version None ### Query engine Athena ### Please describe the bug 🐞 Hello everyone, today my team incurred in a very strange bug using Icebe

Re: [PR] Support special chars in S3URI [iceberg]

2024-05-09 Thread via GitHub
danielcweeks commented on PR #10283: URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2103091902 @dimas-b Unfortunately, I agree there will likely be problems if people use special characters in the pathing prefix that's outside of Iceberg's control, but overall, I think we wa

[PR] Docs: Add release notes for 1.5.2 [iceberg]

2024-05-09 Thread via GitHub
amogh-jahagirdar opened a new pull request, #10295: URL: https://github.com/apache/iceberg/pull/10295 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Infra: Add Iceberg 1.5.2 to issue template [iceberg]

2024-05-09 Thread via GitHub
Fokko merged PR #10296: URL: https://github.com/apache/iceberg/pull/10296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Update doap.rdf for 1.5.2 release [iceberg]

2024-05-09 Thread via GitHub
Fokko commented on PR #10297: URL: https://github.com/apache/iceberg/pull/10297#issuecomment-2103132728 We should probably update the CI exclusions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update doap.rdf for 1.5.2 release [iceberg]

2024-05-09 Thread via GitHub
Fokko merged PR #10297: URL: https://github.com/apache/iceberg/pull/10297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[PR] feat: Adding literals [iceberg-go]

2024-05-09 Thread via GitHub
zeroshade opened a new pull request, #76: URL: https://github.com/apache/iceberg-go/pull/76 After about 5 or 6 iterations of playing with how to represent expressions to start working on scan planning, I've finally settled on something I like!! Rather than a huge code dump, I've brok

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-09 Thread via GitHub
zeroshade commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2103261639 CC @Fokko @nastra @wolfeidau -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-09 Thread via GitHub
s-akhtar-baig opened a new pull request, #367: URL: https://github.com/apache/iceberg-rust/pull/367 GitHub issue: https://github.com/apache/iceberg-rust/issues/350 Description: ManifestEvaluator was implemented in https://github.com/apache/iceberg-rust/pull/322 whereas some functions

Re: [I] Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor [iceberg-rust]

2024-05-09 Thread via GitHub
s-akhtar-baig commented on issue #350: URL: https://github.com/apache/iceberg-rust/issues/350#issuecomment-2103332046 https://github.com/apache/iceberg-rust/pull/367 should close this issue. Most tests from pyiceberg have been implemented but some that are remaining will be covered in a fol

Re: [PR] Docs: Add release notes for 1.5.2 [iceberg]

2024-05-09 Thread via GitHub
Fokko merged PR #10295: URL: https://github.com/apache/iceberg/pull/10295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [I] Upgrade HadoopTableOperations.version from int32 to long64 [iceberg]

2024-05-09 Thread via GitHub
jkolash commented on issue #10277: URL: https://github.com/apache/iceberg/issues/10277#issuecomment-2103344935 In this case it is data written by snowflake it looks like it is a timestamp vs an auto increment. ``` test_snowflake_table test_snowflake_table/data test_snowflake_ta

Re: [PR] Support special chars in S3URI [iceberg]

2024-05-09 Thread via GitHub
dimas-b commented on PR #10283: URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2103400187 > this change would likely be incompatible with S3AFileSystem or any other system that uses the java URI implementation. [...] I believe we are already in this situation even with

Re: [I] How to avoid partition key sorting when inserting data into a partitioned Iceberg table? [iceberg]

2024-05-09 Thread via GitHub
snfddl closed issue #10181: How to avoid partition key sorting when inserting data into a partitioned Iceberg table? URL: https://github.com/apache/iceberg/issues/10181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] How to avoid partition key sorting when inserting data into a partitioned Iceberg table? [iceberg]

2024-05-09 Thread via GitHub
snfddl commented on issue #10181: URL: https://github.com/apache/iceberg/issues/10181#issuecomment-2103449186 insert into temp.partition_table select '20240418' as dt ,contents from temp.dataset where dt = '20240418' -- This is an automated message from the Apache G

[I] UncheckedSQLException while trying to CREATE or DROP TABLE [iceberg]

2024-05-09 Thread via GitHub
AlekHed opened a new issue, #10298: URL: https://github.com/apache/iceberg/issues/10298 ### Apache Iceberg version 1.5.1 ### Query engine Trino ### Please describe the bug 🐞 I am using dbt to built stage tables on iceberg with trino 446, at some point I suc

Re: [PR] [Spec] Add Iceberg Materialized View Spec [iceberg]

2024-05-09 Thread via GitHub
szehon-ho commented on code in PR #10280: URL: https://github.com/apache/iceberg/pull/10280#discussion_r1596072308 ## format/materialized-view-spec.md: ## @@ -0,0 +1,132 @@ + + +# Iceberg Materialized View Spec + +## Background and Motivation +Iceberg views are a powerful tool t

Re: [PR] AWS: Change S3FileIO to use SHA1 based checksums [iceberg]

2024-05-09 Thread via GitHub
amogh-jahagirdar commented on PR #10293: URL: https://github.com/apache/iceberg/pull/10293#issuecomment-2103607159 I have similar questions to @singhpk234. I think changing the the checksum default to a more expensive SHA1 validation may be more expensive without any significant benefits. T

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-09 Thread via GitHub
szehon-ho commented on code in PR #10273: URL: https://github.com/apache/iceberg/pull/10273#discussion_r1596113287 ## api/src/main/java/org/apache/iceberg/expressions/CountNonNull.java: ## @@ -39,6 +39,9 @@ protected Long countFor(StructLike row) { @Override protected bo

Re: [PR] Fix struct evolution default value rule list [iceberg]

2024-05-09 Thread via GitHub
amogh-jahagirdar commented on PR #10290: URL: https://github.com/apache/iceberg/pull/10290#issuecomment-2103630665 Thanks @sfc-gh-dmetzgar and thanks for reviewing @szehon-ho ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix struct evolution default value rule list [iceberg]

2024-05-09 Thread via GitHub
amogh-jahagirdar merged PR #10290: URL: https://github.com/apache/iceberg/pull/10290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] UncheckedSQLException while trying to CREATE or DROP TABLE [iceberg]

2024-05-09 Thread via GitHub
AlekHed commented on issue #10298: URL: https://github.com/apache/iceberg/issues/10298#issuecomment-2103686289 I think the problem is in sqlite configuration for catalog. Switching to postgres can fix the problem. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Implement missing operator handlers in `ManifestEvaluator` [iceberg-rust]

2024-05-09 Thread via GitHub
sdd closed pull request #366: Implement missing operator handlers in `ManifestEvaluator` URL: https://github.com/apache/iceberg-rust/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-09 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1596298705 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -98,103 +101,249 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { Ok(self.field_s

[I] how do you guys back up your iceberg table? [iceberg]

2024-05-09 Thread via GitHub
JunseoChoJJ opened a new issue, #10299: URL: https://github.com/apache/iceberg/issues/10299 ### Query engine _No response_ ### Question my situation is on-prem on top of that using k8s on top of that using trino or spark + iceberg + object storage I just want to a

Re: [PR] feat: Extract FileRead and FileWrite trait [iceberg-rust]

2024-05-09 Thread via GitHub
sdd commented on code in PR #364: URL: https://github.com/apache/iceberg-rust/pull/364#discussion_r1596342297 ## crates/iceberg/src/io.rs: ## @@ -206,6 +205,35 @@ impl FileIO { } } +/// The struct the represents the metadata of a file. +/// +/// TODO: we can add last mod