amogh-jahagirdar commented on PR #10293: URL: https://github.com/apache/iceberg/pull/10293#issuecomment-2103607159
I have similar questions to @singhpk234. I think changing the the checksum default to a more expensive SHA1 validation may be more expensive without any significant benefits. TLS already would have some more modern HMAC integrity check anyways. I also think we should avoid adding any net new configuration to `S3FileIO` just to keep things simpler. One possible path may be to deprecate the `checksumEnabled` path, and add a new configuration for `checksumAlgorithm` where the possible values are `none`, `md5`, `sha1` etc. The default would be none to preserve the existing behavior and that way the number of configurations remain the same in the long run, and we could also support the S3 express case. What do you think @muddyfish @singhpk234? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
