[GitHub] [iceberg] nastra opened a new pull request, #6562: Core: Improvements around Token Refresh time expiration

nastra opened a new pull request, #6562: URL: https://github.com/apache/iceberg/pull/6562 currently depends on changes from https://github.com/apache/iceberg/pull/6489 but will be rebased once https://github.com/apache/iceberg/pull/6489 is in -- This is an automated message from the Apac

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1066849968 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -376,5 +404,127 @@ public Pair refresh(RESTClient client) { return null; } + +

[GitHub] [iceberg] Fokko commented on a diff in pull request #6525: Python: Refactor loading manifests

Fokko commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1066862697 ## python/pyiceberg/avro/resolver.py: ## @@ -109,38 +109,46 @@ def resolve( class SchemaResolver(PrimitiveWithPartnerVisitor[IcebergType, Reader]): -read_types:

[GitHub] [iceberg] Fokko commented on a diff in pull request #6525: Python: Refactor loading manifests

Fokko commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1066862697 ## python/pyiceberg/avro/resolver.py: ## @@ -109,38 +109,46 @@ def resolve( class SchemaResolver(PrimitiveWithPartnerVisitor[IcebergType, Reader]): -read_types:

[GitHub] [iceberg] Fokko merged pull request #6555: Python: Expression to disjunctive normal form

Fokko merged PR #6555: URL: https://github.com/apache/iceberg/pull/6555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] pvary commented on pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

pvary commented on PR #6557: URL: https://github.com/apache/iceberg/pull/6557#issuecomment-1378673916 @stevenzwu: We had several issues with Avro, RowData conversions. This is solving one of them - we might not want to solve all of them once and in one PR, but I think we should collect/cons

[GitHub] [iceberg] findepi commented on a diff in pull request #6474: Make it explicit that metrics reporter is required

findepi commented on code in PR #6474: URL: https://github.com/apache/iceberg/pull/6474#discussion_r1066995039 ## core/src/main/java/org/apache/iceberg/BaseTable.java: ## @@ -48,6 +49,7 @@ public BaseTable(TableOperations ops, String name) { } public BaseTable(TableOpera

[GitHub] [iceberg] amogh-jahagirdar commented on pull request #6559: Core: View core parser implementations

amogh-jahagirdar commented on PR #6559: URL: https://github.com/apache/iceberg/pull/6559#issuecomment-1378823387 Agreed @jackye1995 we can break this down further for easier review. I'll raise the version, representation and history entry PRs separately. -- This is an automated message fr

[GitHub] [iceberg] nastra opened a new pull request, #6563: Core: Align commit metric name

nastra opened a new pull request, #6563: URL: https://github.com/apache/iceberg/pull/6563 All other commit metric names use "positional" rather than "position", except for this one. Also the method name to retrieve that metric (`addedPositionalDeleteFiles()`) already has the correct name.

[GitHub] [iceberg] kmozaid commented on a diff in pull request #6410: Configurable metrics reporter by catalog properties

kmozaid commented on code in PR #6410: URL: https://github.com/apache/iceberg/pull/6410#discussion_r1067058918 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -301,4 +305,16 @@ protected static String fullTableName(String catalogName, TableIdentifier i

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6559: Core: View core parser implementations

amogh-jahagirdar commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1067058866 ## core/src/main/java/org/apache/iceberg/view/SQLViewRepresentationParser.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [iceberg] Fokko opened a new issue, #6564: Python write support

Fokko opened a new issue, #6564: URL: https://github.com/apache/iceberg/issues/6564 ### Feature Request / Improvement This is a placeholder ticket for implementing write support for PyIceberg. Since we don't want PyIceberg to write the actual data, and only handle the metadata

[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6565: Core: View history entry core implementation

amogh-jahagirdar opened a new pull request, #6565: URL: https://github.com/apache/iceberg/pull/6565 Co-authored-by: John Zhuge Separating this PR from https://github.com/apache/iceberg/pull/6559/files#diff-2a70d3056d3d0cca0da3ff4ddabc83c41c06af2296f281a5b37c5b54ead98915 for easier r

[GitHub] [iceberg] ajantha-bhat commented on pull request #6461: Spark-3.3: Store sort-order-id in manifest_entry's data_file

ajantha-bhat commented on PR #6461: URL: https://github.com/apache/iceberg/pull/6461#issuecomment-1379088280 @RussellSpitzer: After checking some code. I found that callers has a logic to find the required ordering (by checking distribution table properties for merge/write/update/delete). S

[GitHub] [iceberg] rdblue commented on a diff in pull request #6353: Make sure S3 stream opened by ReadConf ctor is closed

rdblue commented on code in PR #6353: URL: https://github.com/apache/iceberg/pull/6353#discussion_r1067212201 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java: ## @@ -79,9 +83,11 @@ private ReadConf init() { nameMapping, reuseC

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067210433 ## core/src/test/resources/ViewHistoryEntry.json: ## @@ -0,0 +1,4 @@ +{ Review Comment: I think the resources are reserved for full JSON files that might be stor

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067214846 ## core/src/main/java/org/apache/iceberg/view/BaseViewHistoryEntry.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067215702 ## core/src/main/java/org/apache/iceberg/view/ViewHistoryEntryParser.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067215702 ## core/src/main/java/org/apache/iceberg/view/ViewHistoryEntryParser.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067224129 ## core/src/test/java/org/apache/iceberg/view/ParserTestBase.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6565: Core: View history entry core implementation

amogh-jahagirdar commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067224185 ## core/src/main/java/org/apache/iceberg/view/BaseViewHistoryEntry.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067226988 ## core/src/main/java/org/apache/iceberg/view/BaseViewHistoryEntry.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

jackye1995 commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067210433 ## core/src/test/resources/ViewHistoryEntry.json: ## @@ -0,0 +1,4 @@ +{ Review Comment: I think the resources are reserved for full files that might be stored in

[GitHub] [iceberg] dmgcodevil commented on issue #6370: What is the purpose of Hive Lock ?

dmgcodevil commented on issue #6370: URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1379151268 I still don't understand why we need locks if we have transactions and we can implement `optimistic locking` model. -- This is an automated message from the Apache Git Service.

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6565: Core: View history entry core implementation

amogh-jahagirdar commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067231261 ## core/src/test/java/org/apache/iceberg/view/ParserTestBase.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6352: AWS: Fix inconsistent behavior of naming S3 location between read and write operations by allowing only s3 bucket name

danielcweeks commented on code in PR #6352: URL: https://github.com/apache/iceberg/pull/6352#discussion_r1067232103 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java: ## @@ -74,17 +74,14 @@ class S3URI { this.scheme = schemeSplit[0]; String[] authoritySplit =

[GitHub] [iceberg] danielcweeks merged pull request #6352: AWS: Fix inconsistent behavior of naming S3 location between read and write operations by allowing only s3 bucket name

danielcweeks merged PR #6352: URL: https://github.com/apache/iceberg/pull/6352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[GitHub] [iceberg] stevenzwu commented on pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

stevenzwu commented on PR #6557: URL: https://github.com/apache/iceberg/pull/6557#issuecomment-1379226025 > Iceberg shades the Avro version. I updated the Flink doc in this PR already and pointed out that `iceberg-flink-runtime` shaded bundle jar shouldn't be used in this case, as it

[GitHub] [iceberg] amogh-jahagirdar commented on pull request #6565: Core: View history entry core implementation

amogh-jahagirdar commented on PR #6565: URL: https://github.com/apache/iceberg/pull/6565#issuecomment-1379247513 @jackye1995 I updated the PR so it should be a bit simpler now , I agree at this point we don't need the abstractions of base test classes . Thanks for the review! @jzhuge @rdbl

issues@iceberg.apache.org

haizhou-zhao commented on code in PR #6324: URL: https://github.com/apache/iceberg/pull/6324#discussion_r1067317621 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveHadoopUtil.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

issues@iceberg.apache.org

haizhou-zhao commented on code in PR #6324: URL: https://github.com/apache/iceberg/pull/6324#discussion_r1067317866 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveHadoopUtil.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067330294 ## python/pyiceberg/avro/resolver.py: ## @@ -109,38 +109,46 @@ def resolve( class SchemaResolver(PrimitiveWithPartnerVisitor[IcebergType, Reader]): -read_types:

[GitHub] [iceberg] szehon-ho merged pull request #5629: Spark: Add "Iceberg" prefix to SparkTable name string for better observability of Iceberg tables on SparkUI

szehon-ho merged PR #5629: URL: https://github.com/apache/iceberg/pull/5629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

[GitHub] [iceberg] szehon-ho commented on pull request #5629: Spark: Add "Iceberg" prefix to SparkTable name string for better observability of Iceberg tables on SparkUI

szehon-ho commented on PR #5629: URL: https://github.com/apache/iceberg/pull/5629#issuecomment-1379324890 Merged, thanks @sumeetgajjar , @wypoon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [iceberg] szehon-ho merged pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

szehon-ho merged PR #6476: URL: https://github.com/apache/iceberg/pull/6476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

[GitHub] [iceberg] szehon-ho commented on pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

szehon-ho commented on PR #6476: URL: https://github.com/apache/iceberg/pull/6476#issuecomment-137912 Merged, thanks @krvikash , @hililiwei , @amogh-jahagirdar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [iceberg] dramaticlly opened a new issue, #6567: pyiceberg table scan problem with row filter set to non-partition columns

dramaticlly opened a new issue, #6567: URL: https://github.com/apache/iceberg/issues/6567 ### Apache Iceberg version None ### Query engine None ### Please describe the bug 🐞 I really like the new table scan feature released latest pyiceberg 0.2.1 release, t

[GitHub] [iceberg] jackye1995 commented on issue #6523: Table creation fails with Glue catalog on EMR

jackye1995 commented on issue #6523: URL: https://github.com/apache/iceberg/issues/6523#issuecomment-1379360910 @singhpk234 @rajarshisarkar could you take a look into this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [iceberg] erikcw commented on issue #6567: pyiceberg table scan problem with row filter set to non-partition columns

erikcw commented on issue #6567: URL: https://github.com/apache/iceberg/issues/6567#issuecomment-1379415205 I stumbled into the same issue with a slight twist. I deleted all the rows from my table, however pyiceberg is still returning parquet files with those records. Shouldn't those file

[GitHub] [iceberg] Fokko commented on issue #6567: pyiceberg table scan problem with row filter set to non-partition columns

Fokko commented on issue #6567: URL: https://github.com/apache/iceberg/issues/6567#issuecomment-1379472226 @dramaticlly I just checked, and I can confirm that we don't filter on the datafile ranges, this will be implemented very soon 👍🏻 @erikcw Thanks for raising the issue, and we're

[GitHub] [iceberg] erikcw opened a new issue, #6568: pyiceberg table scan returning deleted data

erikcw opened a new issue, #6568: URL: https://github.com/apache/iceberg/issues/6568 ### Apache Iceberg version 1.1.0 (latest release) ### Query engine Other ### Please describe the bug 🐞 I originally mentioned raised this issue in #6567. After deleting row

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

stevenzwu commented on code in PR #6557: URL: https://github.com/apache/iceberg/pull/6557#discussion_r1067488603 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestAvroGenericRecordToRowDataMapper.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [iceberg] sumeetgajjar commented on pull request #5629: Spark: Add "Iceberg" prefix to SparkTable name string for better observability of Iceberg tables on SparkUI

sumeetgajjar commented on PR #5629: URL: https://github.com/apache/iceberg/pull/5629#issuecomment-1379529328 Thanks @wypoon and @szehon-ho for the reviews and for merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

amogh-jahagirdar commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067483646 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -429,29 +470,31 @@ public void testValidateNoConflictsFromSnapshot() { statuses(Stat

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

amogh-jahagirdar commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067482077 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -1270,11 +1332,16 @@ public void testConcurrentNonConflictingRowDeltaAndRewriteFilesWithSequ

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

amogh-jahagirdar commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067501650 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -1270,11 +1332,16 @@ public void testConcurrentNonConflictingRowDeltaAndRewriteFilesWithSequ

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

amogh-jahagirdar commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067520428 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -1449,18 +1519,48 @@ public void testRowDeltaCaseSensitivity() { } @Test - public vo

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067543958 ## python/pyiceberg/avro/reader.py: ## @@ -252,30 +252,33 @@ def skip(self, decoder: BinaryDecoder) -> None: class StructReader(Reader): field_readers: Tuple[Tuple

[GitHub] [iceberg] namrathamyske commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

namrathamyske commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067542176 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -1449,18 +1519,48 @@ public void testRowDeltaCaseSensitivity() { } @Test - public void

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067556636 ## python/pyiceberg/typedef.py: ## @@ -126,30 +135,41 @@ def json(self, exclude_none: bool = True, exclude: Optional[Set[str]] = None, by class PydanticStruct(Iceb

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6382: Implement ShuffleOperator to collect data statistics

stevenzwu commented on code in PR #6382: URL: https://github.com/apache/iceberg/pull/6382#discussion_r1067557305 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatistics.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067557776 ## python/pyiceberg/typedef.py: ## @@ -126,30 +135,41 @@ def json(self, exclude_none: bool = True, exclude: Optional[Set[str]] = None, by class PydanticStruct(Iceb

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067558837 ## python/pyiceberg/typedef.py: ## @@ -126,30 +135,41 @@ def json(self, exclude_none: bool = True, exclude: Optional[Set[str]] = None, by class PydanticStruct(Iceb

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067559792 ## python/pyiceberg/typedef.py: ## @@ -126,30 +135,41 @@ def json(self, exclude_none: bool = True, exclude: Optional[Set[str]] = None, by class PydanticStruct(Iceb

issues@iceberg.apache.org

rdblue commented on code in PR #6324: URL: https://github.com/apache/iceberg/pull/6324#discussion_r1067562662 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveHadoopUtil.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [iceberg] flyrain commented on a diff in pull request #6012: Spark 3.3: Add a procedure to generate table changes

flyrain commented on code in PR #6012: URL: https://github.com/apache/iceberg/pull/6012#discussion_r1067563712 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/GenerateChangesProcedure.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Founda

issues@iceberg.apache.org

rdblue commented on code in PR #6324: URL: https://github.com/apache/iceberg/pull/6324#discussion_r1067564415 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java: ## @@ -247,17 +249,28 @@ public void testReplaceTxnBuilder() throws Exception { @Test

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067581319 ## python/tests/test_typedef.py: ## @@ -46,7 +51,8 @@ def test_record_repr() -> None: def test_named_record() -> None: -r = Record(fields=(NestedField(0, "id",

[GitHub] [iceberg] github-actions[bot] commented on issue #5173: Add Flink test for Parquet bloom filter

github-actions[bot] commented on issue #5173: URL: https://github.com/apache/iceberg/issues/5173#issuecomment-1379643434 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

[GitHub] [iceberg] github-actions[bot] commented on issue #5174: MERGE INTO TABLE is not supported temporarily on Spark3.2.0, Scala2.12, Iceberg0.13.1

github-actions[bot] commented on issue #5174: URL: https://github.com/apache/iceberg/issues/5174#issuecomment-1379643412 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

[GitHub] [iceberg] github-actions[bot] closed issue #5173: Add Flink test for Parquet bloom filter

github-actions[bot] closed issue #5173: Add Flink test for Parquet bloom filter URL: https://github.com/apache/iceberg/issues/5173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests

rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067584072 ## python/pyiceberg/typedef.py: ## @@ -79,6 +84,10 @@ def __missing__(self, key: K) -> V: class StructProtocol(Protocol): # pragma: no cover """A generic protocol

[GitHub] [iceberg] flyrain commented on a diff in pull request #6012: Spark 3.3: Add a procedure to generate table changes

flyrain commented on code in PR #6012: URL: https://github.com/apache/iceberg/pull/6012#discussion_r1067602297 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/GenerateChangesProcedure.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [iceberg] flyrain commented on pull request #6012: Spark 3.3: Add a procedure to generate table changes

flyrain commented on PR #6012: URL: https://github.com/apache/iceberg/pull/6012#issuecomment-1379673208 Ready for another look. cc @RussellSpitzer @szehon-ho @aokolnychyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

hililiwei commented on code in PR #6557: URL: https://github.com/apache/iceberg/pull/6557#discussion_r1067664873 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java: ## @@ -70,6 +78,12 @@ public static class Primitives implements DataGenerator {

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

stevenzwu commented on code in PR #6557: URL: https://github.com/apache/iceberg/pull/6557#discussion_r1067710226 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java: ## @@ -70,6 +78,12 @@ public static class Primitives implements DataGenerator {

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6557: Flink: add support of writing Avro GenericRecord DataStream to Iceberg

stevenzwu commented on code in PR #6557: URL: https://github.com/apache/iceberg/pull/6557#discussion_r1067710226 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java: ## @@ -70,6 +78,12 @@ public static class Primitives implements DataGenerator {

[GitHub] [iceberg] pvary commented on issue #6370: What is the purpose of Hive Lock ?

pvary commented on issue #6370: URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1379883500 With the apache/hive#3888 we can implement a solution which will handle failures the same way as the current one, without using locks, and depending on the `alter_table` to fail. --

[GitHub] [iceberg] JonasJ-ap commented on pull request #6449: Delta: Support Snapshot Delta Lake Table to Iceberg Table

JonasJ-ap commented on PR #6449: URL: https://github.com/apache/iceberg/pull/6449#issuecomment-1379900129 > Also, because the Spark-based tests are under `integrationTest` task, I think we need to create a new CI task to run the tests, otherwise it won't automatically run? I've added

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: Delta: Support Snapshot Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r106276 ## delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [iceberg] nastra opened a new pull request, #6569: Spark: Add the query ID to file names

nastra opened a new pull request, #6569: URL: https://github.com/apache/iceberg/pull/6569 Co-authored-by: Ryan Blue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [iceberg] nastra commented on pull request #5214: Spark: Add the query ID to file names

nastra commented on PR #5214: URL: https://github.com/apache/iceberg/pull/5214#issuecomment-1379936898 Closing this one as it's been superseded by https://github.com/apache/iceberg/pull/6569 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [iceberg] nastra closed pull request #5214: Spark: Add the query ID to file names

nastra closed pull request #5214: Spark: Add the query ID to file names URL: https://github.com/apache/iceberg/pull/5214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu