[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6352: AWS: Fix inconsistent behavior of naming S3 location between read and write operations by allowing only s3 bucket name

[GitBox]

danielcweeks commented on code in PR #6352:
URL: https://github.com/apache/iceberg/pull/6352#discussion_r1067232103


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##########
@@ -74,17 +74,14 @@ class S3URI {
     this.scheme = schemeSplit[0];
 
     String[] authoritySplit = schemeSplit[1].split(PATH_DELIM, 2);
-    ValidationException.check(
-        authoritySplit.length == 2, "Invalid S3 URI, cannot determine bucket: 
%s", location);
-    ValidationException.check(
-        !authoritySplit[1].trim().isEmpty(), "Invalid S3 URI, path is empty: 
%s", location);
+
     this.bucket =
         bucketToAccessPointMapping == null
             ? authoritySplit[0]
             : bucketToAccessPointMapping.getOrDefault(authoritySplit[0], 
authoritySplit[0]);
 
     // Strip query and fragment if they exist
-    String path = authoritySplit[1];
+    String path = authoritySplit.length > 1 ? authoritySplit[1] : "";

Review Comment:
   I think @amogh-jahagirdar meant using java `Optional<String> path()` to 
differentiate empty from having a path.  I would generally agree, but Iceberg 
doesn't currently use optional very much.  I'm inclined to just let this go 
through as-is.  Seems like an uncommon use case, but since it's easy to 
support, we should.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org