[GitHub] [iceberg] nastra commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

nastra commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056076021 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6401: Flink: Change to oldestAncestorAfter

hililiwei commented on code in PR #6401: URL: https://github.com/apache/iceberg/pull/6401#discussion_r1056284703 ## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/ContinuousSplitPlannerImpl.java: ## @@ -213,17 +213,12 @@ static Optional startSnapshot(

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6485: API: New KMS Client Interface

hililiwei commented on code in PR #6485: URL: https://github.com/apache/iceberg/pull/6485#discussion_r1056288379 ## api/src/main/java/org/apache/iceberg/encryption/KmsClient.java: ## @@ -22,7 +22,8 @@ import java.nio.ByteBuffer; import java.util.Map; -/** A minimum client in

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6482: API: Fix inconsistent TimeTransform Type

hililiwei commented on code in PR #6482: URL: https://github.com/apache/iceberg/pull/6482#discussion_r1056334660 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -187,6 +188,53 @@ public void testRemoveAndAddField() { Assert.assertEquals(100

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

hililiwei commented on code in PR #6476: URL: https://github.com/apache/iceberg/pull/6476#discussion_r1056343010 ## core/src/jmh/java/org/apache/iceberg/util/ZOrderByteUtilsBenchmark.java: ## @@ -75,9 +75,8 @@ public void interleaveValuesFourColumns(Blackhole blackhole) { i

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6451: Hive: Lock hardening

hililiwei commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056350192 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -617,9 +624,27 @@ long acquireLock() throws UnknownHostException, TException,

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056352780 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -159,22 +158,26 @@ public void initialize(String name, Map unresolved) { // build the

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6451: Hive: Lock hardening

hililiwei commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056353089 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -759,6 +816,40 @@ private static boolean hiveEngineEnabled(TableMetadata meta

[GitHub] [iceberg] krvikash commented on pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

krvikash commented on PR #6476: URL: https://github.com/apache/iceberg/pull/6476#issuecomment-1364003063 > Good idea. The for-each loop gets rid of the clutter and the opportunity for error by hiding the iterator or index variable. Thanks, @hililiwei for reviewing. Addressed the comme

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056404959 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -787,9 +762,39 @@ private static ConfigResponse fetchConfig( private AuthSession newSessi

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056427267 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -376,5 +409,105 @@ public Pair refresh(RESTClient client) { return null; } + +

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056427267 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -376,5 +409,105 @@ public Pair refresh(RESTClient client) { return null; } + +

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056452911 ## core/src/main/java/org/apache/iceberg/rest/auth/JwtToken.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056458483 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -159,22 +158,26 @@ public void initialize(String name, Map unresolved) { // build the

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056478895 ## core/src/main/java/org/apache/iceberg/rest/auth/JwtToken.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056480552 ## core/src/main/java/org/apache/iceberg/rest/auth/JwtToken.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056480730 ## core/src/main/java/org/apache/iceberg/rest/auth/JwtToken.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056481369 ## core/src/main/java/org/apache/iceberg/rest/auth/JWT.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056482250 ## core/src/main/java/org/apache/iceberg/rest/auth/JWT.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056482915 ## core/src/main/java/org/apache/iceberg/rest/auth/JWT.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056483561 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -101,6 +106,17 @@ public static Map authHeaders(String token) { } } + public static

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056486440 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -302,8 +318,16 @@ public static OAuthTokenResponse tokenResponseFromJson(JsonNode json) {

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056488153 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -159,22 +158,26 @@ public void initialize(String name, Map unresolved) { // build the

[GitHub] [iceberg] nastra commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

nastra commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056488403 ## core/src/main/java/org/apache/iceberg/rest/auth/JWT.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056495387 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -376,5 +409,105 @@ public Pair refresh(RESTClient client) { return null; } + +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056496246 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -787,9 +762,39 @@ private static ConfigResponse fetchConfig( private AuthSession newSessi

[GitHub] [iceberg] rdblue commented on a diff in pull request #6489: Core: Improve token exchange handling when token expires

rdblue commented on code in PR #6489: URL: https://github.com/apache/iceberg/pull/6489#discussion_r1056496838 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -376,5 +409,105 @@ public Pair refresh(RESTClient client) { return null; } + +

[GitHub] [iceberg] rdblue commented on pull request #6479: Core: Java doc fix on method SnapshotUtil::oldestAncestorAfter

rdblue commented on PR #6479: URL: https://github.com/apache/iceberg/pull/6479#issuecomment-1364122824 Thanks for fixing this, @flyrain! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [iceberg] rdblue merged pull request #6479: Core: Java doc fix on method SnapshotUtil::oldestAncestorAfter

rdblue merged PR #6479: URL: https://github.com/apache/iceberg/pull/6479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue merged pull request #6487: Python: Read date as an int

rdblue merged PR #6487: URL: https://github.com/apache/iceberg/pull/6487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue merged pull request #6486: Python: Fix reading UUIDs

rdblue merged PR #6486: URL: https://github.com/apache/iceberg/pull/6486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue merged pull request #6484: Python: Fix PyArrow import

rdblue merged PR #6484: URL: https://github.com/apache/iceberg/pull/6484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056507248 ## python/pyiceberg/exceptions.py: ## @@ -86,3 +86,7 @@ class NotInstalledError(Exception): class SignError(Exception): """Raises when unable to sign a S3 reques

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6344: Spark 3.3: Introduce the changelog iterator

RussellSpitzer commented on code in PR #6344: URL: https://github.com/apache/iceberg/pull/6344#discussion_r1056507876 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056508481 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +756,89 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) -

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056508854 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +756,89 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) -

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6344: Spark 3.3: Introduce the changelog iterator

RussellSpitzer commented on code in PR #6344: URL: https://github.com/apache/iceberg/pull/6344#discussion_r1056508828 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056510924 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +756,89 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) -

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056511463 ## python/pyiceberg/types.py: ## @@ -268,6 +268,10 @@ def __init__(self, *fields: NestedField, **data: Any): data["fields"] = fields super().__init

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056511740 ## python/tests/avro/test_resolver.py: ## @@ -164,17 +163,17 @@ def test_resolver_change_type() -> None: def test_promote_int_to_long() -> None: -assert promote

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056513380 ## python/pyiceberg/schema.py: ## @@ -1046,3 +1055,79 @@ def _project_map(map_type: MapType, value_result: IcebergType) -> MapType: value_type=value_re

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056513590 ## python/pyiceberg/schema.py: ## @@ -1046,3 +1055,79 @@ def _project_map(map_type: MapType, value_result: IcebergType) -> MapType: value_type=value_re

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056513857 ## python/pyiceberg/schema.py: ## @@ -1046,3 +1055,79 @@ def _project_map(map_type: MapType, value_result: IcebergType) -> MapType: value_type=value_re

[GitHub] [iceberg] pvary commented on issue #6370: What is the purpose of Hive Lock ?

pvary commented on issue #6370: URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1364137333 Why would it be based on locks? HMS changes inside a HMS call are transactional. This is essential, otherwise we could end up in a situation where concurrent HMS changes could push

[GitHub] [iceberg] pvary commented on a diff in pull request #6451: Hive: Lock hardening

pvary commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056518850 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -617,9 +624,27 @@ long acquireLock() throws UnknownHostException, TException, Int

[GitHub] [iceberg] pvary commented on a diff in pull request #6451: Hive: Lock hardening

pvary commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056519719 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -759,6 +816,40 @@ private static boolean hiveEngineEnabled(TableMetadata metadata

[GitHub] [iceberg] pvary commented on a diff in pull request #6451: Hive: Lock hardening

pvary commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056523305 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -617,9 +624,27 @@ long acquireLock() throws UnknownHostException, TException, Int

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056538981 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056539354 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056544878 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056550595 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056561905 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056562592 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056563978 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056565986 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056566607 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056566848 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056586064 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056615091 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056615649 ## snowflake/src/test/java/org/apache/iceberg/snowflake/JdbcSnowflakeClientTest.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056616708 ## snowflake/src/test/java/org/apache/iceberg/snowflake/JdbcSnowflakeClientTest.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056616842 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056617707 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056617977 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056619399 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056619704 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056620988 ## core/src/test/java/org/apache/iceberg/io/InMemoryFileIO.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056621897 ## snowflake/src/test/java/org/apache/iceberg/snowflake/FakeSnowflakeClient.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056622011 ## snowflake/src/test/java/org/apache/iceberg/snowflake/SnowflakeCatalogTest.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056622204 ## snowflake/src/test/java/org/apache/iceberg/snowflake/FakeSnowflakeClient.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056623516 ## snowflake/src/test/java/org/apache/iceberg/snowflake/FakeSnowflakeClient.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056628417 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056638166 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056640133 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] findepi commented on a diff in pull request #6474: Make it explicit that metrics reporter is required

findepi commented on code in PR #6474: URL: https://github.com/apache/iceberg/pull/6474#discussion_r1056655699 ## core/src/main/java/org/apache/iceberg/BaseTable.java: ## @@ -48,6 +49,7 @@ public BaseTable(TableOperations ops, String name) { } public BaseTable(TableOpera

[GitHub] [iceberg] dennishuo commented on pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on PR #6428: URL: https://github.com/apache/iceberg/pull/6428#issuecomment-1364368088 @nastra Thanks, happy holidays to you too! I think I got to all your comments, but please let me know if I missed anything -- This is an automated message from the Apache Git Service.

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1056691607 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +465,198 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] github-actions[bot] commented on issue #4962: how to keep only one snapshot each day when write iceberg table with flinkcdc

github-actions[bot] commented on issue #4962: URL: https://github.com/apache/iceberg/issues/4962#issuecomment-1364417459 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

[GitHub] [iceberg] github-actions[bot] closed issue #4962: how to keep only one snapshot each day when write iceberg table with flinkcdc

github-actions[bot] closed issue #4962: how to keep only one snapshot each day when write iceberg table with flinkcdc URL: https://github.com/apache/iceberg/issues/4962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056753163 ## api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java: ## @@ -35,6 +35,11 @@ default MigrateTable migrateTable(String tableIdent) { this.getCl

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056753664 ## data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java: ## @@ -161,7 +161,7 @@ private static Metrics getAvroMetrics(Path path, Configuration conf) {

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056754679 ## delta-lake/src/main/java/org/apache/iceberg/BaseMigrateDeltaLakeTableAction.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056755061 ## delta-lake/src/main/java/org/apache/iceberg/BaseMigrateDeltaLakeTableAction.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056755629 ## delta-lake/src/main/java/org/apache/iceberg/BaseMigrateDeltaLakeTableAction.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056758261 ## delta-lake/src/main/java/org/apache/iceberg/BaseMigrateDeltaLakeTableAction.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056758261 ## delta-lake/src/main/java/org/apache/iceberg/BaseMigrateDeltaLakeTableAction.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056760704 ## api/src/main/java/org/apache/iceberg/actions/MigrateDeltaLakeTable.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6449: WIP: Core, Spark: Adding support for Migrating Delta Lake Table to Iceberg Table

JonasJ-ap commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056760841 ## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java: ## @@ -71,6 +71,8 @@ public static void startMetastoreAndSpark() { .config