dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1056619399
########## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.snowflake; + +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +class NamespaceHelpers { + private static final int MAX_NAMESPACE_DEPTH = 2; + private static final int NAMESPACE_ROOT_LEVEL = 0; + private static final int NAMESPACE_DB_LEVEL = 1; + private static final int NAMESPACE_SCHEMA_LEVEL = 2; + + private static final Logger LOG = LoggerFactory.getLogger(NamespaceHelpers.class); + + private NamespaceHelpers() {} + + /** + * Converts a Namespace into a SnowflakeIdentifier representing ROOT, a DATABASE, or a SCHEMA. + * + * @throws IllegalArgumentException if the namespace is not a supported depth. + */ + public static SnowflakeIdentifier toSnowflakeIdentifier(Namespace namespace) { + SnowflakeIdentifier identifier = null; + switch (namespace.length()) { + case NAMESPACE_ROOT_LEVEL: + identifier = SnowflakeIdentifier.ofRoot(); + break; + case NAMESPACE_DB_LEVEL: + identifier = SnowflakeIdentifier.ofDatabase(namespace.level(NAMESPACE_DB_LEVEL - 1)); + break; + case NAMESPACE_SCHEMA_LEVEL: + identifier = + SnowflakeIdentifier.ofSchema( + namespace.level(NAMESPACE_DB_LEVEL - 1), + namespace.level(NAMESPACE_SCHEMA_LEVEL - 1)); + break; + default: + throw new IllegalArgumentException( + String.format( + "Snowflake max namespace level is %d, got namespace '%s'", + MAX_NAMESPACE_DEPTH, namespace)); + } + LOG.debug("toSnowflakeIdentifier({}) -> {}", namespace, identifier); + return identifier; + } + + /** + * Converts a TableIdentifier into a SnowflakeIdentifier of type TABLE; the identifier must have + * exactly the right namespace depth to represent a fully-qualified Snowflake table identifier. + */ + public static SnowflakeIdentifier toSnowflakeIdentifier(TableIdentifier identifier) { + SnowflakeIdentifier namespaceScope = toSnowflakeIdentifier(identifier.namespace()); + Preconditions.checkArgument( + namespaceScope.type() == SnowflakeIdentifier.Type.SCHEMA, + "Namespace portion of '%s' must be at the SCHEMA level, got namespaceScope '%s'", + identifier, + namespaceScope); + SnowflakeIdentifier ret = + SnowflakeIdentifier.ofTable( + namespaceScope.databaseName(), namespaceScope.schemaName(), identifier.name()); + LOG.debug("toSnowflakeIdentifier({}) -> {}", identifier, ret); + return ret; + } + + /** + * Converts a SnowflakeIdentifier of type ROOT, DATABASE, or SCHEMA into an equivalent Iceberg + * Namespace; throws IllegalArgumentException if not an appropriate type. + */ + public static Namespace toIcebergNamespace(SnowflakeIdentifier identifier) { + Namespace namespace = null; + switch (identifier.type()) { + case ROOT: + namespace = Namespace.of(); + break; + case DATABASE: + namespace = Namespace.of(identifier.databaseName()); + break; + case SCHEMA: + namespace = Namespace.of(identifier.databaseName(), identifier.schemaName()); + break; + default: + throw new IllegalArgumentException( + String.format("Cannot convert identifier '%s' to Namespace", identifier)); + } + LOG.debug("toIcebergNamespace({}) -> {}", identifier, namespace); Review Comment: Mostly the debug-level logging was useful while developing, but probably you're right no one else would really gain anything from it in the future. Removed all the debug-level logging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
