liurenjie1024 merged PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
viirya commented on code in PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#discussion_r1548890936
##
crates/iceberg/src/reader.rs:
##
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
liurenjie1024 commented on PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#issuecomment-2033470850
cc @viirya Would you also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
liurenjie1024 commented on code in PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#discussion_r1548868232
##
crates/iceberg/src/arrow/from.rs:
##
Review Comment:
How about just name it as `schema.rs`, and we can put all schema related
codes here?
#
ZENOTME commented on PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#issuecomment-2033373684
cc @liurenjie1024 @Xuanwo @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
