Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

ZENOTME commented on PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#issuecomment-2241533708 > BTW, why to we need the `RawLiteral` indirection layer, instead of having sth like > > ``` > impl Literal { >fn to_avro(&self) -> avro::Value {...} > } > ```

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685683007 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

xxchan commented on PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#issuecomment-2241526618 BTW, why to we need the `RawLiteral` indirection layer, instead of having sth like ``` impl Literal { fn to_avro(&self) -> avro::Value {...} } ``` -- This is a

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

ZENOTME commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685680951 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_byte

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685680738 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685679257 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

liurenjie1024 merged PR #456: URL: https://github.com/apache/iceberg-rust/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

ZENOTME commented on PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#issuecomment-2226828202 cc @liurenjie1024 @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific