Re: [PR] objstore: Replace IO interface with objstore.Bucket [iceberg-go]

2024-04-03 Thread via GitHub
zeroshade commented on PR #66: URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-2034881770 That's my fault for not responding here, it's been a busy month. My apologies. I would absolutely be willing to approve a cleaned up PR. -- This is an automated message from the

Re: [PR] objstore: Replace IO interface with objstore.Bucket [iceberg-go]

2024-04-03 Thread via GitHub
thorfour commented on PR #66: URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-2034863026 Seems like this repo is relatively inactive. So I'm going to close this for now, and continue in our fork. Thanks! -- This is an automated message from the Apache Git Service. To respon

Re: [PR] objstore: Replace IO interface with objstore.Bucket [iceberg-go]

2024-04-03 Thread via GitHub
thorfour closed pull request #66: objstore: Replace IO interface with objstore.Bucket URL: https://github.com/apache/iceberg-go/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] objstore: Replace IO interface with objstore.Bucket [iceberg-go]

2024-02-26 Thread via GitHub
thorfour commented on PR #66: URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-1965584472 > This seems pretty interesting to me, not sure how I feel about it yet. But that said, I wouldn't want `LoadFS` to return an `objstore.Bucket` because that would tie us to them as an ext

Re: [PR] objstore: Replace IO interface with objstore.Bucket [iceberg-go]

2024-02-26 Thread via GitHub
zeroshade commented on PR #66: URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-1965567918 This seems pretty interesting to me, not sure how I feel about it yet. But that said, I wouldn't want `LoadFS` to return an `objstore.Bucket` because that would tie us to them as an exte