thorfour commented on PR #66: URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-1965584472
> This seems pretty interesting to me, not sure how I feel about it yet. But that said, I wouldn't want `LoadFS` to return an `objstore.Bucket` because that would tie us to them as an external facing dependency. I'd still want what we expose there to be an interface defined here for two reasons: > > 1. It makes it easier in the future to extend and add customizable schemes / file io implementations etc. > 2. We can swap out the underlying implementation in the future if necessary without breaking any consumers I think that's totally reasonable. I suppose that could simply be accomplished by just defining the bucket interface here and then using the objstore definitions that implement it. Let me know if this is something you'd actually want to merge. Would be happy to cleanup the PR as necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
