Xuanwo merged PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2569133599
Thank you @ZENOTME for fixing this and thank you @liurenjie1024 for the
review, let's merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ZENOTME commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1900639882
##
crates/iceberg/src/arrow/schema.rs:
##
@@ -741,7 +766,7 @@ macro_rules! get_parquet_stat_as_datum {
};
Some(Datum::new(
Xuanwo commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1900622944
##
crates/iceberg/src/arrow/schema.rs:
##
@@ -741,7 +766,7 @@ macro_rules! get_parquet_stat_as_datum {
};
Some(Datum::new(
Xuanwo commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2567390885
Thank you, @ZENOTME, for the clarification. Tagging @liurenjie1024 and
@Fokko to review this again.
--
This is an automated message from the Apache Git Service.
To respond to the mess
ZENOTME commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2567382899
> > Hi @liurenjie1024 @Xuanwo , is there other question about this PR?
>
> Hi, I don't quite understand what issue this PR is trying to address. The
test added in this PR is inco
Xuanwo commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2567369698
> Hi @liurenjie1024 @Xuanwo , is there other question about this PR?
Hi, I don't quite understand what issue this PR is trying to address. The
test added in this PR is incorrect,
ZENOTME commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2564967032
Hi @liurenjie1024 @Xuanwo , is there other question about this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ZENOTME commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1897104456
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -1169,4 +1172,187 @@ mod tests {
Ok(())
}
+
+#[tokio::test]
+async fn test_
Xuanwo commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1896852907
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -1169,4 +1172,187 @@ mod tests {
Ok(())
}
+
+#[tokio::test]
+async fn test_d
ZENOTME commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1896851693
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -1169,4 +1172,187 @@ mod tests {
Ok(())
}
+
+#[tokio::test]
+async fn test_
Xuanwo commented on code in PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#discussion_r1896849650
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -1169,4 +1172,187 @@ mod tests {
Ok(())
}
+
+#[tokio::test]
+async fn test_d
ZENOTME commented on PR #837:
URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2561039157
cc @Xuanwo @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
13 matches
Mail list logo
