ZENOTME commented on PR #837: URL: https://github.com/apache/iceberg-rust/pull/837#issuecomment-2567382899
> > Hi @liurenjie1024 @Xuanwo , is there other question about this PR? > > Hi, I don't quite understand what issue this PR is trying to address. The test added in this PR is incorrect, as we can't support such a case unless we use other libraries to handle decimals. I'm also concerned about the root cause of this issue. Is it related to the limitations of our decimal library? Actually, this PR is used to fix case like: [1.1, 2.2](https://github.com/apache/iceberg-rust/pull/837/files#diff-90353a086e76aaeaf0c244575969c53c8ab07a4d6453080a3c0898bee3872fddR1237), so it's not related the limitations of our decimal library. > The test added in this PR is incorrect, as we can't support such a case unless we use other libraries to handle decimals. I'm also concerned about the root cause of this issue. Is it related to the limitations of our decimal library? Let me remove the incorrect the wrong case now. I think I should reuse a decimal library which can support 38 precision and after that we can add the test case back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
