Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

Fokko commented on PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#issuecomment-2553046141 Thanks for fixing this @barronw and thanks for the review @kevinjqliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

Fokko merged PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

barronw commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1890958338 ## pyiceberg/table/name_mapping.py: ## @@ -49,9 +49,10 @@ def convert_null_to_empty_List(cls, v: Any) -> Any: @model_serializer def ser_model(self) ->

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

Fokko commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1890305553 ## pyiceberg/table/name_mapping.py: ## @@ -49,9 +49,10 @@ def convert_null_to_empty_List(cls, v: Any) -> Any: @model_serializer def ser_model(self) -> Di

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889384130 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

barronw commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889379616 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields(se

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

barronw commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889379616 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields(se

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889378149 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

barronw commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889308898 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields(se

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1888945215 ## pyiceberg/table/name_mapping.py: ## @@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results: List[MappedField]) -> List[Map def fields

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

barronw commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1887662401 ## pyiceberg/table/name_mapping.py: ## @@ -333,8 +334,8 @@ def struct(self, struct: StructType, struct_partner: Optional[MappedField], fiel return Stru

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1887165186 ## pyiceberg/table/name_mapping.py: ## Review Comment: In `__str__` https://github.com/apache/iceberg-python/pull/1426/files#diff-55b6571bab1c711ef0bc63

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#issuecomment-2541812934 @barronw looks like theres a linter issue, could you try to run `make lint`? -- This is an automated message from the Apache Git Service. To respond to the message, please log