barronw commented on code in PR #1426:
URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1887662401
##########
pyiceberg/table/name_mapping.py:
##########
@@ -333,8 +334,8 @@ def struct(self, struct: StructType, struct_partner:
Optional[MappedField], fiel
return StructType(*field_results)
def field(self, field: NestedField, field_partner: Optional[MappedField],
field_result: IcebergType) -> IcebergType:
- if field_partner is None:
- raise ValueError(f"Field missing from NameMapping:
{'.'.join(self.current_path)}")
+ if field_partner is None or field_partner.field_id is None:
Review Comment:
This should just be a type check since `NestedField` expects a field ID
below. The field partner is looked up by field ID before being passed into this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
