Xuanwo merged PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899617626
##
crates/iceberg/src/lib.rs:
##
@@ -73,6 +73,7 @@ mod avro;
pub mod io;
pub mod spec;
+pub mod metadata_scan;
Review Comment:
Should be changed in to `metada
xxchan commented on PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#issuecomment-2565569786
Thanks for the review. Updated. Please take a another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Xuanwo commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899563681
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,256 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
flaneur2020 commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899550638
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
flaneur2020 commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899550638
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899524723
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899521913
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899506899
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
Xuanwo commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899497857
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899477072
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
Xuanwo commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899399546
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
rshkv commented on PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#issuecomment-2564747091
Yeah, totally!
> BTW I think we can also change the details like signatures and fields on
demand later.
Yeah that's what I was worried about. Sg. 👍🏻
--
This is an autom
flaneur2020 commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899100103
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
xxchan commented on PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#issuecomment-2564592025
@rshkv Thanks for the review and the follow-up work. I just want to wait for
the maintainers to make sure the framework looks good before applying any
suggestions :p
BTW I thin
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1898945557
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1898944524
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1897394640
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1897394640
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
xxchan commented on PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#issuecomment-2551445439
cc @liurenjie1024 @Xuanwo @Fokko @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1890233895
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
xxchan commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1890237532
##
crates/iceberg/src/scan.rs:
##
@@ -981,13 +981,14 @@ mod tests {
use crate::table::Table;
use crate::TableIdent;
-struct TableTestFixture {
+pu
22 matches
Mail list logo
