Xuanwo commented on code in PR #822: URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1899617626
########## crates/iceberg/src/lib.rs: ########## @@ -73,6 +73,7 @@ mod avro; pub mod io; pub mod spec; +pub mod metadata_scan; Review Comment: Should be changed in to `metadata_table`. ########## crates/iceberg/src/table.rs: ########## @@ -200,6 +201,12 @@ impl Table { TableScanBuilder::new(self) } + /// Creates a metadata table which provides table-like APIs for inspecting metadata. + /// See [`MetadataTable`] for more details. + pub fn metadata_table(self) -> MetadataTable { Review Comment: Better to use `&self` here to align with other APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org