Fokko commented on PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1781750232
Thanks for working on this @barronw and @liurenjie1024, @Xuanwo and @ZENOTME
for the review 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Fokko commented on PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1781749468
@barronw No, I think we're good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
Fokko merged PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
barronw commented on PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1773869837
@Fokko Are there any other changes that need to be made?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1363755844
##
crates/iceberg/src/avro/schema.rs:
##
@@ -96,7 +98,13 @@ impl SchemaVisitor for SchemaToAvroSchema {
_struct: &StructType,
results: Vec,
) ->
barronw commented on PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1768315223
> @barronw This is great! One question, do we need the Avro file (the one in
`testdata/`)? I don't see it being referenced, and we generally try to avoid
binary data in the repository.
Xuanwo commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1363344838
##
crates/iceberg/src/avro/schema.rs:
##
@@ -96,7 +98,13 @@ impl SchemaVisitor for SchemaToAvroSchema {
_struct: &StructType,
Review Comment:
Undetstood. T
liurenjie1024 commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1363213683
##
crates/iceberg/src/avro/schema.rs:
##
@@ -96,7 +98,13 @@ impl SchemaVisitor for SchemaToAvroSchema {
_struct: &StructType,
Review Comment:
The `_
Xuanwo commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1363171863
##
crates/iceberg/src/avro/schema.rs:
##
@@ -96,7 +98,13 @@ impl SchemaVisitor for SchemaToAvroSchema {
_struct: &StructType,
results: Vec,
) ->
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1362965809
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
liurenjie1024 commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361435611
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361425336
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361422612
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
liurenjie1024 commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1361411731
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe
Fokko commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1360636839
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1025,108 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-810f
liurenjie1024 commented on PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1763745002
CC @Xuanwo @JanKaul PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1358889289
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -90,24 +113,72 @@ impl ManifestList {
];
Schema::builder().with_fields(fields).build().unwrap()
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1358866633
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -69,6 +73,25 @@ impl ManifestList {
&self.entries
}
+/// Get the v1 schema of the manifest list
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1358866184
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1017,104 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
ZENOTME commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1356073854
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -90,24 +113,72 @@ impl ManifestList {
];
Schema::builder().with_fields(fields).build().unwrap()
ZENOTME commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1356071291
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -69,6 +73,25 @@ impl ManifestList {
&self.entries
}
+/// Get the v1 schema of the manifest list
liurenjie1024 commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1354363331
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -90,24 +113,72 @@ impl ManifestList {
];
Schema::builder().with_fields(fields).build().unwra
liurenjie1024 commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1354356246
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1017,104 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1353723342
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -69,6 +73,25 @@ impl ManifestList {
&self.entries
}
+/// Get the v1 schema of the manifest list
29 matches
Mail list logo
