barronw commented on PR #76: URL: https://github.com/apache/iceberg-rust/pull/76#issuecomment-1768315223
> @barronw This is great! One question, do we need the Avro file (the one in `testdata/`)? I don't see it being referenced, and we generally try to avoid binary data in the repository. The Avro files are used to test `ManifestList::parse_with_version` in `test_parse_manifest_list_v1` and `test_parse_manifest_list_v2`. `ManifestList::parse_with_version` is used to test `ManifestListWriter`, so I don't think we should also use `ManifestListWriter` to generate the Avro files to test `ManifestList::parse_with_version`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
