wolfeidau commented on PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#issuecomment-2156294155
@zeroshade I have had a shot at tidying this feature and addressing your
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wolfeidau commented on PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#issuecomment-2078141567
@zeroshade I will dig into this in the next few days, I have implemented the
builder for tables but need a way to have a generic path builder.
Given I have time off next week I ca
zeroshade commented on PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#issuecomment-2073185271
any updates @wolfeidau?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
wolfeidau commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1504998764
##
table/metadata.go:
##
@@ -399,3 +400,32 @@ func (m *MetadataV2) UnmarshalJSON(b []byte) error {
m.preValidate()
return m.validate()
}
+
+func NewMe
wolfeidau commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1504982899
##
docs/cfn/AWS_TESTING.md:
##
@@ -0,0 +1,74 @@
+
+
+# AWS integration testing
+
Review Comment:
@zeroshade good question, it was currently a bit adhoc, and mostly
wolfeidau commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1504979600
##
catalog/catalog.go:
##
@@ -185,3 +197,33 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identifi
wolfeidau commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1504975878
##
catalog/catalog.go:
##
@@ -185,3 +197,33 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identifi
zeroshade commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1503479405
##
table/metadata.go:
##
@@ -399,3 +400,32 @@ func (m *MetadataV2) UnmarshalJSON(b []byte) error {
m.preValidate()
return m.validate()
}
+
+func NewMe
zeroshade commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1503478251
##
docs/cfn/AWS_TESTING.md:
##
@@ -0,0 +1,74 @@
+
+
+# AWS integration testing
+
Review Comment:
why `/docs/cfn/` ? What is `cfn`?
--
This is an automated mess
zeroshade commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1503477206
##
catalog/catalog.go:
##
@@ -185,3 +197,33 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identifi
zeroshade commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1503476723
##
catalog/catalog.go:
##
@@ -185,3 +197,33 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identifi
11 matches
Mail list logo
