wolfeidau commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1504998764


##########
table/metadata.go:
##########
@@ -399,3 +400,32 @@ func (m *MetadataV2) UnmarshalJSON(b []byte) error {
        m.preValidate()
        return m.validate()
 }
+
+func NewMetadataV2(schema *iceberg.Schema, partitionSpec 
iceberg.PartitionSpec, sortOrder SortOrder, location string, tableUUID 
uuid.UUID, properties iceberg.Properties) (*MetadataV2, error) {

Review Comment:
   @zeroshade Yeah i thought about that, the only "optional" thing is 
properties, some have "empty values" like sort order and partition spec so it 
may work OK.
   
   I will try out a builder and post an update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to