Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2025-01-03 Thread via GitHub
liurenjie1024 commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1901611620 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +128,133 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a>

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2025-01-03 Thread via GitHub
Xuanwo commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1901609600 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +128,133 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a> { +

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2025-01-03 Thread via GitHub
liurenjie1024 commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1901601914 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +128,133 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a>

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2025-01-01 Thread via GitHub
Xuanwo merged PR #861: URL: https://github.com/apache/iceberg-rust/pull/861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
flaneur2020 commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900324950 ## crates/iceberg/src/metadata_scan.rs: ## @@ -50,6 +52,13 @@ impl MetadataTable { } } +/// Get the manifests table. +pub fn manifests(&s

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
flaneur2020 commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900324416 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +137,135 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a> {

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
flaneur2020 commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900324391 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +137,135 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a> {

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
xxchan commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900309436 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +137,135 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a> { +

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
xxchan commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900309256 ## crates/iceberg/src/metadata_scan.rs: ## @@ -128,6 +137,135 @@ impl<'a> SnapshotsTable<'a> { } } +/// Manifests table. +pub struct ManifestsTable<'a> { +

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
Xuanwo commented on code in PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900169821 ## crates/iceberg/src/metadata_scan.rs: ## @@ -50,6 +52,13 @@ impl MetadataTable { } } +/// Get the manifests table. +pub fn manifests(&self)

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-31 Thread via GitHub
flaneur2020 commented on PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#issuecomment-2566334491 @Xuanwo merged the main branch, PTAL 🫡 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: Support metadata table "Manifests" [iceberg-rust]

2024-12-30 Thread via GitHub
Xuanwo commented on PR #861: URL: https://github.com/apache/iceberg-rust/pull/861#issuecomment-2565637534 https://github.com/apache/iceberg-rust/pull/822 has been merged, let's move on! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t