flaneur2020 commented on code in PR #861:
URL: https://github.com/apache/iceberg-rust/pull/861#discussion_r1900324391


##########
crates/iceberg/src/metadata_scan.rs:
##########
@@ -128,6 +137,135 @@ impl<'a> SnapshotsTable<'a> {
     }
 }
 
+/// Manifests table.
+pub struct ManifestsTable<'a> {
+    metadata_table: &'a MetadataTable,
+}
+
+impl<'a> ManifestsTable<'a> {
+    fn partition_summary_fields(&self) -> Vec<Field> {
+        vec![
+            Field::new("contains_null", DataType::Boolean, false),
+            Field::new("contains_nan", DataType::Boolean, true),
+            Field::new("lower_bound", DataType::Utf8, true),
+            Field::new("upper_bound", DataType::Utf8, true),
+        ]
+    }
+
+    fn schema(&self) -> Schema {

Review Comment:
   fixed in 83e8811



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to