Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-27 Thread via GitHub
liurenjie1024 merged PR #703: URL: https://github.com/apache/iceberg-rust/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-27 Thread via GitHub
liurenjie1024 commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1861419228 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,502 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1860040274 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,502 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1860035033 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,502 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1860022862 ## crates/iceberg/src/arrow/record_batch_projector.rs: ## @@ -0,0 +1,288 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1858556644 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,421 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1858083873 ## crates/iceberg/src/arrow/record_batch_projector.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1858032287 ## crates/iceberg/src/arrow/record_batch_projector.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-25 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1856341663 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,538 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-25 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1856217345 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,538 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-24 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1855711268 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,544 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-24 Thread via GitHub
liurenjie1024 commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1855688069 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,538 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-20 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1850443990 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,544 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-20 Thread via GitHub
ZENOTME commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1850434941 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,544 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-20 Thread via GitHub
liurenjie1024 commented on code in PR #703: URL: https://github.com/apache/iceberg-rust/pull/703#discussion_r1850357817 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,544 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-11-19 Thread via GitHub
ZENOTME commented on PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#issuecomment-2485706164 Hi, I find that this PR has some fail. I try to fix it in #703. To simplify the review, I separate this PR and fix into two commits. Feel free to tell me if something needs to be refin

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-10-16 Thread via GitHub
Dysprosium0626 commented on PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#issuecomment-2416592053 > Hi, I'm sorry, but I need to revert this PR. @Dysprosium0626, could you reopen and rebase your original PR and test it again? Okay, I will reopen this PR after test it a

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-10-14 Thread via GitHub
Xuanwo commented on PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#issuecomment-2412889476 Hi, I'm sorry, but I need to revert this PR. @Dysprosium0626, could you reopen and rebase your original PR and test it again? -- This is an automated message from the Apache Git Servi

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-10-14 Thread via GitHub
Xuanwo merged PR #372: URL: https://github.com/apache/iceberg-rust/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-06-04 Thread via GitHub
ZENOTME commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1626973971 ## crates/iceberg/src/writer/mod.rs: ## @@ -92,6 +92,7 @@ pub trait CurrentFileStatus { #[cfg(test)] mod tests { + Review Comment: Remove this? ##

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-29 Thread via GitHub
Dysprosium0626 commented on PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#issuecomment-2136687629 @ZENOTME @sdd PTAL! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-22 Thread via GitHub
Dysprosium0626 commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609490106 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-21 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609377510 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-21 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609375064 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-21 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609372918 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-21 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609372170 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-20 Thread via GitHub
ZENOTME commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1607504466 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c