Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

liurenjie1024 merged PR #963: URL: https://github.com/apache/iceberg-rust/pull/963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2673583467 @liurenjie1024 @Fokko Thank you for the reviews, problems should be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

liurenjie1024 commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1962804393 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1567 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1955029747 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2657587163 @Fokko Thanks for the review. I got a bit mixed up with the logic with only nulls vs may contain null 😆. Should be good now -- This is an automated message from the Apache Git Se

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1955105071 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1955094766 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1955029747 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

Fokko commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1954322029 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2655357114 Tests have been added, this implementation follows the pyiceberg implementation. cc @Fokko @liurenjie1024 @ZENOTME -- This is an automated message from the Apache Git Service. T

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2652648861 Tests will be added tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s